+
+
<%= I18n.t('spl.coupons.find.checkout_list') if @coupons.present? %>
+
+ <% @coupons&.each do |coupon| %>
+ <%= coupon["typeCustomerName"] %>
+ <% if coupon.dig("couponType", "autoLoad") == "A" %>
+ <% if coupon["autoLoad"] %>
+ <%= button_to I18n.t('spl.coupons.deactivate'),
+ deactivate_coupon_coupons_path(
+ order: @order,
+ token: @order.token,
+ coupon_code: coupon["code"]
+ ),
+ method: :post,
+ data: { turbo: true },
+ class: "min-h-full ml-3 btn-primary !px-4 !py-3" %>
+ <% else %>
+ <%= button_to I18n.t('spl.coupons.activate'),
+ activate_coupon_coupons_path(
+ order: @order,
+ token: @order.token,
+ coupon_code: coupon["code"]
+ ),
+ method: :post,
+ data: { turbo: true },
+ class: "min-h-full ml-3 btn-primary !px-4 !py-3" %>
+ <% end %>
+ <% end %>
+ <% end %>
+
+
diff --git a/app/views/spree/checkout/activate_coupon.turbo_stream.erb b/app/views/spree/checkout/activate_coupon.turbo_stream.erb
new file mode 100644
index 0000000..aa53e8b
--- /dev/null
+++ b/app/views/spree/checkout/activate_coupon.turbo_stream.erb
@@ -0,0 +1,4 @@
+<%= turbo_stream.replace "checkout_coupons" do %>
+ <%= render partial: "spree/checkout/spl_coupons",
+ locals: { coupons: @coupons, order: @order } %>
+<% end %>
\ No newline at end of file
diff --git a/app/views/spree/checkout/deactivate_coupon.turbo_stream.erb b/app/views/spree/checkout/deactivate_coupon.turbo_stream.erb
new file mode 100644
index 0000000..03de1fa
--- /dev/null
+++ b/app/views/spree/checkout/deactivate_coupon.turbo_stream.erb
@@ -0,0 +1,4 @@
+<%= turbo_stream.replace "checkout_coupons" do %>
+ <%= render partial: "spree/checkout/spl_coupons",
+ locals: { coupons: @coupons, order: @order } %>
+<% end %>
diff --git a/config/locales/cs.yml b/config/locales/cs.yml
index 21aec17..00fd0bc 100644
--- a/config/locales/cs.yml
+++ b/config/locales/cs.yml
@@ -11,7 +11,7 @@ cs:
code_label: One-time code
errors:
must_accept_yc_terms: You must accept the loyalty club terms and conditions to continue
- invalid_phone: Podaj poprawny numer telefonu
+ invalid_phone: Invalid phone number
card_validation:
errors:
card_not_active: Karta není aktivní
@@ -20,6 +20,8 @@ cs:
coupons:
find:
checkout_list: Your SPL coupons
+ activate: Activate
+ deactivate: Deactivate
profile:
connect_button: Connect to your loyalty account
errors:
@@ -40,3 +42,6 @@ cs:
send_log_in_code: Send one-time code for log in
send_registration_code: Send one-time code for registration
verify_button: Verify phone number
+ user:
+ card_number: The club card number has been assigned to the account
+ card_active: SPL card activation
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 46a8434..3c3759d 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -11,15 +11,17 @@ en:
code_label: One-time code
errors:
must_accept_yc_terms: You must accept the loyalty club terms and conditions to continue
- invalid_phone: Podaj poprawny numer telefonu
- coupons:
- find:
- checkout_list: Your SPL coupons
+ invalid_phone: Invalid phone number
card_validation:
errors:
card_not_active: Card is not active
card_not_match: Card doesnt match user's card number
wrong_owner: Card assigned to a different user
+ coupons:
+ find:
+ checkout_list: Your SPL coupons
+ activate: Activate
+ deactivate: Deactivate
profile:
connect_button: Connect to your loyalty account
errors:
diff --git a/config/locales/pl.yml b/config/locales/pl.yml
index ffa5a3d..a706b06 100644
--- a/config/locales/pl.yml
+++ b/config/locales/pl.yml
@@ -20,6 +20,11 @@ pl:
card_not_active: Karta nie jest aktywna
card_not_match: Karta nie jest zgodna z numerem karty użytkownika
wrong_owner: Karta przypisana innemu użytkownikowi
+ coupons:
+ find:
+ checkout_list: Twoje kupony lojalnościowe
+ activate: Aktywuj
+ deactivate: Dezaktywuj
errors:
generic: Nie udało się połączyć konta lojalnościowego. Spróbuj ponownie.
auth_temporary_blocked: Zbyt wiele nieudanych prób. Spróbuj ponownie później.
diff --git a/config/locales/sk.yml b/config/locales/sk.yml
index ddca18a..2d0ea11 100644
--- a/config/locales/sk.yml
+++ b/config/locales/sk.yml
@@ -11,7 +11,7 @@ sk:
code_label: One-time code
errors:
must_accept_yc_terms: You must accept the loyalty club terms and conditions to continue
- invalid_phone: Podaj poprawny numer telefonu
+ invalid_phone: Invalid phone number
card_validation:
errors:
card_not_active: Karta nie je aktívna
@@ -20,6 +20,8 @@ sk:
coupons:
find:
checkout_list: Your SPL coupons
+ activate: Activate
+ deactivate: Deactivate
profile:
connect_button: Connect to your loyalty account
errors:
@@ -40,3 +42,6 @@ sk:
send_log_in_code: Send one-time code for log in
send_registration_code: Send one-time code for registration
verify_button: Verify phone number
+ user:
+ card_number: The club card number has been assigned to the account
+ card_active: SPL card activation
diff --git a/config/routes.rb b/config/routes.rb
index 48609ba..7be4eff 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -16,6 +16,10 @@
end
end
end
+ resource :checkout, as: 'coupons', controller: :checkout, only: %i[show create update] do
+ post :activate_coupon, to: 'checkout#activate_coupon'
+ post :deactivate_coupon, to: 'checkout#deactivate_coupon'
+ end
namespace :account do
resource :profile, controller: :profile, only: [:edit, :update] do
patch :registration_code
diff --git a/spec/controllers/checkout_controller_decorator_spec.rb b/spec/controllers/checkout_controller_decorator_spec.rb
index cc3cb13..ad55ddd 100644
--- a/spec/controllers/checkout_controller_decorator_spec.rb
+++ b/spec/controllers/checkout_controller_decorator_spec.rb
@@ -2,170 +2,184 @@
require 'rails_helper'
-RSpec.describe Spree::CheckoutController, type: :controller do
- let(:store) do
- create(:store, private_metadata: {
- 'spl_url' => 'https://fake-spl.example.com',
- 'spl_mode' => 'test',
- 'spl_pos_key' => 'fake-pos-key',
- 'spl_api_user' => 'fake-api-user',
- 'spl_prg_code' => 'fake-prg-code',
- 'spl_sale_url' => 'https://fake-spl.example.com/sale',
- 'spl_api_token' => 'fake-token',
- 'spl_place_code' => 'fake-place',
- 'spl_partner_code' => 'fake-partner',
- 'spl_signature_seed' => 'fake-seed'
- })
- end
+RSpec.describe Spl::Spree::Storefront::CheckoutControllerDecorator, type: :controller do
+ controller(ActionController::Base) do
+ before_action :set_order
+
+ def checkout_path
+ '/checkout'
+ end
+
+ def show
+ render plain: 'ok'
+ end
+
+ # Provided by decorator; defined here so Rails can dispatch
- let!(:state) { create(:state, country: create(:country_us), name: 'Gdansk', abbr: 'GDA') }
- let(:user) { create(:user, public_metadata: { 'spl_no_card' => '1234567890123', 'spl_card_active' => 'true' }) }
-
- let(:order) do
- create(
- :order_with_totals,
- store: store,
- user: user,
- email: 'test@example.com',
- public_metadata: {
- 'spl_no_card' => '1234567890123',
- 'spl_card_active' => 'true'
- }
- )
+ private
+
+ def set_order
+ @order = Spree::Order.first
+ end
end
before do
- allow(controller).to receive_messages(current_store: store, try_spree_current_user: user, spree_current_user: user,
- spree_signup_path: '/signup', spree_login_path: '/login')
-
- stub_request(:any, /fake-spl\.example\.com/).to_return(
- status: 200,
- body: {
- 'errorCode' => '0',
- 'response' => {
- 'basket' => order.line_items.map do |li|
- {
- 'pos' => li.id,
- 'discounts' => [
- {
- 'name' => 'TEST'
- }
- ],
- 'discountGross' => 5.0
- }
- end
- }
- }.to_json,
- headers: { 'Content-Type' => 'application/json' }
- )
-
- allow_any_instance_of(Spree::Order).to receive(:recalculate).and_return(true)
+ controller.class.prepend described_class
+ routes.draw do
+ get '/checkout', to: 'anonymous#show'
+ post '/checkout/activate_coupon', to: 'anonymous#activate_coupon'
+ post '/checkout/deactivate_coupon', to: 'anonymous#deactivate_coupon'
+ end
+ allow(request).to receive(:url).and_return('http://test.host/checkout')
+ end
+
+ let(:country) { create(:country) }
+ let!(:store) { create(:store, default_country: country) }
+
+ let!(:user) { create(:user) }
+ let!(:order) do
+ create(:order,
+ store: store,
+ user: user)
end
describe '#promotion_switcher' do
- context 'creates a new SPL adjustment' do
- it 'with SPL source_type' do
- post :update, params: { state: 'address', token: order.token }
+ it "calls PromotionSwitcherService with confirm=false when URL does not include 'confirm'" do
+ switcher = instance_double('PromotionSwitcherService', call: true)
+ expect(PromotionSwitcherService).to receive(:new).with(order, false).and_return(switcher)
- expect(order.line_items.last.adjustments.last.source_type).to eq('SPL')
- end
+ allow(Spl::Coupons::GetCouponsService)
+ .to receive(:new).with(user, store)
+ .and_return(instance_double('Spl::Coupons::GetCouponsService', call: []))
+
+ get :show
+ expect(response).to have_http_status(:ok)
+ end
- it 'with amount from discountGross' do
- post :update, params: { state: 'address', token: order.token }
+ it "calls PromotionSwitcherService with confirm=true when URL includes 'confirm'" do
+ allow_any_instance_of(ActionDispatch::Request)
+ .to receive(:url)
+ .and_return('http://test.host/checkout/confirm')
- expect(order.line_items.last.adjustments.last.amount).to eq(-5.0)
- end
+ switcher = instance_double('PromotionSwitcherService', call: true)
+ expect(PromotionSwitcherService).to receive(:new).with(order, true).and_return(switcher)
+
+ allow(Spl::Coupons::GetCouponsService)
+ .to receive(:new).with(user, store)
+ .and_return(instance_double('Spl::Coupons::GetCouponsService', call: []))
+
+ get :show
+ expect(response).to have_http_status(:ok)
end
+ end
- context 'when SPL API response has no line_items (unhappy path)' do
- before do
- stub_request(:any, /fake-spl\.example\.com/).to_return(
- status: 200,
- body: {
- 'errorCode' => '0',
- 'response' => {
- 'basket' => []
- }
- }.to_json,
- headers: { 'Content-Type' => 'application/json' }
- )
- end
+ describe '#load_user_coupons' do
+ it 'loads coupons for user/store and assigns @coupons' do
+ allow(PromotionSwitcherService)
+ .to receive(:new)
+ .and_return(instance_double('PromotionSwitcherService', call: true))
- it 'does NOT create SPL adjustments' do
- expect do
- post :update, params: { state: 'address', token: order.token }
- end.not_to(change { order.line_items.first.adjustments.count })
- end
+ coupons_service = instance_double('Spl::Coupons::GetCouponsService', call: %w[c1 c2])
+ expect(Spl::Coupons::GetCouponsService)
+ .to receive(:new).with(user, store).and_return(coupons_service)
+
+ get :show
+
+ expect(response).to have_http_status(:ok)
+ expect(assigns(:coupons)).to eq(%w[c1 c2])
end
- context 'when SPL API response has no discounts (unhappy path)' do
- before do
- stub_request(:any, /fake-spl\.example\.com/).to_return(
- status: 200,
- body: {
- 'errorCode' => '0',
- 'response' => {
- 'basket' => order.line_items.map do |li|
- {
- 'pos' => li.id,
- 'discounts' => [],
- 'discountGross' => 0.0
- }
- end
- }
- }.to_json,
- headers: { 'Content-Type' => 'application/json' }
- )
- end
+ it 'does not run load_user_coupons as a before_action for activate_coupon' do
+ allow(PromotionSwitcherService)
+ .to receive(:new)
+ .and_return(instance_double('PromotionSwitcherService', call: true))
- it 'does NOT create SPL adjustments' do
- expect do
- post :update, params: { state: 'address', token: order.token }
- end.not_to(change { order.line_items.first.adjustments.count })
- end
+ # This will still be called (inside #activate_coupon), but we can ensure it is not called twice.
+ coupons_service = instance_double('Spl::Coupons::GetCouponsService', call: [])
+ expect(Spl::Coupons::GetCouponsService).to receive(:new).with(user, store).once.and_return(coupons_service)
+
+ allow(Spl::Coupons::ActivateCouponService)
+ .to receive(:new)
+ .and_return(instance_double('Spl::Coupons::ActivateCouponService', call: true))
+
+ post :activate_coupon, params: { coupon_code: 'YOLO_90' }, format: :html
end
end
- describe '#load_user_coupons' do
- let!(:order) { create(:order) }
- let!(:service) { instance_double(Spl::GetCouponsService) }
+ describe '#activate_coupon' do
+ let(:activate) { instance_double(Spl::Coupons::ActivateCouponService, call: true) }
before do
- allow(controller).to receive(:order).and_return(order)
- controller.instance_variable_set(:@order, order)
- allow(Spl::GetCouponsService).to receive(:new)
- .with(order.user, order.store)
- .and_return(service)
+ allow(controller).to receive(:try_spree_current_user).and_return(user)
end
- subject(:load_user_coupons) { controller.send(:load_user_coupons) }
+ context 'when coupon is valid' do
+ it 'calls ActivateCouponService, reloads coupons, and redirects (HTML)' do
+ expect(Spl::Coupons::ActivateCouponService)
+ .to receive(:new).with(user, store, 'YOLO_90').and_return(activate)
- context 'when the service returns coupons' do
- let(:coupons) { %w[COUP1 COUP2] }
+ coupons_service = instance_double('Spl::Coupons::GetCouponsService', call: %w[YOLO_90])
+ expect(Spl::Coupons::GetCouponsService)
+ .to receive(:new).with(user, store).and_return(coupons_service)
- before { allow(service).to receive(:call).and_return(coupons) }
+ post :activate_coupon, params: { coupon_code: 'YOLO_90' }, format: :html
- it 'sets @coupons' do
- load_user_coupons
- expect(assigns(:coupons)).to eq(coupons)
+ expect(assigns(:coupons)).to eq(%w[YOLO_90])
+ expect(response).to have_http_status(:found)
+ expect(response.location).to include('/checkout')
end
end
- context 'when the service returns an empty array' do
- before { allow(service).to receive(:call).and_return([]) }
+ context 'when coupon is invalid' do
+ it 'still redirects even if ActivateCouponService raises' do
+ expect(Spl::Coupons::ActivateCouponService).to receive(:new).with(user, store, 'YOLO_90').and_return(activate)
+ expect(activate).to receive(:call).and_raise(Spl::Coupons::ActivateCouponService::ActivateCouponServiceError,
+ 'some error')
+
+ expect do
+ post :activate_coupon, params: { coupon_code: 'YOLO_90' }, format: :html
+ end.to raise_error('some error')
- it 'sets @coupons to an empty array' do
- load_user_coupons
- expect(assigns(:coupons)).to eq([])
+ expect(response).to have_http_status(:found)
+ expect(response.location).to include('/checkout')
end
end
+ end
+
+ describe '#deactivate_coupon' do
+ before do
+ allow(controller).to receive(:try_spree_current_user).and_return(user)
+ end
- context 'when the service raises an error' do
- before { allow(service).to receive(:call).and_raise(StandardError.new('fail')) }
+ it 'calls DeactivateCouponService, reloads coupons, and redirects (HTML)' do
+ deactivate = instance_double('Spl::Coupons::DeactivateCouponService', call: true)
+ expect(Spl::Coupons::DeactivateCouponService)
+ .to receive(:new).with(user, store, 'YOLO_90').and_return(deactivate)
- it 'propagates the error' do
- expect { load_user_coupons }.to raise_error(StandardError, 'fail')
- end
+ coupons_service = instance_double('Spl::Coupons::GetCouponsService', call: %w[YOLO_90])
+ expect(Spl::Coupons::GetCouponsService)
+ .to receive(:new).with(user, store).and_return(coupons_service)
+
+ post :deactivate_coupon, params: { coupon_code: 'YOLO_90' }, format: :html
+
+ expect(assigns(:coupons)).to eq(%w[YOLO_90])
+ expect(response).to have_http_status(:found)
+ expect(response.location).to include('/checkout')
+ end
+
+ it 'still redirects even if DeactivateCouponService raises' do
+ deactivate = instance_double('Spl::Coupons::DeactivateCouponService')
+ expect(Spl::Coupons::DeactivateCouponService).to receive(:new).with(user, store, 'YOLO_90').and_return(deactivate)
+ expect(deactivate).to receive(:call).and_raise(
+ Spl::Coupons::DeactivateCouponService::DeactivateCouponServiceError, 'some error'
+ )
+
+ expect do
+ post :deactivate_coupon, params: { coupon_code: 'YOLO_90' }, format: :html
+ end.to raise_error('some error')
+
+ expect(response).to have_http_status(:found)
+ expect(response.location).to include('/checkout')
end
end
end
diff --git a/spec/services/phone_parser_service_spec.rb b/spec/services/phone_parser_service_spec.rb
index 5c2bcdb..29c8a25 100644
--- a/spec/services/phone_parser_service_spec.rb
+++ b/spec/services/phone_parser_service_spec.rb
@@ -20,7 +20,7 @@
end
it 'delegates to the parsed phone object' do
- expect(described_class.new('anything')).to be_valid
+ expect(described_class.new('+48500600700')).to be_valid
end
end
diff --git a/spec/services/spl/coupons/activate_coupon_service_spec.rb b/spec/services/spl/coupons/activate_coupon_service_spec.rb
new file mode 100644
index 0000000..0569557
--- /dev/null
+++ b/spec/services/spl/coupons/activate_coupon_service_spec.rb
@@ -0,0 +1,132 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Spl::Coupons::ActivateCouponService do
+ subject(:service) { described_class.new(user, store, params) }
+
+ let(:user) { create(:user) }
+ let(:store) { Spree::Store.default }
+
+ let(:spl_url) { 'https://spl.example.test' }
+ let(:prg_code) { 'PRG123' }
+ let(:access_token) { 'LPUXLUZYZ9JN8XLXSSCTZA4Y5LEFEX' }
+
+ let(:coupon_code) { 'ABC123' }
+ let(:params) { coupon_code }
+
+ let(:activate_url_string) { 'https://api.spl.example.test/coupons/activate' }
+ let(:activate_uri) { URI.parse(activate_url_string) }
+
+ let(:success_body_raw) do
+ {
+ 'errorCode' => '0',
+ 'validationMessages' => nil,
+ 'fieldValidationMessages' => nil,
+ 'response' => { 'returned' => nil },
+ 'msg' => 'OK'
+ }.to_json
+ end
+
+ let(:response) { instance_double('Net::HTTPResponse', body: success_body_raw) }
+
+ before do
+ allow(store).to receive(:private_metadata).and_return(
+ 'spl_url' => spl_url,
+ 'spl_prg_code' => prg_code
+ )
+ allow(user).to receive(:private_metadata).and_return(
+ 'spl_access_token' => access_token
+ )
+
+ url_creator = instance_double('Spl::UrlCreatorService', coupon_activate: activate_url_string)
+ allow(Spl::UrlCreatorService).to receive(:new).with(spl_url).and_return(url_creator)
+
+ allow(service).to receive(:send_request).and_return(response)
+ end
+
+ describe '#call' do
+ context "success (errorCode == '0')" do
+ it "sends request to coupon_activate URI with expected body and returns parsed 'response' hash" do
+ expected_body = {
+ context: {
+ prgCode: prg_code,
+ oauthToken: access_token
+ },
+ couponCode: coupon_code
+ }
+
+ expect(service).to receive(:send_request).with(activate_uri, expected_body).and_return(response)
+
+ expect(service.call).to eq({ 'returned' => nil })
+ end
+
+ it "succeeds even if validation messages are present (still errorCode '0')" do
+ body = {
+ 'errorCode' => '0',
+ 'validationMessages' => ['some warning'],
+ 'fieldValidationMessages' => { 'couponCode' => ['format warning'] },
+ 'response' => { 'returned' => nil },
+ 'msg' => 'OK'
+ }.to_json
+
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect(service.call).to eq({ 'returned' => nil })
+ end
+
+ it "returns nil if 'response' key is missing" do
+ body = { 'errorCode' => '0', 'msg' => 'OK' }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect(service.call).to be_nil
+ end
+
+ it "returns nil if 'response' is null" do
+ body = { 'errorCode' => '0', 'response' => nil, 'msg' => 'OK' }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect(service.call).to be_nil
+ end
+ end
+
+ context "API failure (errorCode != '0')" do
+ it 'raises ActivateCouponServiceError with msg' do
+ body = { 'errorCode' => 'COUPON_CANNOT_BE_MODIFIED', 'msg' => 'Coupon invalid', 'response' => nil }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect { service.call }
+ .to raise_error(described_class::ActivateCouponServiceError, 'Coupon invalid')
+ end
+
+ it 'raises even if msg is missing' do
+ body = { 'errorCode' => 'COUPON_CANNOT_BE_MODIFIED' }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect { service.call }.to raise_error(described_class::ActivateCouponServiceError)
+ end
+ end
+
+ context 'bad/empty HTTP response' do
+ it 'raises JSON::ParserError for invalid JSON' do
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: 'not-json'))
+ expect { service.call }.to raise_error(JSON::ParserError)
+ end
+
+ it 'raises TypeError when response.body is nil (JSON.parse(nil))' do
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: nil))
+ expect { service.call }.to raise_error(TypeError)
+ end
+
+ it 'raises NoMethodError when send_request returns nil (nil.body)' do
+ allow(service).to receive(:send_request).and_return(nil)
+ expect { service.call }.to raise_error(NoMethodError)
+ end
+
+ it 'bubbles exceptions from send_request (e.g., timeouts)' do
+ allow(service).to receive(:send_request).and_raise(Timeout::Error)
+ expect { service.call }.to raise_error(Timeout::Error)
+ end
+ end
+ end
+end
diff --git a/spec/services/spl/coupons/deactivate_coupon_service_spec.rb b/spec/services/spl/coupons/deactivate_coupon_service_spec.rb
new file mode 100644
index 0000000..f9f0cd9
--- /dev/null
+++ b/spec/services/spl/coupons/deactivate_coupon_service_spec.rb
@@ -0,0 +1,132 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Spl::Coupons::DeactivateCouponService do
+ subject(:service) { described_class.new(user, store, params) }
+
+ let(:user) { create(:user) }
+ let(:store) { Spree::Store.default }
+
+ let(:spl_url) { 'https://spl.example.test' }
+ let(:prg_code) { 'prg2' }
+ let(:access_token) { 'LPUXLUZYZ9JN8XLXSSCTZA4Y5LEFEX' }
+
+ let(:coupon_code) { 'COUPON' }
+ let(:params) { coupon_code }
+
+ let(:deactivate_url_string) { 'https://api.spl.example.test/coupons/deactivate' }
+ let(:deactivate_uri) { URI.parse(deactivate_url_string) }
+
+ let(:success_body_raw) do
+ {
+ 'errorCode' => '0',
+ 'validationMessages' => nil,
+ 'fieldValidationMessages' => nil,
+ 'response' => { 'returned' => nil },
+ 'msg' => 'OK'
+ }.to_json
+ end
+
+ let(:response) { instance_double('Net::HTTPResponse', body: success_body_raw) }
+
+ before do
+ allow(store).to receive(:private_metadata).and_return(
+ 'spl_url' => spl_url,
+ 'spl_prg_code' => prg_code
+ )
+ allow(user).to receive(:private_metadata).and_return(
+ 'spl_access_token' => access_token
+ )
+
+ url_creator = instance_double('Spl::UrlCreatorService', coupon_deactivate: deactivate_url_string)
+ allow(Spl::UrlCreatorService).to receive(:new).with(spl_url).and_return(url_creator)
+
+ allow(service).to receive(:send_request).and_return(response)
+ end
+
+ describe '#call' do
+ context "success (errorCode == '0')" do
+ it "sends request to coupon_deactivate URI with expected body and returns parsed 'response' hash" do
+ expected_body = {
+ context: {
+ prgCode: prg_code,
+ oauthToken: access_token
+ },
+ couponCode: coupon_code
+ }
+
+ expect(service).to receive(:send_request).with(deactivate_uri, expected_body).and_return(response)
+
+ expect(service.call).to eq({ 'returned' => nil })
+ end
+
+ it "succeeds even if validation messages are present (still errorCode '0')" do
+ body = {
+ 'errorCode' => '0',
+ 'validationMessages' => ['some warning'],
+ 'fieldValidationMessages' => { 'couponCode' => ['format warning'] },
+ 'response' => { 'returned' => nil },
+ 'msg' => 'OK'
+ }.to_json
+
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect(service.call).to eq({ 'returned' => nil })
+ end
+
+ it "returns nil if 'response' key is missing" do
+ body = { 'errorCode' => '0', 'msg' => 'OK' }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect(service.call).to be_nil
+ end
+
+ it "returns nil if 'response' is null" do
+ body = { 'errorCode' => '0', 'response' => nil, 'msg' => 'OK' }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect(service.call).to be_nil
+ end
+ end
+
+ context "API failure (errorCode != '0')" do
+ it 'raises DeactivateCouponServiceError with msg' do
+ body = { 'errorCode' => 'COUPON_CANNOT_BE_MODIFIED', 'msg' => 'Coupon invalid', 'response' => nil }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect { service.call }
+ .to raise_error(described_class::DeactivateCouponServiceError, 'Coupon invalid')
+ end
+
+ it 'raises even if msg is missing' do
+ body = { 'errorCode' => 'COUPON_CANNOT_BE_MODIFIED' }.to_json
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: body))
+
+ expect { service.call }.to raise_error(described_class::DeactivateCouponServiceError)
+ end
+ end
+
+ context 'bad/empty HTTP response' do
+ it 'raises JSON::ParserError for invalid JSON' do
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: 'not-json'))
+ expect { service.call }.to raise_error(JSON::ParserError)
+ end
+
+ it 'raises TypeError when response.body is nil (JSON.parse(nil))' do
+ allow(service).to receive(:send_request).and_return(instance_double('Net::HTTPResponse', body: nil))
+ expect { service.call }.to raise_error(TypeError)
+ end
+
+ it 'raises NoMethodError when send_request returns nil (nil.body)' do
+ allow(service).to receive(:send_request).and_return(nil)
+ expect { service.call }.to raise_error(NoMethodError)
+ end
+
+ it 'bubbles exceptions from send_request (e.g., timeouts)' do
+ allow(service).to receive(:send_request).and_raise(Timeout::Error)
+ expect { service.call }.to raise_error(Timeout::Error)
+ end
+ end
+ end
+end
diff --git a/spec/services/spl/get_coupon_service_spec.rb b/spec/services/spl/coupons/get_coupon_service_spec.rb
similarity index 94%
rename from spec/services/spl/get_coupon_service_spec.rb
rename to spec/services/spl/coupons/get_coupon_service_spec.rb
index e2eb49c..868f5e6 100644
--- a/spec/services/spl/get_coupon_service_spec.rb
+++ b/spec/services/spl/coupons/get_coupon_service_spec.rb
@@ -2,7 +2,7 @@
require 'rails_helper'
-RSpec.describe Spl::GetCouponsService do
+RSpec.describe Spl::Coupons::GetCouponsService do
let(:user) { create(:user, private_metadata: { 'spl_access_token' => 'LPUXLUZYZ9JN8XLXSSCTZA4Y5LEFEX' }) }
let(:store) { Spree::Store.default }
let(:service) { described_class.new(user, store) }
@@ -14,7 +14,8 @@
context: {
prgCode: 'prg-2',
oauthToken: 'LPUXLUZYZ9JN8XLXSSCTZA4Y5LEFEX' # real exammple token
- }
+ },
+ withArchival: true
}
end
let(:request_service) { instance_double(Spl::SendRequestService) }
@@ -38,7 +39,7 @@
'response' => [
{
'code' => '9004850879237',
- 'expirationDate' => '2026-01-01T23:59:59.999+01:00',
+ 'expirationDate' => nil,
'valid' => true,
'type' => '90_CRAZY',
'typeId' => '67583a525012cbcf734c281a',
@@ -108,11 +109,12 @@
before do
allow(response_double).to receive(:body).and_return(error_response_body.to_json)
+ service.instance_variable_set(:@retry_counter, 0)
end
it 'raises SplGetCouponError with message' do
expect { service.call }.to raise_error(
- Spl::GetCouponsService::SplGetCouponError,
+ Spl::Coupons::GetCouponsService::SplGetCouponError,
'Token expired'
)
end
diff --git a/spree-spl.gemspec b/spree-spl.gemspec
index f90aa7b..fdcdc65 100644
--- a/spree-spl.gemspec
+++ b/spree-spl.gemspec
@@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
spec.add_dependency('faraday')
spec.add_dependency('openssl')
- spree_version = ['~> 5.1', '>= 5.1.4']
+ spree_version = ['~> 5.2', '>= 5.2.4']
spec.add_dependency 'bigdecimal'
spec.add_dependency 'rails', '>= 7.0', '< 8.3'
spec.add_dependency 'spree', spree_version