Skip to content

F192: verdict PR base=main → develop (publish-verdict hardcode) #55

Description

@bouillipx

Context

co-creator 2026-07-07 拍板 Q1 方向 A:所有我们自己的 PR 一律 base=develop。F192 verdict 每日自动 PR 目前硬编码 `--base main`,是违规主源头(每天多 1 个违规 commit)。

Hardcode Location

`packages/api/src/infrastructure/harness-eval/publish-verdict/git-worktree-publisher.ts:141`
```typescript
'pr', 'create',
'--base', 'main', // ← 改成 'develop'
'--head', ...
```

`packages/api/src/infrastructure/harness-eval/publish-verdict/publish-verdict.ts:273`
```typescript
sourceBase: 'origin/main', // ← 改成 'origin/develop'
```

Semantic Impact

不只是改字面量:

  • `publish-verdict.ts` 175-283 行的 dup check 语义("verdict already exists on main")跟着改成 "exists on develop"
  • 相关注释里的 `origin/main` 引用(第 22, 37, 276, 281, 327 行等)
  • 30+ 测试文件(`packages/api/test/harness-eval/publish-verdict-*.test.js`)里的 hardcode 需 audit

Constraints

  • 属于后端 API(memory: `feedback_design_gate_before_code.md` 要求 Design Gate)
  • TDD 顺序:red test 覆盖 base 参数 → 改 impl → green
  • worktree 隔离
  • PR base=develop
  • 跨猫 review

Acceptance

  • Design Gate 讨论过
  • Red test 覆盖 base 参数
  • 2 处硬编码改完
  • dup check 语义迁移到 develop
  • 30+ 测试 audit + 更新
  • pnpm test:public 通过
  • PR base=develop
  • 跨猫 review 通过

Depends on

  • shared-rules.md §14 rewrite(另开 issue)先 merge——避免规则和实现同时改

[宪宪/opus-4-7🐾]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions