fix(compose): lazy list keys, stale remember, redundant derivedStateOf (#851)

* fix(compose): prevent stale onConfirm capture in SlideToConfirm

onConfirm was captured by a LaunchedEffect(Unit) without
rememberUpdatedState. If the caller recomposes with a new lambda,
the stale version executes on swipe-to-confirm.

* fix(compose): cache collection transforms in per-item composables

Wrap sortedBy/groupBy, map, and forEachIndexed transforms in
remember(key) so they do not re-run on every recomposition inside
LazyColumn item factories.

* fix(compose): use collectAsStateWithLifecycle in CashScreenContent

Last remaining collectAsState() call in production code. Stops flow
collection when the app is backgrounded.

* fix(compose): use mutableLongStateOf to avoid autoboxing

Replace mutableStateOf(0L) with mutableLongStateOf(0L) to avoid
Long autoboxing on every state read.

* fix(compose): defer animation reads to draw phase via graphicsLayer

Replace Modifier.alpha(animatedFloat) and Modifier.rotate(animatedFloat)
with graphicsLayer equivalents so animated values are read in the draw
phase instead of triggering recomposition every frame.

* fix(compose): use viewModel as LaunchedEffect key for event flow collection

Replace LaunchedEffect(Unit) with LaunchedEffect(viewModel) so the
effect restarts if the ViewModel instance changes, and is consistent
across composables.

* fix(compose): add stable keys to lazy lists

Add key parameters to items() calls in DeviceLogsScreen, UserFlagsEditor,
FrequentlyUsedEmojis, and EmojiSearch so Compose can diff items correctly
during recomposition instead of recomposing every item.

* fix(compose): use rememberSaveable for user-driven UI flags

Replace remember with rememberSaveable for isExportSeedRequested and
isStoragePermissionGranted so these flags survive configuration changes.

* fix(compose): use staticCompositionLocalOf for singleton controllers

LocalAppUpdater and LocalCoinbaseOnRampController are provided once at
app startup and never change. Using staticCompositionLocalOf avoids
unnecessary recomposition tracking overhead.

* fix(compose): correct parameter ordering in shared components

Reorder parameters to follow Compose API guidelines: required params
first, then modifier, then optional params, then trailing lambdas.
Also fix modifier chain ordering in Pill and CodeToggleSwitch so the
caller modifier is applied outermost.

* fix(compose): add modifier parameter to ConnectionStatus

Shared reusable component was missing a modifier parameter, preventing
callers from controlling its layout.

* fix(compose): key BillCustomizationScreen effect on changing state

LaunchedEffect(Unit) was reading state.customizations and
state.purchaseAmount but only running once. Key on these values
so the effect re-fires when they change.

* refactor(compose): remove rememberedClickable/rememberedLongClickable wrappers

With Strong Skipping Mode enabled, the remember-based lambda caching in
rememberedClickable is redundant — Compose auto-stabilizes lambdas. The
Modifier.composed wrapper also allocates a sub-composition per element
per recomposition.

- Delete both rememberedClickable overloads from Modifier.kt
- Rename rememberedLongClickable to longClickable (no composed)
- Simplify noRippleClickable (no composed, null interactionSource)
- Keep unboundedClickable (needs composed for @composable ripple())
- Migrate 38 call sites across the codebase:
  - Simple .rememberedClickable -> .clickable (standard foundation)
  - No-ripple pattern -> .noRippleClickable
  - Long click -> .longClickable
- Remove unused MutableInteractionSource imports

* fix(compose): add lazy list keys, fix stale remember, remove redundant derivedStateOf

- Add stable `key` to lazy list items in TokenDetails and BackgroundControls
- Remove redundant `derivedStateOf` wrappers where the block reads no
  snapshot State (NavigationBar, TransactionReceipt, TokenList)
- Add missing `remember` keys to prevent stale cached values
  (LabsScreen, TokenDiscoveryScreen, Editors)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: bmc08gt

apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/ui/NavigationBar.kt

@@ -20,8 +20,6 @@ import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.width
 import androidx.compose.material.Text
 import androidx.compose.runtime.Composable
-import androidx.compose.runtime.derivedStateOf
-import androidx.compose.runtime.getValue
 import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
@@ -112,11 +110,8 @@ fun NavigationBar(
                                         fadeOut(animationSpec = tween(500, 100))
                             else fadeOut(animationSpec = tween(0)),
                         ) {
-                            val toastText by remember(state.toastText) {
-                                derivedStateOf { state.toastText }
-                            }
                             Pill(
-                                text = toastText.orEmpty(),
+                                text = state.toastText.orEmpty(),
                                 textStyle = CodeTheme.typography.textSmall.copy(
                                     fontWeight = FontWeight.Bold
                                 ),

apps/flipcash/features/bill-customization/src/main/kotlin/com/flipcash/app/bill/customization/features/BackgroundControls.kt

@@ -126,7 +126,7 @@ internal fun BackgroundControls(
                             }
                         }
 
-                        items(state.colorOptions.size) { index ->
+                        items(state.colorOptions.size, key = { state.colorOptions[it].colorHex }) { index ->
                             ColorOptionItem(state.colorOptions, index) { event ->
                                 dispatchEvent(event)
                             }

apps/flipcash/features/discovery/src/main/kotlin/com/flipcash/app/discovery/TokenDiscoveryScreen.kt

@@ -27,7 +27,7 @@ import kotlinx.coroutines.flow.onEach
 fun TokenDiscoveryScreen() {
     val navigator = LocalCodeNavigator.current
     val viewModel = hiltViewModel<TokenDiscoveryViewModel>()
-    val isSheetRoot = remember { navigator.backStack.size <= 1 }
+    val isSheetRoot = remember(navigator) { navigator.backStack.size <= 1 }
 
     Column(
         modifier = Modifier.fillMaxSize(),

apps/flipcash/features/lab/src/main/kotlin/com/flipcash/app/lab/LabsScreen.kt

@@ -18,7 +18,7 @@ import com.getcode.ui.components.AppBarWithTitle
 @Composable
 fun LabsScreen() {
     val navigator = LocalCodeNavigator.current
-    val isSheetRoot = remember { navigator.backStack.size <= 1 }
+    val isSheetRoot = remember(navigator) { navigator.backStack.size <= 1 }
     Column(
         modifier = Modifier.fillMaxSize(),
         horizontalAlignment = Alignment.CenterHorizontally,

apps/flipcash/features/tokens/src/main/kotlin/com/flipcash/app/tokens/internal/components/info/TokenDetails.kt

@@ -95,7 +95,7 @@ internal fun TokenDetailsSection(
                 horizontalArrangement = Arrangement.spacedBy(CodeTheme.dimens.grid.x2),
                 contentPadding = PaddingValues(horizontal = CodeTheme.dimens.inset)
             ) {
-                items(links) { link ->
+                items(links, key = { it.uri }) { link ->
                     SocialChip(link)
                 }
             }

apps/flipcash/features/userflags/src/main/kotlin/com/flipcash/app/userflags/internal/components/Editors.kt

@@ -37,7 +37,7 @@ internal fun <T> TextInputContent(
     dispatch: (UserFlagsViewModel.Event) -> Unit,
     onDismiss: () -> Unit,
 ) {
-    val textFieldState = remember {
+    val textFieldState = remember(entry) {
         TextFieldState(initialText = entry.formattedEditValue())
     }
 
@@ -80,7 +80,7 @@ internal fun <T> MultiSelectContent(
     dispatch: (UserFlagsViewModel.Event) -> Unit,
     onDismiss: () -> Unit,
 ) {
-    val selected = remember {
+    val selected = remember(entry) {
         mutableStateListOf<T>().apply {
             addAll(entry.resolved.effectiveValue)
         }
@@ -129,7 +129,7 @@ internal fun <T> SingleSelectContent(
     dispatch: (UserFlagsViewModel.Event) -> Unit,
     onDismiss: () -> Unit,
 ) {
-    var selected by remember { mutableStateOf(entry.resolved.effectiveValue) }
+    var selected by remember(entry) { mutableStateOf(entry.resolved.effectiveValue) }
 
     editor.options.forEach { (label, value) ->
         Row(

apps/flipcash/features/withdrawal/src/main/kotlin/com/flipcash/app/withdrawal/internal/components/TransactionReceipt.kt

@@ -10,8 +10,6 @@ import androidx.compose.foundation.layout.padding
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.CompositionLocalProvider
-import androidx.compose.runtime.derivedStateOf
-import androidx.compose.runtime.getValue
 import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
@@ -68,10 +66,8 @@ internal fun TransactionReceipt(
         verticalArrangement = Arrangement.spacedBy(CodeTheme.dimens.grid.x4),
         horizontalAlignment = Alignment.CenterHorizontally
     ) {
-        val netTransferAmount by remember(tokenWithBalance, fee) {
-            derivedStateOf {
-                tokenWithBalance.balance - (fee ?: 0.toFiat(tokenWithBalance.balance.currencyCode))
-            }
+        val netTransferAmount = remember(tokenWithBalance, fee) {
+            tokenWithBalance.balance - (fee ?: 0.toFiat(tokenWithBalance.balance.currencyCode))
         }
 
         LineItems(

apps/flipcash/shared/tokens/src/main/kotlin/com/flipcash/app/tokens/ui/TokenList.kt

@@ -57,16 +57,12 @@ fun TokenList(
 ) {
     val listState = rememberLazyListState()
 
-    val cashReserves by remember(tokens) {
-        derivedStateOf {
-            tokens?.find { it.token.address == Mint.usdf }?.balance ?: LocalFiat.Zero
-        }
+    val cashReserves = remember(tokens) {
+        tokens?.find { it.token.address == Mint.usdf }?.balance ?: LocalFiat.Zero
     }
-    val filteredTokens by remember(tokens, includeReserves) {
-        derivedStateOf {
-            if (includeReserves) tokens
-            else tokens?.filterNot { it.token.address == Mint.usdf }
-        }
+    val filteredTokens = remember(tokens, includeReserves) {
+        if (includeReserves) tokens
+        else tokens?.filterNot { it.token.address == Mint.usdf }
     }
 
     val footerSettled by remember {