Skip to content

Commit 1c909c6

Browse files
authored
Merge pull request #377 from code-payments/chore/add-read-phone-state-android-8
fix: add READ_PHONE_STATE for Api24NetworkObserver
2 parents 95be6c0 + 2a96eec commit 1c909c6

2 files changed

Lines changed: 4 additions & 23 deletions

File tree

api/src/main/java/com/getcode/utils/network/NetworkConnectionListener.kt

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,8 @@
11
package com.getcode.utils.network
22

3-
import android.net.ConnectivityManager
4-
import android.net.Network
5-
import android.net.NetworkCapabilities
6-
import android.net.NetworkRequest
7-
import android.net.wifi.WifiManager
8-
import android.os.Build
9-
import android.telephony.PhoneStateListener
10-
import android.telephony.TelephonyManager
11-
import androidx.annotation.RequiresApi
12-
import kotlinx.coroutines.CoroutineScope
13-
import kotlinx.coroutines.Dispatchers
14-
import kotlinx.coroutines.FlowPreview
15-
import kotlinx.coroutines.channels.awaitClose
16-
import kotlinx.coroutines.flow.Flow
173
import kotlinx.coroutines.flow.MutableStateFlow
18-
import kotlinx.coroutines.flow.SharingStarted
194
import kotlinx.coroutines.flow.StateFlow
205
import kotlinx.coroutines.flow.asStateFlow
21-
import kotlinx.coroutines.flow.callbackFlow
22-
import kotlinx.coroutines.flow.combine
23-
import kotlinx.coroutines.flow.debounce
24-
import kotlinx.coroutines.flow.distinctUntilChanged
25-
import kotlinx.coroutines.flow.onStart
26-
import kotlinx.coroutines.flow.shareIn
27-
import kotlinx.coroutines.flow.stateIn
28-
import javax.inject.Inject
296

307
interface NetworkConnectivityListener {
318
val state: StateFlow<NetworkState>

app/src/main/AndroidManifest.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
2222

2323
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
24+
<!-- needed for network connectivity detection in Api24NetworkObserver -->
25+
<uses-permission android:name="android.permission.READ_PHONE_STATE"
26+
android:maxSdkVersion="28"
27+
/>
2428

2529
<queries>
2630
<intent>

0 commit comments

Comments
 (0)