refactor(region-selection): rename module and simplify VM list generation (#839)

Rename currency-selection module to region-selection. Consolidate
CurrencyViewModel to generate list items directly from source flows
in a single combine, eliminating two-phase rendering that caused
scroll position issues with keyed LazyColumn items. Remove local
list splitting/mutation from RegionList composable.

Signed-off-by: Brandon McAnsh <git@bmcreations.dev>

Author: bmc08gt

apps/flipcash/app/build.gradle.kts

@@ -148,8 +148,8 @@ dependencies {
     implementation(project(":apps:flipcash:shared:router"))
     implementation(project(":apps:flipcash:shared:session"))
     implementation(project(":apps:flipcash:shared:google-play-billing"))
-    implementation(project(":apps:flipcash:shared:currency-selection:core"))
-    implementation(project(":apps:flipcash:shared:currency-selection:ui"))
+    implementation(project(":apps:flipcash:shared:region-selection:core"))
+    implementation(project(":apps:flipcash:shared:region-selection:ui"))
     implementation(project(":apps:flipcash:shared:contacts"))
     implementation(project(":apps:flipcash:shared:notifications"))
     implementation(project(":apps:flipcash:shared:onramp:coinbase"))

apps/flipcash/shared/currency-selection/ui/src/main/kotlin/com/flipcash/app/currency/internal/components/RegionList.kt

@@ -13,6 +13,6 @@ dependencies {
     api(libs.google.play.billing.ktx)
 
     implementation(project(":apps:flipcash:shared:analytics"))
-    implementation(project(":apps:flipcash:shared:currency-selection:core"))
+    implementation(project(":apps:flipcash:shared:region-selection:core"))
     implementation(project(":libs:datetime"))
 }

apps/flipcash/shared/google-play-billing/build.gradle.kts

@@ -9,6 +9,6 @@ android {
 dependencies {
     implementation(libs.androidx.datastore)
 
-    implementation(project(":apps:flipcash:shared:currency-selection:core"))
+    implementation(project(":apps:flipcash:shared:region-selection:core"))
     implementation(project(":libs:datetime"))
 }

…hared/currency-selection/core/.gitignore …/shared/region-selection/core/.gitignoreapps/flipcash/shared/currency-selection/core/.gitignore renamed to apps/flipcash/shared/region-selection/core/.gitignore apps/flipcash/shared/currency-selection/core/.gitignore renamed to apps/flipcash/shared/region-selection/core/.gitignore

@@ -7,8 +7,8 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.stringResource
 import androidx.hilt.navigation.compose.hiltViewModel
-import com.flipcash.app.currency.internal.CurrencyViewModel
-import com.flipcash.app.currency.internal.RegionSelectionModalContent
+import com.flipcash.app.currency.internal.RegionSelectionViewModel
+import com.flipcash.app.currency.internal.RegionSelectionScreen
 import com.flipcash.core.R
 import com.getcode.navigation.core.LocalCodeNavigator
 import com.getcode.ui.components.AppBarWithTitle
@@ -30,7 +30,7 @@ fun RegionSelectionScreen() {
             }
         )
 
-        val viewModel = hiltViewModel<CurrencyViewModel>()
-        RegionSelectionModalContent(viewModel)
+        val viewModel = hiltViewModel<RegionSelectionViewModel>()
+        RegionSelectionScreen(viewModel)
     }
 }

…currency-selection/core/build.gradle.kts …d/region-selection/core/build.gradle.ktsapps/flipcash/shared/currency-selection/core/build.gradle.kts renamed to apps/flipcash/shared/region-selection/core/build.gradle.kts apps/flipcash/shared/currency-selection/core/build.gradle.kts renamed to apps/flipcash/shared/region-selection/core/build.gradle.kts

@@ -2,7 +2,7 @@ package com.flipcash.app.currency.internal
 
 import com.getcode.opencode.model.financial.Currency
 
-sealed interface CurrencyListItem {
-    data class TitleItem(val text: String) : CurrencyListItem
-    data class RegionCurrencyItem(val currency: Currency, val isRecent: Boolean) : CurrencyListItem
+sealed interface RegionListItem {
+    data class TitleItem(val text: String) : RegionListItem
+    data class RegionCurrencyItem(val currency: Currency, val isRecent: Boolean) : RegionListItem
 }