Skip to content

Commit a6b696b

Browse files
committed
feat(ui/navigation): rebuild modal bottom sheet scene strategy to better support IME transitions
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
1 parent e5b378b commit a6b696b

53 files changed

Lines changed: 172 additions & 240 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/internal/ui/previews/AppBarTitlePreviews.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ private fun AppBarTitleOnGivePreview() {
1414
FlipcashPreview(showBackground = true) {
1515

1616
AppBarWithTitle(
17-
isInModal = true,
1817
leftIcon = { AppBarDefaults.UpNavigation() { }},
1918
title = {
2019
TokenSelectionPill(

apps/flipcash/features/advanced/src/main/kotlin/com/flipcash/app/advanced/AdvancedFeaturesScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ fun AdvancedFeaturesScreen() {
3434
AppBarWithTitle(
3535
title = stringResource(R.string.title_advancedFeatures),
3636
titleAlignment = Alignment.CenterHorizontally,
37-
isInModal = true,
3837
backButton = true,
3938
onBackIconClicked = { navigator.pop() }
4039
)

apps/flipcash/features/appsettings/src/main/kotlin/com/flipcash/app/appsettings/AppSettingsScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ fun AppSettingsScreen() {
2323
title = stringResource(R.string.title_appSettings),
2424
titleAlignment = Alignment.CenterHorizontally,
2525
backButton = true,
26-
isInModal = true,
2726
onBackIconClicked = navigator::pop
2827
)
2928

apps/flipcash/features/backupkey/src/main/kotlin/com/flipcash/app/backupkey/BackupKeyScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ fun BackupKeyScreen() {
2424
) {
2525
AppBarWithTitle(
2626
title = stringResource(R.string.title_accessKey),
27-
isInModal = true,
2827
titleAlignment = Alignment.CenterHorizontally,
2928
backButton = true,
3029
onBackIconClicked = { navigator.pop() },

apps/flipcash/features/balance/src/main/kotlin/com/flipcash/app/balance/BalanceScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ fun BalanceScreen() {
3131
) {
3232
AppBarWithTitle(
3333
title = stringResource(R.string.title_wallet),
34-
isInModal = true,
3534
titleAlignment = Alignment.CenterHorizontally,
3635
endContent = {
3736
AppBarDefaults.Close { navigator.hide() }

apps/flipcash/features/cash/src/main/kotlin/com/flipcash/app/cash/CashScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ fun CashScreen(
5050
horizontalAlignment = Alignment.CenterHorizontally,
5151
) {
5252
AppBarWithTitle(
53-
isInModal = true,
5453
title = {
5554
TokenSelectionPill(state.token?.token) {
5655
navigator.push(

apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/VerificationFlowScreen.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,16 @@ private fun verificationEntryProvider(
6363
VerificationFlowIntroContent(isForOnRamp = step.isForOnRamp)
6464
}
6565
annotatedEntry<VerificationStep.PhoneEntry> {
66-
PhoneVerificationContent(isInModal = !route.fullScreen)
66+
PhoneVerificationContent()
6767
}
6868
annotatedEntry<VerificationStep.PhoneCode> {
6969
PhoneCodeContent(
7070
includeEmail = route.includeEmail,
71-
isInModal = !route.fullScreen,
7271
linkForPayment = route.linkForPayment,
7372
)
7473
}
7574
annotatedEntry<VerificationStep.PhoneCountryCode> {
76-
PhoneCountryCodeContent(isInModal = !route.fullScreen)
75+
PhoneCountryCodeContent()
7776
}
7877
annotatedEntry<VerificationStep.EmailEntry> {
7978
EmailVerificationContent(

apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/email/EmailMagicLinkScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ fun EmailMagicLinkContent(
4848
) {
4949
AppBarWithTitle(
5050
title = stringResource(R.string.title_connectEmailAddress),
51-
isInModal = true,
5251
titleAlignment = Alignment.CenterHorizontally,
5352
backButton = true,
5453
onBackIconClicked = { flowNavigator.back() },

apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/email/EmailVerificationScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ fun EmailVerificationContent(
4444
) {
4545
AppBarWithTitle(
4646
title = stringResource(R.string.title_connectEmailAddress),
47-
isInModal = true,
4847
titleAlignment = Alignment.CenterHorizontally,
4948
backButton = true,
5049
onBackIconClicked = {

apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/internal/VerificationFlowIntroScreen.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,12 @@ private fun VerificationFlowIntroScreenContent(
7070
topBar = {
7171
if (isSheetRoot) {
7272
AppBarWithTitle(
73-
isInModal = true,
7473
endContent = {
7574
AppBarDefaults.Close { navigator.hide() }
7675
},
7776
)
7877
} else {
7978
AppBarWithTitle(
80-
isInModal = true,
8179
backButton = true,
8280
onBackIconClicked = { navigator.pop() },
8381
)

0 commit comments

Comments
 (0)