User agent version parsing supports optional minor

Author: jeffyanta

pkg/grpc/client/user_agent_test.go

@@ -47,20 +47,11 @@ func TestGetUserAgent_ParseError(t *testing.T) {
 		"Code/Windows/1.2.3",
 
 		// Version components missing
-		"Code/iOS/1",
-		"Code/iOS/1.",
 		"Code/iOS/.2.3",
 		"Code/iOS/..3",
 		"Code/iOS/..",
-
-		// Non-digit values in version
-		"Code/iOS/a.2.3",
-		"Code/iOS/1.a.3",
-		"Code/iOS/2.a.3",
-
-		// Negative values in version
-		"Code/iOS/-1.2.3",
-		"Code/iOS/1.-2.3",
+		"Code/iOS/",
+		"Code/iOS",
 	} {
 		ctx := context.Background()
 		ctx, err := headers.ContextWithHeaders(ctx)

pkg/grpc/client/version.go

@@ -14,7 +14,7 @@ import (
 )
 
 const (
-	versionPattern = "\\d+.\\d+(.\\d+)?"
+	versionPattern = "\\d+(.\\d+){0,2}"
 )
 
 var (

pkg/grpc/client/version_test.go

@@ -21,12 +21,17 @@ func TestVersion_ParseHappyPath(t *testing.T) {
 	assert.Equal(t, 1, version.Major)
 	assert.Equal(t, 2, version.Minor)
 	assert.Equal(t, 0, version.Patch)
+
+	version, err = ParseVersion("1")
+	require.NoError(t, err)
+	assert.Equal(t, 1, version.Major)
+	assert.Equal(t, 0, version.Minor)
+	assert.Equal(t, 0, version.Patch)
 }
 
 func TestVersion_ParseError(t *testing.T) {
 	for _, value := range []string{
 		// Version components missing
-		"1",
 		"1.",
 		"1.2.",
 		".2.3",