Commit 8e495d9
fix: process hangs when _beforeSuite helper hook throws an error (#5515)
Add recorder.catch() for suite.before and suite.after events in helpers
listener. Unlike all other hook events (test.before, test.after, etc.),
these suite-level events had no catch handler, so rejected promises from
helper hooks like Playwright._beforeSuite() were unhandled — mocha's
done callback was never called, causing the process to hang indefinitely.
Also disable store.dryRun during check command's helper setup/teardown
verification so it actually launches the browser and can detect issues
like missing Playwright browser installations.
Co-authored-by: DavertMik <davert@testomat.io>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent f059702 commit 8e495d9
2 files changed
+4
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
138 | 139 | | |
139 | 140 | | |
140 | 141 | | |
| |||
166 | 167 | | |
167 | 168 | | |
168 | 169 | | |
| 170 | + | |
169 | 171 | | |
170 | 172 | | |
171 | 173 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
0 commit comments