Fix go depth off by one sometimes

Bench: 3554133

Author: peregrineshahin

src/search.rs

@@ -5,6 +5,7 @@ use crate::{
     movepick::{MovePicker, Stage},
     stack::Stack,
     thread::{RootMove, Status, ThreadData},
+    time::Limits,
     transposition::{Bound, TtDepth},
     types::{
         ArrayVec, Color, MAX_PLY, Move, Piece, PieceType, Score, Square, draw, is_decisive, is_loss, is_valid, is_win,
@@ -77,8 +78,13 @@ pub fn start(td: &mut ThreadData, report: Report, thread_count: usize) {
     let mut best_move_changes = 0;
     let mut soft_stop_voted = false;
 
+    let max_depth = match td.time_manager.limits() {
+        Limits::Depth(maximum) => maximum,
+        _ => MAX_PLY as i32,
+    };
+
     // Iterative Deepening
-    for depth in 1..MAX_PLY as i32 {
+    for depth in 1..=max_depth {
         best_move_changes /= 2;
 
         td.sel_depth = 0;

src/time.rs

@@ -69,8 +69,7 @@ impl TimeManager {
 
     pub fn soft_limit(&self, td: &ThreadData, multiplier: impl Fn() -> f32) -> bool {
         match self.limits {
-            Limits::Infinite => false,
-            Limits::Depth(maximum) => td.completed_depth >= maximum,
+            Limits::Infinite | Limits::Depth(_) => false,
             Limits::Nodes(maximum) => td.shared.nodes.aggregate() >= maximum,
             Limits::Time(maximum) => self.start_time.elapsed() >= Duration::from_millis(maximum),
             _ => self.start_time.elapsed() >= Duration::from_secs_f32(self.soft_bound.as_secs_f32() * multiplier()),