code review fixes

paulbalandan · paulbalandan · commit cabff1ebaf3e · 2026-04-13T18:34:05.000+08:00
diff --git a/system/Commands/Encryption/GenerateKey.php b/system/Commands/Encryption/GenerateKey.php
@@ -89,7 +89,7 @@ public function run(array $params)
             CLI::write($encodedKey, 'yellow');
             CLI::newLine();
 
-            return EXIT_ERROR;
+            return EXIT_SUCCESS;
         }
 
         if (! $this->setNewEncryptionKey($encodedKey, $params)) {
diff --git a/system/Commands/Generators/Views/command.tpl.php b/system/Commands/Generators/Views/command.tpl.php
@@ -68,9 +68,11 @@ public function run(array $params)
         $this->directory = 'Commands';
         $this->template  = 'command.tpl.php';
 
-        $this->execute($params);
+        $this->generateClass($params);
 <?php else: ?>
-        //
+        // your command logic here
 <?php endif ?>
+
+        return EXIT_SUCCESS;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public function run(array $params)`
`89`	`89`	`CLI::write($encodedKey, 'yellow');`
`90`	`90`	`CLI::newLine();`
`91`	`91`
`92`		`- return EXIT_ERROR;`
	`92`	`+ return EXIT_SUCCESS;`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`if (! $this->setNewEncryptionKey($encodedKey, $params)) {`
Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,11 @@ public function run(array $params)`
`68`	`68`	`$this->directory = 'Commands';`
`69`	`69`	`$this->template = 'command.tpl.php';`
`70`	`70`
`71`		`- $this->execute($params);`
	`71`	`+ $this->generateClass($params);`
`72`	`72`	`<?php else: ?>`
`73`		`- //`
	`73`	`+ // your command logic here`
`74`	`74`	`<?php endif ?>`
	`75`	`+`
	`76`	`+ return EXIT_SUCCESS;`
`75`	`77`	`}`
`76`	`78`	`}`