Two optional one-liners deferred from the #49 review (merged in 11272ac — thanks again @AndreLFSMartins!):
- TS — in
connections(), hoist the validateTimeout call above the try so an invalid timeout throws synchronously instead of being swallowed into the retry path.
- Python — in the matching
connections() handler, narrow the bare except to except (ApiError, TimeoutError) so unrelated errors keep propagating.
@AndreLFSMartins since the timeout/cancellation work is yours, first refusal is yours if you'd like to finish the set — happy to review quickly. Otherwise we'll pick it up in an upcoming pass. No urgency; both are behavior-preserving for valid inputs.
Two optional one-liners deferred from the #49 review (merged in
11272ac— thanks again @AndreLFSMartins!):connections(), hoist thevalidateTimeoutcall above thetryso an invalid timeout throws synchronously instead of being swallowed into the retry path.connections()handler, narrow the bareexcepttoexcept (ApiError, TimeoutError)so unrelated errors keep propagating.@AndreLFSMartins since the timeout/cancellation work is yours, first refusal is yours if you'd like to finish the set — happy to review quickly. Otherwise we'll pick it up in an upcoming pass. No urgency; both are behavior-preserving for valid inputs.