Skip to content

Commit 9ab648a

Browse files
authored
Merge pull request #13 from commitdev/default-subdomain
default subdomain values for zero-module.yml
2 parents c578079 + 93627e0 commit 9ab648a

4 files changed

Lines changed: 20 additions & 12 deletions

File tree

templates/.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ workflows:
213213
config: staging
214214
requires:
215215
- build_staging
216-
bucket: "<% index .Params `stagingFrontendHost` %>"
216+
bucket: "<% index .Params `stagingFrontendSubdomain` %><% index .Params `stagingHostRoot` %>"
217217
region: "<% index .Params `region` %>"
218218
# Depending on your development flow you may want to also only deploy to staging on master.
219219
# filters:
@@ -226,7 +226,7 @@ workflows:
226226
requires:
227227
- unit_test
228228
- build_production
229-
bucket: "<% index .Params `productionFrontendHost` %>"
229+
bucket: "<% index .Params `productionFrontendSubdomain` %><% index .Params `productionHostRoot` %>"
230230
region: "<% index .Params `region` %>"
231231
filters:
232232
branches:
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"appName": "<% .Name %>",
33
"environment": "production",
4-
"backendURL": "https://<% index .Params `productionBackendHost` %>"
4+
"backendURL": "https://<% index .Params `productionBackendSubdomain` %><% index .Params `productionHostRoot` %>"
55
}

templates/src/config/staging.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"appName": "<% .Name %>",
33
"environment": "staging",
4-
"backendURL": "https://<% index .Params `stagingBackendHost` %>"
4+
"backendURL": "https://<% index .Params `stagingBackendSubdomain` %><% index .Params `stagingHostRoot` %>"
55
}

zero-module.yml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,19 @@ parameters:
2323
- "us-west-2"
2424
- "us-east-1"
2525
- "us-east-2"
26-
- field: productionFrontendHost
27-
label: Production Frontend Host Name (e.g. app.mydomain.com)
28-
- field: productionBackendHost
29-
label: Production Backend Host Name (e.g. api.mydomain.com)
30-
- field: stagingFrontendHost
31-
label: Staging Frontend Host Name (e.g. app.mydomain-staging.com)
32-
- field: stagingBackendHost
33-
label: Staging Backend Host Name (e.g. api.mydomain-staging.com)
26+
- field: productionHostRoot
27+
label: Production Root Host Name (e.g. mydomain.com) - this must be the root of the chosen domain, not a subdomain.
28+
- field: productionFrontendSubdomain
29+
label: Production Frontend Host Name (e.g. app.)
30+
default: app.
31+
- field: productionBackendSubdomain
32+
label: Production Backend Host Name (e.g. api.)
33+
default: api.
34+
- field: stagingHostRoot
35+
label: Staging Root Host Name (e.g. mydomain-staging.com) - this must be the root of the chosen domain, not a subdomain.
36+
- field: stagingFrontendSubdomain
37+
label: Staging Frontend Host Name (e.g. app.)
38+
default: app.
39+
- field: stagingBackendSubdomain
40+
label: Staging Backend Host Name (e.g. api.)
41+
default: api.

0 commit comments

Comments
 (0)