Merge pull request #17 from commitdev/secret-region

davidcheung · web-flow · commit f9ea0e316136 · 2020-06-29T18:42:25.000-04:00
secret manager should fetch from provided region
diff --git a/Makefile b/Makefile
@@ -3,8 +3,8 @@
 # - CIRCLECI_API_KEY
 #
 
-AWS_ACCESS_KEY_ID := $(shell aws secretsmanager get-secret-value --secret-id=ci-user-aws-keys${randomSeed} | jq -r '.SecretString'| jq -r .access_key_id)
-AWS_SECRET_ACCESS_KEY := $(shell aws secretsmanager get-secret-value --secret-id=ci-user-aws-keys${randomSeed} | jq -r '.SecretString'| jq -r .secret_key)
+AWS_ACCESS_KEY_ID := $(shell aws secretsmanager get-secret-value --region ${region} --secret-id=ci-user-aws-keys${randomSeed} | jq -r '.SecretString'| jq -r .access_key_id)
+AWS_SECRET_ACCESS_KEY := $(shell aws secretsmanager get-secret-value --region ${region} --secret-id=ci-user-aws-keys${randomSeed} | jq -r '.SecretString'| jq -r .secret_key)
 GITHUB_ORG := $(shell echo ${REPOSITORY} | cut -d "/" -f 2)
 GITHUB_REPO := $(shell echo ${REPOSITORY} | cut -d "/" -f 3)
 

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,8 @@`
`3`	`3`	`# - CIRCLECI_API_KEY`
`4`	`4`	`#`
`5`	`5`
`6`		`-AWS_ACCESS_KEY_ID := $(shell aws secretsmanager get-secret-value --secret-id=ci-user-aws-keys${randomSeed} \| jq -r '.SecretString'\| jq -r .access_key_id)`
`7`		`-AWS_SECRET_ACCESS_KEY := $(shell aws secretsmanager get-secret-value --secret-id=ci-user-aws-keys${randomSeed} \| jq -r '.SecretString'\| jq -r .secret_key)`
	`6`	`+AWS_ACCESS_KEY_ID := $(shell aws secretsmanager get-secret-value --region ${region} --secret-id=ci-user-aws-keys${randomSeed} \| jq -r '.SecretString'\| jq -r .access_key_id)`
	`7`	`+AWS_SECRET_ACCESS_KEY := $(shell aws secretsmanager get-secret-value --region ${region} --secret-id=ci-user-aws-keys${randomSeed} \| jq -r '.SecretString'\| jq -r .secret_key)`
`8`	`8`	`GITHUB_ORG := $(shell echo ${REPOSITORY} \| cut -d "/" -f 2)`
`9`	`9`	`GITHUB_REPO := $(shell echo ${REPOSITORY} \| cut -d "/" -f 3)`
`10`	`10`