[BUG] x-logging tags not propagating

[DonIsiko]

Describe the bug
When defining x-logging for a service, the Properties.Tags configuration is not propagated to the CloudWatch Log Group created by ECS ComposeX.

Given the following configuration:

services:
  service-name:
    x-logging:
      RetentionInDays: 30  
      Properties:
        Tags:
          - Name: key
            Value: "some-value"

I expect the CloudWatch Log Group created for service-name to have the tag key=some-value applied in addition to any global tags set via x-tags.

In practice, the value under Properties.Tags appears to be ignored entirely and is not present on the resulting CloudWatch Log Group.

---

To Reproduce
Steps to reproduce the behavior:

1. Install ECS ComposeX (example, adjust as appropriate):

   • Installed via pip install ecs-composex

2. Execute ECS ComposeX as a CLI tool:

   ecs-composex -f docker-compose.yml deploy

3. Use a docker-compose.yml (or equivalent) with a service configured as follows:

   services:
     service-name:
       x-logging:
         RetentionInDays: 30  
         Properties:
           Tags:
             - Name: key
               Value: "some-value"

   (Plus any required x-tags / x-cluster / x-vpc etc. to allow deployment.)

4. Deploy the stack and inspect the CloudWatch Log Group created for service-name in AWS.

5. Observe that:

   • Global tags from x-tags are applied as expected.
   • The tag key=some-value from x-logging -> Properties -> Tags is not present on the Log Group.

---

Expected behavior
The CloudWatch Log Group created by ECS ComposeX for the service should have both:

• All global tags defined via x-tags, and
• Any additional tags defined under x-logging -> Properties -> Tags for that specific service.

In other words, Properties.Tags should be merged with (or added in addition to) the global tags, not ignored.

---

Logs
There are no explicit errors in ECS ComposeX output related to logging or tags. The deployment completes successfully and the log group is created, but without the tag(s) provided in x-logging -> Properties -> Tags.

---

Desktop:

• OS: Ubuntu 22.04
• Python version: 3.11
• ECS ComposeX branch: 1.1.9

[JohnPreston]

Hello @DonIsiko

I will see to implement a fix for it this weekend. Back in the early days, log groups did not support tags, I recall specifically having to skip those 🤣

[DonIsiko]

Haha, I can imagine 🤣 I'm still surprised the raw cloudformation template definitions still don't natively support global tagging themselves, only aws cloudformation update-stack supports tagging parent templates directly 😅

Thank you! Really appreciate the rapid response 😄

[JohnPreston]

Shooting myself in the foot here but I have longed wanted to have tags on log groups to also be able to have tags for sensitivity and what not.

[JohnPreston]

@DonIsiko okay, so, I had misunderstood your request - doh - and though that x-tags was not getting applied to log groups, which it is, so, that removes that.

Given you're asking for the feature, is what you have shown in your first message what you'd expect to do, i.e. set the tags at the x-logging level? Would something like

services:
  my-app:
    x-logging:
      Tags: {} | List

be a simpler way than go with Properties ? A lot of the x-<> within the service itself are shorthands to avoid going full on CFN about it. But given that now logs support so many new properties, it'd make sense to evolve those in that direction. In which case, having

x-logging:
  LogGroup:
    Properties: {}
    Lookup: {} # Because yeah, given log groups now have tags, we could have lookup and re-use existing ones, and only have log streams created?

If LogGroup is set, I expect the user to deal with Properties or Lookup , otherwise, shorthands it is

[DonIsiko]

@JohnPreston shorthand to directly add tags would be really nice, I understand the desire to avoid full CFN code in the compose-x file, but would this not be a lot more work compared to using the existing Properties field 😅?

I've tested this x-<> -> Properties -> Tags functionality with x-alarms and x-dynamo and it worked, adding tags in addition to the ones specified by x-tags, but doesn't seem to work with x-logging, which is why I thought it was a "bug"

If this was intentional, then happy to consider this a feature request 😄

[JohnPreston]

Yes, that'd be a FR not a BUG, woohoo 🤣

x-logging was an original, early days thing before I had the proper pattern for the other resources, and at the time log groups were pretty empty in features: no tagging, no confidentiality policy and so on. Now, it does.

So I'd say either shorthands or the user can define a LogGroup and either look up and existing one or set the CFN properties so they can set it up the way they'd want to..

[DonIsiko]

Closing this, as its not a Bug 🤣