From 6dc4c048f2f80d7530ce19328ce17c60ee0ef7e6 Mon Sep 17 00:00:00 2001 From: Grant Birchmeier Date: Tue, 14 Apr 2026 17:52:22 -0500 Subject: [PATCH] quiet the UTs that write useless info to console with NullLogFactories --- UnitTests/SslStreamFactoryTest.cs | 36 +++++++++++++++---- .../ThreadedSocketAcceptor_RestartTests.cs | 2 +- 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/UnitTests/SslStreamFactoryTest.cs b/UnitTests/SslStreamFactoryTest.cs index 6b89b382e..9b08f7034 100644 --- a/UnitTests/SslStreamFactoryTest.cs +++ b/UnitTests/SslStreamFactoryTest.cs @@ -105,11 +105,14 @@ public void VerifyServerLocalCertificateChainEnhancedUsage() var settings = new SocketSettings(); settings.Configure(dict); - var logger = new LogFactoryAdapter(new ScreenLogFactory(true, true, true)); + var logger = new LogFactoryAdapter(new NullLogFactory()); var factory = new SslStreamFactory(settings, logger); var resultServer = factory.VerifyRemoteCertificate(ServerCertificate, SslPolicyErrors.None, SslStreamFactory.SERVER_AUTHENTICATION_OID); var resultClient = factory.VerifyRemoteCertificate(ServerCertificate, SslPolicyErrors.None, SslStreamFactory.CLIENT_AUTHENTICATION_OID); + // Logged + // Remote certificate is not intended for client authentication: It is missing enhanced key usage 1.3.6.1.5.5.7.3.2 + // TODO: above log is probably not supposed to happen Assert.That(resultServer, Is.True); Assert.That(resultClient, Is.False); @@ -127,11 +130,16 @@ public void ServerLocalCertificateChainFailsWithoutCA() var settings = new SocketSettings(); settings.Configure(dict); - var logger = new LogFactoryAdapter(new ScreenLogFactory(true, true, true)); + var logger = new LogFactoryAdapter(new NullLogFactory()); var factory = new SslStreamFactory(settings, logger); var resultServer = factory.VerifyRemoteCertificate(ServerCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.SERVER_AUTHENTICATION_OID); + // Logged: + // CACertificatePath is not specified + // Remote certificate was not recognized as a valid certificate: RemoteCertificateChainErrors var resultClient = factory.VerifyRemoteCertificate(ServerCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.CLIENT_AUTHENTICATION_OID); + // Logged: + // Remote certificate is not intended for client authentication: It is missing enhanced key usage 1.3.6.1.5.5.7.3.2 Assert.That(resultServer, Is.False); Assert.That(resultClient, Is.False); @@ -150,11 +158,15 @@ public void ServerLocalCertificateChainFailsWithWrongCA() var settings = new SocketSettings(); settings.Configure(dict); - var logger = new LogFactoryAdapter(new ScreenLogFactory(true, true, true)); + var logger = new LogFactoryAdapter(new NullLogFactory()); var factory = new SslStreamFactory(settings, logger); var resultServer = factory.VerifyRemoteCertificate(ServerCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.SERVER_AUTHENTICATION_OID); + // Logged: + // Remote certificate was not recognized as a valid certificate: RemoteCertificateChainErrors var resultClient = factory.VerifyRemoteCertificate(ServerCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.CLIENT_AUTHENTICATION_OID); + // Logged: + // Remote certificate is not intended for client authentication: It is missing enhanced key usage 1.3.6.1.5.5.7.3.2 Assert.That(resultServer, Is.False); Assert.That(resultClient, Is.False); @@ -173,10 +185,13 @@ public void VerifyClientLocalCertificateChainEnhancedUsage() var settings = new SocketSettings(); settings.Configure(dict); - var logger = new LogFactoryAdapter(new ScreenLogFactory(true, true, true)); + var logger = new LogFactoryAdapter(new NullLogFactory()); var factory = new SslStreamFactory(settings, logger); var resultServer = factory.VerifyRemoteCertificate(ClientCertificate, SslPolicyErrors.None, SslStreamFactory.SERVER_AUTHENTICATION_OID); + // Logged + // Remote certificate is not intended for server authentication: It is missing enhanced key usage 1.3.6.1.5.5.7.3.1 + // TODO: above log is probably not supposed to happen var resultClient = factory.VerifyRemoteCertificate(ClientCertificate, SslPolicyErrors.None, SslStreamFactory.CLIENT_AUTHENTICATION_OID); Assert.That(resultServer, Is.False); @@ -195,11 +210,16 @@ public void ClientLocalCertificateChainFailsWithoutCA() var settings = new SocketSettings(); settings.Configure(dict); - var logger = new LogFactoryAdapter(new ScreenLogFactory(true, true, true)); + var logger = new LogFactoryAdapter(new NullLogFactory()); var factory = new SslStreamFactory(settings, logger); var resultServer = factory.VerifyRemoteCertificate(ClientCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.SERVER_AUTHENTICATION_OID); + // Logged: + // Remote certificate is not intended for server authentication: It is missing enhanced key usage 1.3.6.1.5.5.7.3.1 var resultClient = factory.VerifyRemoteCertificate(ClientCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.CLIENT_AUTHENTICATION_OID); + // Logged: + // CACertificatePath is not specified + // Remote certificate was not recognized as a valid certificate: RemoteCertificateChainErrors Assert.That(resultServer, Is.False); Assert.That(resultClient, Is.False); @@ -218,11 +238,15 @@ public void ClientLocalCertificateChainFailsWithWrongCA() var settings = new SocketSettings(); settings.Configure(dict); - var logger = new LogFactoryAdapter(new ScreenLogFactory(true, true, true)); + var logger = new LogFactoryAdapter(new NullLogFactory()); var factory = new SslStreamFactory(settings, logger); var resultServer = factory.VerifyRemoteCertificate(ClientCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.SERVER_AUTHENTICATION_OID); + // Logged: + // Remote certificate is not intended for server authentication: It is missing enhanced key usage 1.3.6.1.5.5.7.3.1 var resultClient = factory.VerifyRemoteCertificate(ClientCertificate, SslPolicyErrors.RemoteCertificateChainErrors, SslStreamFactory.CLIENT_AUTHENTICATION_OID); + // Logged: + // Remote certificate was not recognized as a valid certificate: RemoteCertificateChainErrors Assert.That(resultServer, Is.False); Assert.That(resultClient, Is.False); diff --git a/UnitTests/ThreadedSocketAcceptor_RestartTests.cs b/UnitTests/ThreadedSocketAcceptor_RestartTests.cs index 4e09427e9..677608d07 100644 --- a/UnitTests/ThreadedSocketAcceptor_RestartTests.cs +++ b/UnitTests/ThreadedSocketAcceptor_RestartTests.cs @@ -120,7 +120,7 @@ private void CreateAcceptorFromSessionConfig() { TestApplication application = new TestApplication(LogonCallback, LogoffCallback); IMessageStoreFactory storeFactory = new MemoryStoreFactory(); - ILogFactory logFactory = new ScreenLogFactory(false, false, false); + ILogFactory logFactory = new NullLogFactory(); SessionSettings settings = new SessionSettings(); settings.Set(CreateSessionID(StaticAcceptorCompID), CreateSessionConfig());