Skip to content

Legacy global settings not always taken into account with v0.74.0 #1705

@tmathern

Description

@tmathern

Before v.0.74.0, settings were set by thread using the load_settings API.
One of those settings is to not include thumbnails in manifests. The setting in question could be loaded using the following JSON: load_settings('{"builder": { "thumbnail": {"enabled": false}}}'). (This example code comes from the Python SDK).

With 0.74.0, the thumbnail setting is not respected anymore when set this way.

The unit test test_builder_sign_with_setting_no_thumbnail_and_ingredient (here) in the Python SDK that verified that has started to fail. When I print out the manifest, indeed with v0.74.0, I see thumbnails included when there should be none. The previous version, v0.73.2, works correctly (no thumbnail).

The failures can be observed in this test upgrade PR: contentauth/c2pa-python#215, in the workflow run. All OSes fail on the same test, with the same error. Example log for mac: https://github.com/contentauth/c2pa-python/actions/runs/20797739297/job/59735490130?pr=215

Can you confirm if this is a regression, or if settings to set change?

It would be good to have a period of backwards compatibility for settings here, to give people time to upgrade and switch to the future new settings API.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions