Refactor ContentstackException usage to streamline error handling across multiple models, enhancing clarity by directly passing error messages during instantiation.

Author: reeshika-h

Contentstack.Core.Tests/ContentTypeTest.cs

@@ -1,6 +1,7 @@
 using System;
 using Xunit;
 using Contentstack.Core.Models;
+using Contentstack.Core.Internals;
 using System.Threading.Tasks;
 using System.Collections.Generic;
 using Newtonsoft.Json.Linq;
@@ -143,7 +144,7 @@ public async Task FetchGlobalFieldSchema_NullParameters_Succeeds()
         [Fact]
         public void GlobalField_EmptyUid_Throws()
         {
-            Assert.Throws<ArgumentNullException>(() => {
+            Assert.Throws<GlobalFieldException>(() => {
                 GlobalField globalField = client.GlobalField("");
             });
         }

Contentstack.Core/ContentstackClient.cs

@@ -239,10 +239,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 errorMessage = ex.Message;
             }
 
-            contentstackError = new ContentstackException()
+            contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };
@@ -338,7 +337,7 @@ public async Task<IList> GetContentTypes(Dictionary<string, object> param = null
             }
             catch (Exception ex)
             {
-                throw new GetContentstackError(string.Format(ErrorMessages.ContentstackClientRequestError, ex.Message), ex);
+                throw GetContentstackError(ex);
             }
         }
 
@@ -873,7 +872,7 @@ private async Task<SyncStack> GetResultAsync(string Init = "false", SyncType Syn
             }
             catch (Exception ex)
             {
-                throw new GetContentstackError(string.Format(ErrorMessages.ContentstackSyncRequestError, ex.Message), ex);
+                throw GetContentstackError(ex);
             }
         }
         #endregion

Contentstack.Core/Internals/ContentStackError.cs

@@ -517,10 +517,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 }
             }
 
-            ContentstackException contentstackError = new ContentstackException()
+            ContentstackException contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };

Contentstack.Core/Models/Asset.cs

@@ -594,10 +594,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 errorMessage = ex.Message;
             }
 
-            contentstackError = new ContentstackException()
+            contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };

Contentstack.Core/Models/AssetLibrary.cs

@@ -106,10 +106,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 errorMessage = ex.Message;
             }
 
-            contentstackError = new ContentstackException()
+            contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };

Contentstack.Core/Models/ContentType.cs

@@ -214,10 +214,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 errorMessage = ex.Message;
             }
 
-            contentstackError = new ContentstackException()
+            contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };

Contentstack.Core/Models/Entry.cs

@@ -120,10 +120,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 errorMessage = ex.Message;
             }
 
-            contentstackError = new ContentstackException()
+            contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };

Contentstack.Core/Models/GlobalField.cs

@@ -90,10 +90,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 errorMessage = ex.Message;
             }
 
-            contentstackError = new ContentstackException()
+            contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };

Contentstack.Core/Models/GlobalFieldQuery.cs

@@ -117,10 +117,9 @@ internal static ContentstackException GetContentstackError(Exception ex)
                 errorMessage = ex.Message;
             }
 
-            contentstackError = new ContentstackException()
+            contentstackError = new ContentstackException(errorMessage)
             {
                 ErrorCode = errorCode,
-                ErrorMessage = errorMessage,
                 StatusCode = statusCode,
                 Errors = errors
             };