Skip to content
This repository was archived by the owner on Jun 6, 2020. It is now read-only.

Frame: Improve warnings in development mode #72

Description

@stereobooster

Consider following code

      <BarChart
        metric="sales"
        categorical="Customer.City"
        width={300}
        height={300}
        margin={magicMargin}
        data={frame}
        direction="horizontal"
      />

if for example developer made a typo and wrote "sale" instead of "sales" and typescript didn't catch that error (because DataFrame wasn't able to infer type) it will fall through down to the DataFrame internals and throw cryptic error. Instead we need to check (in development mode only), that the given column is actually present in the scheme and throw clear error if not

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions