Artifact pb with breakages

[jbcaillau]

@ocots @PierreMartinon referring to this issue control-toolbox/CTDirect.jl#348 (comment)

@amontoison did you run into the same pb with artifacts? the case being, can you please point towards a fix?

[ocots]

Here you have an example which works: control-toolbox/CTDirect.jl#345 (comment)

[jbcaillau]

thanks @ocots

Here you have an example which works: control-toolbox/CTDirect.jl#345 (comment)

@amontoison it points towards what you did to deal with this issue: any comment welcome!

@srcansiz @j-l-s guys we need some help for this artifact update 🙏🏽

See also: https://securitylab.github.com/resources/github-actions-new-patterns-and-mitigations

[amontoison]

@jbcaillau Sorry for not answering earlier.
It was a busy week...

I think we just need to update the version of a GHA to fix the issue:
amontoison/Krylov.jl#4

[srcansiz]

Hi @jbcaillau,
I'm on leave. I'll be back the week of February 24. I'll check this issue when I get back.

[jbcaillau]

Thank you @srcansiz. we can live without non-breakage tests 🥲

[jbcaillau]

@PierreMartinon @ocots @srcansiz

• should now be solved by Breakage CI action: Conflict on artifact name CTDirect.jl#345 (thanks @amontoison and @PierreMartinon 👍🏽)
• delete all commentPR.yml from all repos
• delete commentpr.yml in CTActions
• same for applications breakage

[srcansiz]

Hi @jbcaillau,

Is there anything has to be done for this issue or it is solved? Are the following actions still required?

delete all commentPR.yml from all repos
delete commentpr.yml in CTActions
same for applications breakage

[jbcaillau]

hi @srcansiz thanks for the heads up. i would answer yes for the three mentioned points. @ocots @PierreMartinon can you please confirm?

[ocots]

I have done this:

delete all commentPR.yml from all repos
delete commentpr.yml in CTActions

[ocots]

The file breakage-application.yml must be updated following what @PierreMartinon has done with breakage.yml. Actually, updating the artifact version leads to use differently the comment process. We have removed the files about commenting in a PR because now it is directly inside the breakage action:

CTActions/.github/workflows/breakage.yml

Line 97 in 79e938e

comment:

Once, the breakage application action is updated, we can test in OptimalControl.jl package. However, we need to update also the action in this repo. The current BreakageApplication.yml file is not using using the action from CTAction. This must be changed.

[ocots]

I have fixed the breakage action:

CTActions/.github/workflows/breakage.yml

Line 97 in a771f7b

name: breakage-${{ inputs.pkgname }}-${{ inputs.pkgversion }}

Here is an example:

# Ref: https://securitylab.github.com/research/github-actions-preventing-pwn-requests
name: Breakage

# read-only repo token
# no access to secrets
on:
  pull_request:

jobs:
  break:
    strategy:
      fail-fast: false
      matrix:
        pkgname: [CTDirect, CTFlows, OptimalControl]
        pkgversion: [latest, stable]
        include:
          - pkgpath: control-toolbox
    uses: control-toolbox/CTActions/.github/workflows/breakage.yml@main
    with:
      pkgname: ${{ matrix.pkgname }}
      pkgpath: ${{ matrix.pkgpath }}
      pkgversion: ${{ matrix.pkgversion }}

[ocots]

This has to be done for breakage-application.yml in CTActions and in OptimalControl.

[ocots]

Breakage for test and doc are now in the same workflow. Nothing more to do.