Skip to content

Commit ecaf72b

Browse files
committed
884: Address PR comments
1 parent 0dc828a commit ecaf72b

6 files changed

Lines changed: 25 additions & 29 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,22 @@ on: [push]
44
jobs:
55
test:
66
runs-on: ubuntu-latest
7+
strategy:
8+
matrix:
9+
ruby-version: ['3.3', '3.4', '4.0']
710
steps:
8-
- uses: actions/checkout@v2
11+
- uses: actions/checkout@v4
912
- uses: ruby/setup-ruby@v1
1013
with:
11-
ruby-version: 4.0
14+
ruby-version: ${{ matrix.ruby-version }}
1215
bundler-cache: true
13-
- run: bundle install
1416
- run: bundle exec rspec
1517
rubocop:
1618
runs-on: ubuntu-latest
1719
steps:
18-
- uses: actions/checkout@v2
20+
- uses: actions/checkout@v4
1921
- uses: ruby/setup-ruby@v1
2022
with:
21-
ruby-version: 4.0
23+
ruby-version: '4.0'
2224
bundler-cache: true
23-
- run: bundle install
2425
- run: bundle exec rubocop

.rubocop.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
AllCops:
22
NewCops: enable
3-
TargetRubyVersion: 4.0
4-
SuggestExtensions: false
53

64
plugins:
75
- rubocop-performance
@@ -16,6 +14,4 @@ Naming/AccessorMethodName:
1614
Naming/MemoizedInstanceVariableName:
1715
Enabled: false
1816
Style/Documentation:
19-
Enabled: false
20-
Style/HashAsLastArrayItem:
21-
Enabled: false
17+
Enabled: false

CHANGELOG.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@
22

33
## [1.1.0] - 2026-02-11
44

5-
### Added
6-
- Added `faraday ~> 2.0` as explicit runtime dependency
7-
- Added `faraday-mashify ~> 1.0` as explicit runtime dependency
8-
- Added `require 'faraday/mashify'` to main library file
9-
10-
### Upgrades
11-
- Upgraded from Ruby 3.2.2 to Ruby 4.0.1
12-
- Updated vertebrae dependency to >= 1.0.5
13-
- Updated bundler development dependency to >= 2.1 (from ~> 2.1)
5+
### Breaking Changes
6+
- Now requires Faraday 2.x (previously supported Faraday 1.x)
7+
- Dropped support for Ruby versions older than 3.3. Officially supported versions are Ruby 3.3, 3.4, and 4.0.

Gemfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
88
gemspec
99

1010
group :development do
11-
gem 'bundler', '>= 2.1'
12-
gem 'debug', '> 0'
11+
gem 'bundler', '>= 2.0', '< 5.0'
12+
gem 'debug', '~> 1.0'
1313
gem 'dotenv', '~> 2.7'
1414
gem 'rake', '~> 13.0'
1515
gem 'rspec', '~> 3.0'
16-
gem 'rubocop', '> 0'
17-
gem 'rubocop-performance', '> 0'
18-
gem 'webmock', '~> 3.8.3'
16+
gem 'rubocop', '~> 1.0'
17+
gem 'rubocop-performance', '~> 1.0'
18+
gem 'webmock', '~> 3.0'
1919
end

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ Ruby client for interacting with the [ActionNetwork REST API](https://actionnetw
44

55
[![CI Status](https://github.com/controlshift/action-network-rest/actions/workflows/ci.yml/badge.svg)](https://github.com/controlshift/action-network-rest/actions/workflows/ci.yml)
66

7+
## Requirements
8+
9+
- Ruby 3.3, 3.4, or 4.0
10+
- Faraday ~> 2.0
11+
712
## Installation
813

914
Add this line to your application's Gemfile:

action_network_rest.gemspec

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ require 'action_network_rest/version'
77
Gem::Specification.new do |spec|
88
spec.name = 'action_network_rest'
99
spec.version = ActionNetworkRest::VERSION
10-
spec.authors = ['Grey Moore']
11-
spec.email = ['grey@controlshiftlabs.com']
10+
spec.authors = ['Grey Moore', 'Owens Ehimen', 'Diego Marcet']
11+
spec.email = ['talk@controlshiftlabs.com']
1212

1313
spec.summary = 'Ruby client for interacting with the ActionNetwork REST API'
1414
spec.homepage = 'https://github.com/controlshift/action-network-rest'
@@ -21,11 +21,11 @@ Gem::Specification.new do |spec|
2121
end
2222
spec.require_paths = ['lib']
2323

24-
spec.required_ruby_version = '>= 4.0.0'
24+
spec.required_ruby_version = ['>= 3.3', '< 5.0']
2525

2626
spec.add_dependency 'faraday', '~> 2.0'
2727
spec.add_dependency 'faraday-mashify', '~> 1.0'
28-
spec.add_dependency 'vertebrae', '>= 1.0.5'
28+
spec.add_dependency 'vertebrae', '~> 1.0'
2929

3030
spec.metadata['rubygems_mfa_required'] = 'true'
3131
end

0 commit comments

Comments
 (0)