Skip to content

Commit 2dfbf0d

Browse files
committed
884: Address PR comments
1 parent 2803db7 commit 2dfbf0d

4 files changed

Lines changed: 28 additions & 19 deletions

File tree

.github/workflows/ci.yml

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,22 @@ on: [push]
44
jobs:
55
test:
66
runs-on: ubuntu-latest
7+
strategy:
8+
matrix:
9+
ruby-version: ['3.3', '3.4', '4.0']
710
steps:
8-
- uses: actions/checkout@v2
11+
- uses: actions/checkout@v4
912
- uses: ruby/setup-ruby@v1
1013
with:
11-
ruby-version: 3.4
14+
ruby-version: ${{ matrix.ruby-version }}
1215
bundler-cache: true
13-
- run: bundle install
1416
- run: bundle exec rspec
17+
rubocop:
18+
runs-on: ubuntu-latest
19+
steps:
20+
- uses: actions/checkout@v4
21+
- uses: ruby/setup-ruby@v1
22+
with:
23+
ruby-version: '4.0'
24+
bundler-cache: true
25+
- run: bundle exec rubocop

CHANGELOG.md

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,6 @@
22

33
## [1.11.0] - 2026-02-11
44

5-
### Added
6-
- Added `faraday ~> 2.0` as explicit runtime dependency
7-
- Added `faraday-mashify ~> 1.0` as explicit runtime dependency
8-
- Added `rake ~> 13.0` as development dependency
9-
- Added `require 'faraday/mashify'` to main library file
10-
11-
### Updates
12-
- Upgraded from Ruby 3.4.5 to Ruby 4.0.1
13-
- Updated vertebrae dependency to >= 1.0.5 for Faraday 2.x compatibility
14-
- Modernized gemspec file with proper dependency declarations
5+
### Breaking Changes
6+
- Now requires Faraday 2.x (previously supported Faraday 1.x)
7+
- Dropped support for Ruby versions older than 3.3. Officially supported versions are Ruby 3.3, 3.4, and 4.0.

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
A ruby gem for communicating with ControlShift's Tokyo API.
44

5+
## Requirements
6+
7+
- Ruby 3.3, 3.4, or 4.0
8+
- Faraday ~> 2.0
9+
510
[![CI Status](https://github.com/controlshift/tokyo_api/actions/workflows/ci.yml/badge.svg)](https://github.com/controlshift/tokyo_api/actions/workflows/ci.yml)
611

712
## Usage

tokyo_api.gemspec

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,20 @@ Gem::Specification.new do |spec|
1919
end
2020
spec.require_paths = ['lib']
2121

22-
spec.required_ruby_version = '>= 3.0.0'
22+
spec.required_ruby_version = ['>= 3.3', '< 5.0']
2323

2424
# Runtime dependencies
25-
spec.add_runtime_dependency 'vertebrae', '>= 1.0.5'
25+
spec.add_runtime_dependency 'vertebrae', '~> 1.0'
2626
spec.add_runtime_dependency 'faraday', '~> 2.0'
2727
spec.add_runtime_dependency 'faraday-mashify', '~> 1.0'
2828

2929
# Development dependencies
30-
spec.add_development_dependency 'bundler', '>= 2.0'
31-
spec.add_development_dependency 'byebug'
30+
spec.add_development_dependency 'bundler', '~> 4.0'
31+
spec.add_development_dependency 'byebug', '~> 13.0'
3232
spec.add_development_dependency 'rake', '~> 13.0'
3333
spec.add_development_dependency 'rspec', '~> 3.0'
34-
spec.add_development_dependency 'rubocop'
35-
spec.add_development_dependency 'webmock'
34+
spec.add_development_dependency 'rubocop', '~> 1.0'
35+
spec.add_development_dependency 'webmock', '~> 3.0'
3636

3737
spec.metadata['rubygems_mfa_required'] = 'true'
3838
end

0 commit comments

Comments
 (0)