Task1 problems

[costea32]

line 59 - Assert will show Assert.IsTrue Failed, no descriptive message, as this kind of assert is used a lot in your tests - you can extract it to a method, so it will be tidier, and easier to maintain

line 129 & 130, basically you want to test that all users returned have the exact same age, you don't have to check two things... only one, that all users meet the criteria

data validation should ckeck error message

[Stefan-Coroli]

Outstanding issues fixed

[costea32]

Line 106, 245, 259 - same helper method should be used
helper method to test user in list should take as parameter a User object(in this test project the user has only 3 properties, real objects could contain more, and it's a bad practice to use parameters that are actually fields of an object), and have descriptive message in case assert fails

line 122 assert has no message

[Stefan-Coroli]

Fixed. Added a different helper method for lines 106, 245, 259, since comparing user objects was required. Also fixed initial method to take a User object as a paramater, instead of taking acual fields.

[costea32]

IsUserInList usage problem - no message present for assertions using this helper method.

Mandatory fields validation tests - all tests use the same pattern to check how the system reacts to invalid data - generalize and create a helper method, to reduce code duplication

[costea32]

Task1 solution contains IUserHandlerTests, UserHandlerTests, UnitTestProject1 - hard to understand what is the actual project, and seems someone checked in to your branch, remove all unnecessary projects