From e244a1c900a5c3af285f9462c583f37370bf4817 Mon Sep 17 00:00:00 2001 From: Toddr Bot Date: Thu, 26 Mar 2026 02:38:01 +0000 Subject: [PATCH 1/2] fix: clean up Makefile.PL metadata and dead defines - Move Test::More from PREREQ_PM to TEST_REQUIRES (it's a test-only dep, not a runtime dep). Bump EUMM to 6.64 for TEST_REQUIRES support. - Remove dead -DPERL5 and -DOPENSSL_NO_KRB5 defines. Neither symbol is referenced in the source; they were workarounds for gcc-3.2 and Red Hat 9 (both circa 2003). - Update META_MERGE to CPAN META spec 2.0 format with structured repository/bugtracker entries for better MetaCPAN integration. - Remove stale build_requires (now handled by TEST_REQUIRES). Co-Authored-By: Claude Opus 4.6 --- Makefile.PL | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index ac5159f..9113e0a 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -3,7 +3,7 @@ use warnings; use Config; use 5.006; -use ExtUtils::MakeMaker 6.48; +use ExtUtils::MakeMaker 6.64; use Crypt::OpenSSL::Guess qw(openssl_inc_paths openssl_lib_paths openssl_version); my ($major, $minor, $patch) = openssl_version(); @@ -27,19 +27,20 @@ WriteMakefile( 'LICENSE' => 'perl', 'PREREQ_PM' => { 'Crypt::OpenSSL::Random' => 0, - 'Test::More' => 0, + }, + 'TEST_REQUIRES' => { + 'Test::More' => 0, }, 'OBJECT' => 'RSA.o', 'LIBS' => [openssl_lib_paths() . $libs], 'LDDLFLAGS' => openssl_lib_paths() . ' ' . $Config{lddlflags}, - 'DEFINE' => '-DPERL5 -DOPENSSL_NO_KRB5', - - # perl-5.8/gcc-3.2 needs -DPERL5, and redhat9 likes -DOPENSSL_NO_KRB5 + 'DEFINE' => '', 'INC' => openssl_inc_paths(), # e.g., '-I/usr/include/other' 'dist' => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', }, 'clean' => { FILES => 'Crypt-OpenSSL-RSA-*' }, 'META_MERGE' => { + 'meta-spec' => { version => 2 }, provides => { 'Crypt::OpenSSL::RSA' => { file => 'RSA.pm', @@ -52,14 +53,17 @@ WriteMakefile( configure_requires => { 'Crypt::OpenSSL::Guess' => '0.11', }, - build_requires => { - 'Test::More' => 0, - }, resources => { - 'license' => 'https://dev.perl.org/licenses/', + 'license' => ['https://dev.perl.org/licenses/'], 'homepage' => 'https://github.com/cpan-authors/Crypt-OpenSSL-RSA', - 'bugtracker' => 'https://github.com/cpan-authors/Crypt-OpenSSL-RSA/issues', - 'repository' => 'https://github.com/cpan-authors/Crypt-OpenSSL-RSA', + 'bugtracker' => { + 'web' => 'https://github.com/cpan-authors/Crypt-OpenSSL-RSA/issues', + }, + 'repository' => { + 'type' => 'git', + 'url' => 'https://github.com/cpan-authors/Crypt-OpenSSL-RSA.git', + 'web' => 'https://github.com/cpan-authors/Crypt-OpenSSL-RSA', + }, } } ); From b4fe82068b6a11e95e42f0b419601a3f8ac5a883 Mon Sep 17 00:00:00 2001 From: Toddr Bot Date: Fri, 3 Apr 2026 23:19:17 +0000 Subject: [PATCH 2/2] rebase: apply review feedback on #144 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Removed no-op `'DEFINE' => ''` line from `Makefile.PL` per reviewer suggestion — with both dead defines (`-DPERL5`, `-DOPENSSL_NO_KRB5`) already removed, the empty string is unnecessary and removing the key entirely is cleaner. --- Makefile.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index 9113e0a..164e2ac 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -34,7 +34,6 @@ WriteMakefile( 'OBJECT' => 'RSA.o', 'LIBS' => [openssl_lib_paths() . $libs], 'LDDLFLAGS' => openssl_lib_paths() . ' ' . $Config{lddlflags}, - 'DEFINE' => '', 'INC' => openssl_inc_paths(), # e.g., '-I/usr/include/other' 'dist' => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', },