Skip to content

Commit cc2a8f4

Browse files
committed
fix(ui): sidebar-item-time truncation for fixed 280px sidebar
Brad's review on PR #34 flagged that .sidebar-item-title already truncates with overflow: hidden + text-overflow: ellipsis + white-space: nowrap, but the .sidebar-item-time row beneath it had no overflow handling. A long model badge or localised timestamp would overflow the fixed 280px .sidebar column horizontally. Mirrored the title row's three properties on .sidebar-item-time so the truncation is symmetric. Invisible on current data (timestamps + model names fit today) — forward-looking guard against a future sidebar-child addition. §8 of tests/web-ui-qa-checklist.md updated to list both this and the .main-content overflow fix as regression notes for PR #34.
1 parent fdbb940 commit cc2a8f4

2 files changed

Lines changed: 21 additions & 3 deletions

File tree

static/css/style.css

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,10 @@ h3 { font-size: 1.15rem; font-weight: 600; }
382382
border-color: var(--badge-bg);
383383
}
384384
.sidebar-item-title { font-weight: 500; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; }
385-
.sidebar-item-time { font-size: 0.75rem; opacity: 0.7; margin-top: 0.15rem; }
385+
/* Same truncation as .sidebar-item-title — a long model badge or localised
386+
* timestamp would otherwise overflow the 280px .sidebar column horizontally
387+
* (the title row handles its own overflow; the time row should too). */
388+
.sidebar-item-time { font-size: 0.75rem; opacity: 0.7; margin-top: 0.15rem; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; }
386389

387390
/* ---------- Chat Bubbles ---------- */
388391
.chat-bubbles { display: flex; flex-direction: column; gap: 1rem; }

tests/web-ui-qa-checklist.md

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ sections in order. Attach the captured screenshots to the PR that closes
1111
issue #28; visual bugs file as follow-up issues per the acceptance
1212
criteria.
1313

14-
### Verification-method legend
14+
## Verification-method legend
1515

1616
A reviewer should be able to audit any `[x]` and tell *how* it was
1717
verified. The default is **visual** — a human confirmed it in Chrome
@@ -262,7 +262,8 @@ Phantom rows removed (filed as enhancement ideas, not bugs):
262262

263263
## 8. Regression notes — fixes shipped in this PR
264264

265-
During the QA pass, one visual bug was found and fixed in the same PR:
265+
During the QA pass, two visual overflow bugs were found and fixed in
266+
this same PR (both narrow CSS changes, no JS or template churn):
266267

267268
- **`.main-content` grid column overflowing viewport on the right.**
268269
The right-hand conversation panel (`1fr` grid column in
@@ -275,11 +276,25 @@ During the QA pass, one visual bug was found and fixed in the same PR:
275276
Existing `overflow-x: auto` on `.prose pre` and `word-break: break-all`
276277
on `.tool-call-content` then take over inside the bubble.
277278

279+
- **`.sidebar-item-time` truncation gap.** The chat-title
280+
row inside each sidebar item already truncates with
281+
`text-overflow: ellipsis; white-space: nowrap;`, but the time/model
282+
row beneath it had no overflow handling, so a long model badge or
283+
localised timestamp would overflow the fixed 280px sidebar column.
284+
Brad flagged the asymmetry during the PR review. Fix: mirror the
285+
title row's three properties on `.sidebar-item-time` at
286+
[static/css/style.css:387–390](../static/css/style.css#L387-L390).
287+
Same one-line shape as the title row; no other sidebar rules touched.
288+
278289
- [x] **(visual)** Post-fix screenshots in `samples/qa/workspace-chrome.png`,
279290
`workspace-firefox.png`, `conversation-chrome.png`,
280291
`conversation-firefox.png` were captured *after* the
281292
`.main-content { min-width: 0 }` fix landed — the conversation
282293
column stays inside the viewport in all four.
294+
- ⏳ The `.sidebar-item-time` truncation fix is invisible on current
295+
data (timestamps + model names fit today). The check is forward-
296+
looking: drop it if a future row exceeds 280px, the ellipsis
297+
should kick in instead of overflowing.
283298

284299
## 9. Sign-off
285300

0 commit comments

Comments
 (0)