Skip to content

Commit d983b9b

Browse files
committed
review: log non-schema read failures in list_composers (#30)
CodeRabbit flagged that the bare ``except Exception: pass`` adjacent to the new SchemaError path swallowed decode / SQLite / non-schema errors silently and returned a partial composer list with no signal. Replace with a print that surfaces the exception and ``db_path``, matching the ``Schema drift in ...`` line a few lines up. No behaviour change beyond observability — the loop still continues to the next workspace.
1 parent 7774f41 commit d983b9b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

api/composers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ def list_composers():
8282
composers.append(c)
8383
except SchemaError as e:
8484
print(f"Schema drift in {db_path}: {e}")
85-
except Exception:
86-
pass
85+
except Exception as e:
86+
print(f"Failed reading composers from {db_path}: {e}")
8787

8888
composers.sort(key=lambda c: to_epoch_ms(c.get("lastUpdatedAt")), reverse=True)
8989
return jsonify(composers)

0 commit comments

Comments
 (0)