valueflow.cpp: avoid unnecessary copies in valueFlowFunctionReturn()

firewave · firewave · commit 0e52420fdaa7 · 2026-05-04T09:52:33.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -5864,10 +5864,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg
         if (programMemory.empty() && !arguments.empty())
             continue;
         std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);
-        for (const ValueFlow::Value& v : values) {
+        for (ValueFlow::Value& v : values) {
             if (v.isUninitValue())
                 continue;
-            setFunctionReturnValue(function, tok, v, settings);
+            setFunctionReturnValue(function, tok, std::move(v), settings);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -5864,10 +5864,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg`
`5864`	`5864`	`if (programMemory.empty() && !arguments.empty())`
`5865`	`5865`	`continue;`
`5866`	`5866`	`std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);`
`5867`		`- for (const ValueFlow::Value& v : values) {`
	`5867`	`+ for (ValueFlow::Value& v : values) {`
`5868`	`5868`	`if (v.isUninitValue())`
`5869`	`5869`	`continue;`
`5870`		`- setFunctionReturnValue(function, tok, v, settings);`
	`5870`	`+ setFunctionReturnValue(function, tok, std::move(v), settings);`
`5871`	`5871`	`}`
`5872`	`5872`	`}`
`5873`	`5873`	`}`