Fix #5210 C-style pointer casting not detected for casts to ** (#4075)

Author: chrchr-github

lib/checkother.cpp

@@ -301,7 +301,7 @@ void CheckOther::warningOldStylePointerCast()
             tok = scope->bodyStart;
         for (; tok && tok != scope->bodyEnd; tok = tok->next()) {
             // Old style pointer casting..
-            if (!Token::Match(tok, "( const|volatile| const|volatile|class|struct| %type% * const|&| ) (| %name%|%num%|%bool%|%char%|%str%"))
+            if (!Token::Match(tok, "( const|volatile| const|volatile|class|struct| %type% * *| *| const|&| ) (| %name%|%num%|%bool%|%char%|%str%"))
                 continue;
             if (Token::Match(tok->previous(), "%type%"))
                 continue;

test/testother.cpp

@@ -1567,6 +1567,15 @@ class TestOther : public TestFixture {
                                  "    auto h = reinterpret_cast<void (STDAPICALLTYPE*)(int)>(p);\n"
                                  "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        // #5210
+        checkOldStylePointerCast("void f(void* v1, void* v2) {\n"
+                                 "    T** p1 = (T**)v1;\n"
+                                 "    T*** p2 = (T***)v2;\n"
+                                 "}\n");
+        ASSERT_EQUALS("[test.cpp:2]: (style) C-style pointer casting\n"
+                      "[test.cpp:3]: (style) C-style pointer casting\n",
+                      errout.str());
     }
 
 #define checkInvalidPointerCast(...) checkInvalidPointerCast_(__FILE__, __LINE__, __VA_ARGS__)