Fix #11157 FN: leakNoVarFunctionCall (switch condition) (#4240)

* Fix #10857 FN: leakNoVarFunctionCall

* Fix TODO

* Fix #10858 FN: leakNoVarFunctionCall (if ( b && malloc ) )

* #11155 FN: leakNoVarFunctionCall (ternary operator)

* Fix #11157 FN: leakNoVarFunctionCall (switch condition)

* Fix FN constStatement

* Fix FP leakNoVarFunctionCall

Author: chrchr-github

lib/checkmemoryleak.cpp

@@ -991,7 +991,7 @@ void CheckMemoryLeakNoVar::checkForUnreleasedInputArgument(const Scope *scope)
     // parse the executable scope until tok is reached...
     for (const Token *tok = scope->bodyStart; tok != scope->bodyEnd; tok = tok->next()) {
         // allocating memory in parameter for function call..
-        if (!Token::Match(tok, "%name% ("))
+        if (tok->varId() || !Token::Match(tok, "%name% ("))
             continue;
 
         // check if the output of the function is assigned
@@ -1014,11 +1014,12 @@ void CheckMemoryLeakNoVar::checkForUnreleasedInputArgument(const Scope *scope)
 
         const std::vector<const Token *> args = getArguments(tok);
         for (const Token* arg : args) {
-            if (arg->isOp())
+            if (arg->isOp() && !(tok->isKeyword() && arg->str() == "*")) // e.g. switch (*new int)
                 continue;
-            if (!(mTokenizer->isCPP() && Token::simpleMatch(arg, "new"))) {
-                while (arg->astOperand1())
-                    arg = arg->astOperand1();
+            while (arg->astOperand1()) {
+                if (mTokenizer->isCPP() && Token::simpleMatch(arg, "new"))
+                    break;
+                arg = arg->astOperand1();
             }
             if (getAllocationType(arg, 0) == No)
                 continue;

lib/checkother.cpp

@@ -1722,7 +1722,7 @@ void CheckOther::charBitOpError(const Token *tok)
 
 static bool isType(const Token * tok, bool unknown)
 {
-    if (Token::Match(tok, "%type%"))
+    if (tok && (tok->isStandardType() || (!tok->isKeyword() && Token::Match(tok, "%type%"))))
         return true;
     if (Token::simpleMatch(tok, "::"))
         return isType(tok->astOperand2(), unknown);

test/testincompletestatement.cpp

@@ -662,6 +662,11 @@ class TestIncompleteStatement : public TestFixture {
               "    +\" y = \" + b;\n"
               "}\n", /*inconclusive*/ true);
         ASSERT_EQUALS("[test.cpp:3]: (warning, inconclusive) Found suspicious operator '+', result is not used.\n", errout.str());
+
+        check("void f() {\n"
+              "    *new int;\n"
+              "}\n", /*inconclusive*/ true);
+        ASSERT_EQUALS("[test.cpp:2]: (warning, inconclusive) Found suspicious operator '*', result is not used.\n", errout.str());
     }
 
     void vardecl() {

test/testmemleak.cpp

@@ -2615,6 +2615,19 @@ class TestMemleakNoVar : public TestFixture {
         ASSERT_EQUALS("[test.cpp:1]: (error) Return value of allocation function 'new' is not stored.\n"
                       "[test.cpp:2]: (error) Return value of allocation function 'new' is not stored.\n",
                       errout.str());
+
+        check("void f() {\n" // #11157
+              "    switch (*new int) { case 42: break; }\n"
+              "    switch (*malloc(42)) { case 42: break; }\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:2]: (error) Allocation with new, switch doesn't release it.\n"
+                      "[test.cpp:3]: (error) Allocation with malloc, switch doesn't release it.\n",
+                      errout.str());
+
+        check("void f() {\n"
+              "    Ref<StringBuffer> remove(new StringBuffer());\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void smartPointerFunctionParam() {