Fix #12624 (The misra-config should not be a critical error) (#6306)

danmar · web-flow · commit 2ab6dc849cb2 · 2024-04-18T22:24:11.000+02:00
diff --git a/lib/errorlogger.cpp b/lib/errorlogger.cpp
@@ -47,7 +47,6 @@ const std::set<std::string> ErrorLogger::mCriticalErrorIds{
     "internalAstError",
     "instantiationError",
     "internalError",
-    "misra-config",
     "premium-internalError",
     "premium-invalidArgument",
     "premium-invalidLicense",
diff --git a/test/testerrorlogger.cpp b/test/testerrorlogger.cpp
@@ -65,6 +65,8 @@ class TestErrorLogger : public TestFixture {
 
         TEST_CASE(substituteTemplateFormatStatic);
         TEST_CASE(substituteTemplateLocationStatic);
+
+        TEST_CASE(isCriticalErrorId);
     }
 
     void TestPatternSearchReplace(const std::string& idPlaceholder, const std::string& id) const {
@@ -519,6 +521,11 @@ class TestErrorLogger : public TestFixture {
             ASSERT_EQUALS("{", s);
         }
     }
+
+    void isCriticalErrorId() const {
+        // It does not abort all the analysis of the file. Like "missingInclude" there can be false negatives.
+        ASSERT_EQUALS(false, ErrorLogger::isCriticalErrorId("misra-config"));
+    }
 };
 
 REGISTER_TEST(TestErrorLogger)

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,8 @@ class TestErrorLogger : public TestFixture {`
`65`	`65`
`66`	`66`	`TEST_CASE(substituteTemplateFormatStatic);`
`67`	`67`	`TEST_CASE(substituteTemplateLocationStatic);`
	`68`	`+`
	`69`	`+ TEST_CASE(isCriticalErrorId);`
`68`	`70`	`}`
`69`	`71`
`70`	`72`	`void TestPatternSearchReplace(const std::string& idPlaceholder, const std::string& id) const {`
`@@ -519,6 +521,11 @@ class TestErrorLogger : public TestFixture {`
`519`	`521`	`ASSERT_EQUALS("{", s);`
`520`	`522`	`}`
`521`	`523`	`}`
	`524`	`+`
	`525`	`+ void isCriticalErrorId() const {`
	`526`	`+ // It does not abort all the analysis of the file. Like "missingInclude" there can be false negatives.`
	`527`	`+ ASSERT_EQUALS(false, ErrorLogger::isCriticalErrorId("misra-config"));`
	`528`	`+ }`
`522`	`529`	`};`
`523`	`530`
`524`	`531`	`REGISTER_TEST(TestErrorLogger)`