Fixed #12260 (false positive: unusedVariable with side effects in member initialization) (#5762)

revert old changes

Author: olabetskyi

lib/checkunusedvar.cpp

@@ -1630,9 +1630,6 @@ bool CheckUnusedVar::isRecordTypeWithoutSideEffects(const Type* type)
 
 bool CheckUnusedVar::isVariableWithoutSideEffects(const Variable& var)
 {
-    if (var.isPointer())
-        return true;
-
     const Type* variableType = var.type();
     if (variableType) {
         if (!isRecordTypeWithoutSideEffects(variableType))

test/testunusedvar.cpp

@@ -459,6 +459,20 @@ class TestUnusedVar : public TestFixture {
             "}");
         TODO_ASSERT_EQUALS("error", "", errout.str());
 
+        // constructor with hidden definition
+        functionVariableUsage(
+            "class B {\n"
+            "public:\n"
+            "   B();\n"
+            "};\n"
+            "class A {\n"
+            "   B* b = new B;\n"
+            "};\n"
+            "int main() {\n"
+            "   A a;\n"
+            "}");
+        TODO_ASSERT_EQUALS("error", "", errout.str());
+
         // side-effect variable
         functionVariableUsage(
             "class F {\n"