Skip to content

Commit 78804ca

Browse files
committed
Remove <rules>...</rules>, added by 52aab1e which broke internal checking. In addition another internal rule was added, following up the changes from https://github.com/danmar/cppcheck/pull/4182/files
1 parent a658baf commit 78804ca

1 file changed

Lines changed: 40 additions & 35 deletions

File tree

rules/token-matching.xml

Lines changed: 40 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,41 @@
11
<?xml version="1.0"?>
2-
<rules>
3-
<rule version="1">
4-
<pattern>Token :: (?:findm|(?:simple|)M)atch \([^,]+,\s+"(?:\s+|[^"]+?\s+")</pattern>
5-
<message>
6-
<id>TokenMatchSpacing</id>
7-
<severity>style</severity>
8-
<summary>Useless extra spacing for Token::*Match.</summary>
9-
</message>
10-
</rule>
11-
<rule version="1">
12-
<pattern>(?U)Token :: Match \([^,]+,\s+"[^%|!\[\]]+"</pattern>
13-
<message>
14-
<id>UseTokensimpleMatch</id>
15-
<severity>error</severity>
16-
<summary>Token::simpleMatch should be used to match tokens
17-
without special pattern requirements.</summary>
18-
</message>
19-
</rule>
20-
<rule version="1">
21-
<pattern>\b[\w_]+ \. tokAt \( 0 \)</pattern>
22-
<message>
23-
<id>TokentokAt0</id>
24-
<severity>error</severity>
25-
<summary>tok->tokAt(0) is a slow way to say tok.</summary>
26-
</message>
27-
</rule>
28-
<rule version="1">
29-
<pattern>\b[\w_]+ \. strAt \( 0 \)</pattern>
30-
<message>
31-
<id>TokenstrAt0</id>
32-
<severity>error</severity>
33-
<summary>tok->strAt(0) is a slow way to say tok->str()</summary>
34-
</message>
35-
</rule>
36-
</rules>
2+
<rule version="1">
3+
<pattern>Token :: (?:findm|(?:simple|)M)atch \([^,]+,\s+"(?:\s+|[^"]+?\s+")</pattern>
4+
<message>
5+
<id>TokenMatchSpacing</id>
6+
<severity>style</severity>
7+
<summary>Useless extra spacing for Token::*Match.</summary>
8+
</message>
9+
</rule>
10+
<rule version="1">
11+
<pattern>(?U)Token :: Match \([^,]+,\s+"[^%|!\[\]]+" \)</pattern>
12+
<message>
13+
<id>UseTokensimpleMatch</id>
14+
<severity>error</severity>
15+
<summary>Token::simpleMatch should be used to match tokens without special pattern requirements.</summary>
16+
</message>
17+
</rule>
18+
<rule version="1">
19+
<pattern>\b[\w_]+ \. tokAt \( 0 \)</pattern>
20+
<message>
21+
<id>TokentokAt0</id>
22+
<severity>error</severity>
23+
<summary>tok->tokAt(0) is a slow way to say tok.</summary>
24+
</message>
25+
</rule>
26+
<rule version="1">
27+
<pattern>\b[\w_]+ \. strAt \( 0 \)</pattern>
28+
<message>
29+
<id>TokenstrAt0</id>
30+
<severity>error</severity>
31+
<summary>tok->strAt(0) is a slow way to say tok->str()</summary>
32+
</message>
33+
</rule>
34+
<rule version="1">
35+
<pattern><![CDATA[Token :: Match \( (\b\w+\b) , \"%var%\" \) && (\b\1\b) \. variable \( \)]]></pattern>
36+
<message>
37+
<id>TokenMatchVariable</id>
38+
<severity>error</severity>
39+
<summary>Simplify 'Token :: Match ( expr , %var% ) &amp;&amp; expr->variable()' to 'expr->variable()'</summary>
40+
</message>
41+
</rule>

0 commit comments

Comments
 (0)