valueflow.cpp: avoid unnecessary copy in valueFlowAfterAssign()

firewave · firewave · commit 97a857197560 · 2026-05-04T09:52:33.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -4226,7 +4226,7 @@ static void valueFlowAfterAssign(const TokenList &tokenlist,
                         continue;
                     ids.insert(value.tokvalue->exprId());
                 }
-                for (ValueFlow::Value value : values) {
+                for (ValueFlow::Value& value : values) {
                     if (!value.isSymbolicValue())
                         continue;
                     const Token* expr = value.tokvalue;

Original file line number	Diff line number	Diff line change
`@@ -4226,7 +4226,7 @@ static void valueFlowAfterAssign(const TokenList &tokenlist,`
`4226`	`4226`	`continue;`
`4227`	`4227`	`ids.insert(value.tokvalue->exprId());`
`4228`	`4228`	`}`
`4229`		`- for (ValueFlow::Value value : values) {`
	`4229`	`+ for (ValueFlow::Value& value : values) {`
`4230`	`4230`	`if (!value.isSymbolicValue())`
`4231`	`4231`	`continue;`
`4232`	`4232`	`const Token* expr = value.tokvalue;`