Skip to content

Commit f4030c4

Browse files
Fix #11791 Build regression with GCC 13 (#5193)
Patch supplied by Joachim Reichel.
1 parent 4ebb8ea commit f4030c4

3 files changed

Lines changed: 20 additions & 8 deletions

File tree

.github/workflows/CI-unixish.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,18 @@ jobs:
8585
sudo apt-get update
8686
sudo apt-get install libxml2-utils qtbase5-dev qttools5-dev libqt5charts5-dev qtchooser
8787
88+
- name: Set up GCC
89+
uses: egor-tensin/setup-gcc@v1
90+
if: matrix.os == 'ubuntu-22.04'
91+
with:
92+
version: 13
93+
platform: x64
94+
95+
- name: Select compiler
96+
run: |
97+
echo "CXX=g++-13" >> $GITHUB_ENV
98+
if: matrix.os == 'ubuntu-22.04'
99+
88100
# coreutils contains "nproc"
89101
- name: Install missing software on macos
90102
if: contains(matrix.os, 'macos')

gui/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ CheckOptions:
99
- { key: HeaderFileExtensions, value: 'x' }
1010
")
1111

12-
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:-DQT_NO_DEBUG>)
13-
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:-DQT_NO_DEBUG_OUTPUT>)
14-
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:-DQT_NO_WARNING_OUTPUT>)
15-
add_compile_definitions($<$<CONFIG:Debug>:-DQT_DEBUG>)
12+
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:QT_NO_DEBUG>)
13+
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:QT_NO_DEBUG_OUTPUT>)
14+
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:QT_NO_WARNING_OUTPUT>)
15+
add_compile_definitions($<$<CONFIG:Debug>:QT_DEBUG>)
1616

1717
file(GLOB hdrs "*.h")
1818
file(GLOB srcs "*.cpp")

tools/triage/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ CheckOptions:
88
- { key: HeaderFileExtensions, value: 'x' }
99
")
1010

11-
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:-DQT_NO_DEBUG>)
12-
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:-DQT_NO_DEBUG_OUTPUT>)
13-
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:-DQT_NO_WARNING_OUTPUT>)
14-
add_compile_definitions($<$<CONFIG:Debug>:-DQT_DEBUG>)
11+
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:QT_NO_DEBUG>)
12+
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:QT_NO_DEBUG_OUTPUT>)
13+
add_compile_definitions($<$<NOT:$<CONFIG:Debug>>:QT_NO_WARNING_OUTPUT>)
14+
add_compile_definitions($<$<CONFIG:Debug>:QT_DEBUG>)
1515

1616
file(GLOB hdrs "*.h")
1717
file(GLOB srcs "*.cpp")

0 commit comments

Comments
 (0)