subclass UICollectionViewFlowLayout

[stasix]

Hi Diego,
Really great job with this layout. Just wondering, have you considered subclassing UICollectionViewFlowLayout instead of UICollecitonViewLayout, and not introducing a new delegate (use flowLayout instead)?

Stas

[cruzdiego]

Hi Stas,
Thanks for commenting ^^. Yes, actually I started this layout as a FlowLayout subclass, but the needed re-calculation of the items origins was too costly performance wise. (In contrast of making a 'vertical' floating header layout, the items needed to be located in a different position: Below the header and aligned to the left of it != besides the header and aligned to the top of it)

So I decided to not subclass it from UICollectionViewFlowLayout. The main lost is, as you noted, is having a completely different delegate.

I'm open to suggestions, of course ^^.

[cruzdiego]

Now I'm thinking it should not be a problem using UICollectionViewDelegateFlowLayout without needing to subclass UICollectionViewFlowLayout.

Thank you, stasix!

[stasix]

I am subclassing UICollectionViewFlowLayout to add some properties (different than floating header). I changed the HorizontalFloatingHeaderLayout to subclass UICollectionViewFlowLayout, and did not see any performance issues. I still used your delegate methods instead of UICollectionViewDelegateFlowLayout.

[cruzdiego]

HorizontalFloatingHeaderLayout's code is creating its own layout, overriding all the important methods to do so. So making it a subclass of UICollectionViewFlowLayout doesn't have any effect on its current state. (Meaning It's not calling super's methods)

[stasix]

got it! So I could subclass HorizontalFloatingHeaderLayout directly in that case.