chore: bump ctrlplane chart version to 0.9.2 and update GitHub bot environment variable template

Author: jsbroks

charts/ctrlplane/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: ctrlplane
 description: Ctrlplane Helm chart for Kubernetes
 type: application
-version: 0.9.1
+version: 0.9.2
 appVersion: "1.0.0"
 
 maintainers:

charts/ctrlplane/templates/_github.tpl

@@ -14,9 +14,9 @@ Generate GitHub bot environment variables using the new valueFrom pattern
 - name: GITHUB_BOT_NAME
   value: {{ $bot.name | quote }}
 {{- end }}
-{{- include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_CLIENT_ID" "value" $bot.clientId) }}
-{{- include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_APP_ID" "value" $bot.appId) }}
-{{- include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_CLIENT_SECRET" "value" $bot.clientSecret) }}
-{{- include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_PRIVATE_KEY" "value" $bot.privateKey) }}
-{{- include "ctrlplane.envVar" (dict "name" "GITHUB_WEBHOOK_SECRET" "value" $bot.webhookSecret) }}
+{{ include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_CLIENT_ID" "value" $bot.clientId) }}
+{{ include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_APP_ID" "value" $bot.appId) }}
+{{ include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_CLIENT_SECRET" "value" $bot.clientSecret) }}
+{{ include "ctrlplane.envVar" (dict "name" "GITHUB_BOT_PRIVATE_KEY" "value" $bot.privateKey) }}
+{{ include "ctrlplane.envVar" (dict "name" "GITHUB_WEBHOOK_SECRET" "value" $bot.webhookSecret) }}
 {{- end -}}

charts/ctrlplane/tests/api_auth_env_test.yaml

@@ -85,3 +85,53 @@ tests:
                 key: client-secret
                 name: okta-oauth-secret
           any: true
+  - it: sets github bot env vars as plain strings
+    template: charts/api/templates/deployment.yaml
+    set:
+      global:
+        integrations:
+          github:
+            bot:
+              name: github-bot
+              clientId: github-client-id
+              appId: "12345"
+              clientSecret: github-client-secret
+              privateKey: github-bot-cert
+              webhookSecret: github-webhook-secret
+    asserts:
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: GITHUB_BOT_PRIVATE_KEY
+            value: github-bot-cert
+          any: true
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: GITHUB_BOT_NAME
+            value: github-bot
+          any: true
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: GITHUB_BOT_CLIENT_ID
+            value: github-client-id
+          any: true
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: GITHUB_BOT_APP_ID
+            value: "12345"
+          any: true
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: GITHUB_BOT_CLIENT_SECRET
+            value: github-client-secret
+          any: true
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: GITHUB_WEBHOOK_SECRET
+            value: github-webhook-secret
+          any: true