Skip to content

Commit a281caf

Browse files
fix: remove unnecessary release ID search in job update handler
1 parent ec9359a commit a281caf

1 file changed

Lines changed: 0 additions & 22 deletions

File tree

  • apps/workspace-engine/pkg/events/handler/jobs

apps/workspace-engine/pkg/events/handler/jobs/jobs.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,6 @@ func isStringUUID(s string) bool {
1717
return err == nil
1818
}
1919

20-
func getInternalReleaseID(ws *workspace.Workspace, jobUpdateEvent *oapi.JobUpdateEvent) string {
21-
eventReleaseID := jobUpdateEvent.Job.ReleaseId
22-
if eventReleaseID == "" {
23-
return ""
24-
}
25-
26-
if !isStringUUID(eventReleaseID) {
27-
return eventReleaseID
28-
}
29-
30-
for _, release := range ws.Releases().Items() {
31-
if release.UUID().String() == eventReleaseID {
32-
return release.ID()
33-
}
34-
}
35-
36-
return ""
37-
}
38-
3920
func HandleJobUpdated(
4021
ctx context.Context,
4122
ws *workspace.Workspace,
@@ -46,9 +27,6 @@ func HandleJobUpdated(
4627
return err
4728
}
4829

49-
internalReleaseID := getInternalReleaseID(ws, jobUpdateEvent)
50-
jobUpdateEvent.Job.ReleaseId = internalReleaseID
51-
5230
job, exists := getJob(ws, jobUpdateEvent)
5331
if !exists {
5432
return nil

0 commit comments

Comments
 (0)