From 2178227a33054c7d6ee3616035f55847b34fd66c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cabrera?= Date: Wed, 21 Jan 2026 17:12:43 -0600 Subject: [PATCH 1/2] add full name property and deactivable method to User --- cuenca/resources/users.py | 9 +++++++-- cuenca/version.py | 2 +- tests/resources/test_users.py | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/cuenca/resources/users.py b/cuenca/resources/users.py index 5e1ed71a..b23ed796 100644 --- a/cuenca/resources/users.py +++ b/cuenca/resources/users.py @@ -31,12 +31,12 @@ from ..http import Session, session as global_session from .balance_entries import BalanceEntry -from .base import Creatable, Queryable, Retrievable, Updateable +from .base import Creatable, Deactivable, Queryable, Retrievable, Updateable from .identities import Identity from .resources import retrieve_uri -class User(Creatable, Retrievable, Updateable, Queryable): +class User(Creatable, Retrievable, Updateable, Queryable, Deactivable): _resource: ClassVar = 'users' _query_params: ClassVar = UserQuery @@ -95,6 +95,11 @@ def balance(self) -> int: be = BalanceEntry.first(user_id=self.id) return be.rolling_balance if be else 0 + @property + def full_name(self): + name = f'{self.names} {self.first_surname} {self.second_surname}' + return name.strip() + model_config = ConfigDict( json_schema_extra={ 'example': { diff --git a/cuenca/version.py b/cuenca/version.py index e0d10bea..19a604b6 100644 --- a/cuenca/version.py +++ b/cuenca/version.py @@ -1,3 +1,3 @@ -__version__ = '2.1.15' +__version__ = '2.1.16.dev1' CLIENT_VERSION = __version__ API_VERSION = '2020-03-19' diff --git a/tests/resources/test_users.py b/tests/resources/test_users.py index a8331c4c..ba3b5973 100644 --- a/tests/resources/test_users.py +++ b/tests/resources/test_users.py @@ -51,6 +51,7 @@ def test_user_identity_retrieve(): user_id = 'USCM-zlFcNQk6ue4gZ_mTGeQ' user = User.retrieve(user_id) assert user_id == user.id + assert user.full_name == 'José López Hernández' identity = user.identity assert identity.id is not None From ec15955e58383099a267a01b6f0c16eaff070949 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cabrera?= Date: Wed, 21 Jan 2026 18:03:09 -0600 Subject: [PATCH 2/2] coderabbit comment --- cuenca/resources/users.py | 6 +++--- cuenca/version.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cuenca/resources/users.py b/cuenca/resources/users.py index b23ed796..c4f2059f 100644 --- a/cuenca/resources/users.py +++ b/cuenca/resources/users.py @@ -96,9 +96,9 @@ def balance(self) -> int: return be.rolling_balance if be else 0 @property - def full_name(self): - name = f'{self.names} {self.first_surname} {self.second_surname}' - return name.strip() + def full_name(self) -> str: + parts = [self.names, self.first_surname, self.second_surname] + return ' '.join(p for p in parts if p) model_config = ConfigDict( json_schema_extra={ diff --git a/cuenca/version.py b/cuenca/version.py index 19a604b6..4bf8267e 100644 --- a/cuenca/version.py +++ b/cuenca/version.py @@ -1,3 +1,3 @@ -__version__ = '2.1.16.dev1' +__version__ = '2.1.16' CLIENT_VERSION = __version__ API_VERSION = '2020-03-19'