From 7c598f1a2a5fbba612714658af160593cc9c136f Mon Sep 17 00:00:00 2001 From: Edward Chen Date: Sun, 2 Aug 2026 18:25:36 +0800 Subject: [PATCH] ci(capi): use TRANSCRIBE_HIP instead of GGML_HIP for ROCm jobs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Upstream PR #121 (223c9b0) added a TRANSCRIBE_HIP option that wraps GGML_HIP via FORCE, plus a PIC fix guarded by TRANSCRIBE_HIP for the hipcc/ROCm static-archive link problem. Passing -DGGML_HIP=ON directly left that PIC fix disabled — the ROCm jobs only worked because BUILD_SHARED_LIBS=ON happened to turn PIC on via ggml. Switch the Linux and Windows ROCm-CPU configure steps to -DTRANSCRIBE_HIP=ON so the build goes through the upstream wrapper: GGML_HIP is set correctly and the HIP PIC codegen fix applies. --- .github/workflows/capi-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/capi-build.yml b/.github/workflows/capi-build.yml index f1875c7e..1a39fd87 100644 --- a/.github/workflows/capi-build.yml +++ b/.github/workflows/capi-build.yml @@ -73,7 +73,7 @@ jobs: artifact_suffix: linux-cuda-cpu - name: ROCm-CPU container: rocm/dev-ubuntu-22.04:6.4-complete - cmake_extra: '-DGGML_HIP=ON -DGPU_TARGETS="gfx1100;gfx1101;gfx1102;gfx1150;gfx1151;gfx1200;gfx1201" -DCMAKE_PREFIX_PATH=/opt/rocm' + cmake_extra: '-DTRANSCRIBE_HIP=ON -DGPU_TARGETS="gfx1100;gfx1101;gfx1102;gfx1150;gfx1151;gfx1200;gfx1201" -DCMAKE_PREFIX_PATH=/opt/rocm' artifact_suffix: linux-rocm-cpu - name: SYCL-CPU container: intel/oneapi-basekit:2025.3.1-0-devel-ubuntu24.04 @@ -408,7 +408,7 @@ jobs: -DTRANSCRIBE_BUILD_TESTS=OFF ` -DTRANSCRIBE_BUILD_EXAMPLES=OFF ` -DTRANSCRIBE_BUILD_TOOLS=OFF ` - -DGGML_HIP=ON ` + -DTRANSCRIBE_HIP=ON ` -DGPU_TARGETS="${{ env.AMDGPU_TARGETS }}" ` -DCMAKE_PREFIX_PATH="$hipPath"