Improvement Summary
We should update the spectator experience so that whenever a modal element is shown for a mid-turn phase e.g. countering or picking a card to discard, that the spectator sees this via the corresponding game overlay and not the corresponding game dialog.
Detailed Description
Currently the spectator always views the game from the perspective of p0 and sees whatever dialogs they say e.g.
This is misleading because it looks to the spectator like they're actually being asked to make a choice that they aren't being asked to make. When someone is spectating, we should switch to only showing them the corresponding overlay for the "inactive" player:
This would better communicate that the spectator does not have a choice to make, but instead is watching a player make a decision.
Note: This should be a follow up to #1224 and needs to ensure that the relevant player's username shows up i.e. if aleph_one is faced with the decision to counter, it should read "aleph_one may counter" regardless of whether aleph_one was p0 or p1.
Improvement Summary
We should update the spectator experience so that whenever a modal element is shown for a mid-turn phase e.g. countering or picking a card to discard, that the spectator sees this via the corresponding game overlay and not the corresponding game dialog.
Detailed Description
Currently the spectator always views the game from the perspective of p0 and sees whatever dialogs they say e.g.
This is misleading because it looks to the spectator like they're actually being asked to make a choice that they aren't being asked to make. When someone is spectating, we should switch to only showing them the corresponding overlay for the "inactive" player:
This would better communicate that the spectator does not have a choice to make, but instead is watching a player make a decision.
Note: This should be a follow up to #1224 and needs to ensure that the relevant player's username shows up i.e. if aleph_one is faced with the decision to counter, it should read "aleph_one may counter" regardless of whether aleph_one was p0 or p1.