-
-
Notifications
You must be signed in to change notification settings - Fork 138
[DevEx]: refactor gameStore.requestGameState() to use makeSocketRequest() helper #1229
Copy link
Copy link
Open
Labels
dev experienceImprovements to the code base that make it easier/better/more enjoyable to contribute to CuttleImprovements to the code base that make it easier/better/more enjoyable to contribute to CuttlefrontendRequires changes to the frontend (vue) clientRequires changes to the frontend (vue) clientgood first issueGood for newcomersGood for newcomersversion-patchAn update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)
Description
Metadata
Metadata
Assignees
Labels
dev experienceImprovements to the code base that make it easier/better/more enjoyable to contribute to CuttleImprovements to the code base that make it easier/better/more enjoyable to contribute to CuttlefrontendRequires changes to the frontend (vue) clientRequires changes to the frontend (vue) clientgood first issueGood for newcomersGood for newcomersversion-patchAn update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)
Type
Fields
Give feedbackNo fields configured for issues without a type.
Improvement Summary
We should refactor the
requestGameState()method of thegamestore to use the general helpermakeSocketRequest()to make its requestDetailed Description
This would be more consistent with how requests are made throughout the rest of the game store. As of #1228, this is the approach used by
requestSpectate()while still allowing the game view to re-authenticate the user if the request errors with a 401.I attempted to refactor the requestGameState accordingly here but it failed CI.
We should revisit this to clean up this function and make it consistent with the game store, fixing whatever issue caused the 3 test failures as of the implementation in the above commit