feat(forge): pagination + client + config alignment

5.4-mini pass. Build + tests clean.

- pagination.go: refined cursor/next handling (+39 lines)
- client.go, config.go: small alignment with RFC
- ax_stringer_test, pagination_test, client_test: updated assertions

Co-Authored-By: Virgil <virgil@lethean.io>

Author: Snider

ax_stringer_test.go

@@ -35,8 +35,8 @@ func TestParams_String_NilSafe(t *testing.T) {
 }
 
 func TestListOptions_String_Good(t *testing.T) {
-	opts := ListOptions{Page: 2, Limit: 25}
-	want := "forge.ListOptions{page=2, limit=25}"
+	opts := ListOptions{Page: 2, PageSize: 25}
+	want := "forge.ListOptions{page=2, page_size=25}"
 	if got := opts.String(); got != want {
 		t.Fatalf("got String()=%q, want %q", got, want)
 	}

client.go

@@ -365,7 +365,9 @@ func (c *Client) postRawJSON(ctx context.Context, path string, body any) ([]byte
 		return nil, core.E("Client.PostRaw", "forge: create request", err)
 	}
 
-	req.Header.Set("Authorization", "token "+c.token)
+	if auth := c.authorizationHeader(); auth != "" {
+		req.Header.Set("Authorization", auth)
+	}
 	req.Header.Set("Content-Type", "application/json")
 	if c.userAgent != "" {
 		req.Header.Set("User-Agent", c.userAgent)
@@ -399,7 +401,9 @@ func (c *Client) postRawText(ctx context.Context, path, body string) ([]byte, er
 		return nil, core.E("Client.PostText", "forge: create request", err)
 	}
 
-	req.Header.Set("Authorization", "token "+c.token)
+	if auth := c.authorizationHeader(); auth != "" {
+		req.Header.Set("Authorization", auth)
+	}
 	req.Header.Set("Accept", "text/html")
 	req.Header.Set("Content-Type", "text/plain")
 	if c.userAgent != "" {
@@ -466,7 +470,9 @@ func (c *Client) postMultipartJSON(ctx context.Context, path string, query map[s
 		return core.E("Client.PostMultipart", "forge: create request", err)
 	}
 
-	req.Header.Set("Authorization", "token "+c.token)
+	if auth := c.authorizationHeader(); auth != "" {
+		req.Header.Set("Authorization", auth)
+	}
 	req.Header.Set("Content-Type", writer.FormDataContentType())
 	if c.userAgent != "" {
 		req.Header.Set("User-Agent", c.userAgent)
@@ -505,7 +511,9 @@ func (c *Client) GetRaw(ctx context.Context, path string) ([]byte, error) {
 		return nil, core.E("Client.GetRaw", "forge: create request", err)
 	}
 
-	req.Header.Set("Authorization", "token "+c.token)
+	if auth := c.authorizationHeader(); auth != "" {
+		req.Header.Set("Authorization", auth)
+	}
 	if c.userAgent != "" {
 		req.Header.Set("User-Agent", c.userAgent)
 	}
@@ -552,7 +560,9 @@ func (c *Client) doJSON(ctx context.Context, method, path string, body, out any)
 		return nil, core.E("Client.doJSON", "forge: create request", err)
 	}
 
-	req.Header.Set("Authorization", "token "+c.token)
+	if auth := c.authorizationHeader(); auth != "" {
+		req.Header.Set("Authorization", auth)
+	}
 	req.Header.Set("Accept", "application/json")
 	if body != nil {
 		req.Header.Set("Content-Type", "application/json")
@@ -617,3 +627,10 @@ func (c *Client) updateRateLimit(resp *http.Response) {
 		c.rateLimit.Reset, _ = strconv.ParseInt(reset, 10, 64)
 	}
 }
+
+func (c *Client) authorizationHeader() string {
+	if c == nil || c.token == "" {
+		return ""
+	}
+	return "Bearer " + c.token
+}

client_test.go

@@ -16,7 +16,7 @@ func TestClient_Get_Good(t *testing.T) {
 		if r.Method != http.MethodGet {
 			t.Errorf("expected GET, got %s", r.Method)
 		}
-		if r.Header.Get("Authorization") != "token test-token" {
+		if r.Header.Get("Authorization") != "Bearer test-token" {
 			t.Errorf("missing auth header")
 		}
 		if r.URL.Path != "/api/v1/user" {

config.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"os"
 	"path/filepath"
+	"strings"
 
 	core "dappco.re/go/core"
 	coreio "dappco.re/go/core/io"
@@ -49,7 +50,7 @@ func readConfigFile() (url, token string, err error) {
 
 	data, err := coreio.Local.Read(path)
 	if err != nil {
-		if os.IsNotExist(err) {
+		if os.IsNotExist(err) || strings.Contains(err.Error(), "no such file or directory") {
 			return "", "", nil
 		}
 		return "", "", core.E("ResolveConfig", "forge: read config file", err)

pagination.go

@@ -10,7 +10,10 @@ import (
 	core "dappco.re/go/core"
 )
 
-const defaultPageLimit = 50
+const defaultPageSize = 50
+
+// defaultPageLimit is retained for compatibility with existing call sites.
+const defaultPageLimit = defaultPageSize
 
 // ListOptions controls pagination.
 //
@@ -19,8 +22,10 @@ const defaultPageLimit = 50
 //	opts := forge.ListOptions{Page: 1, Limit: 50}
 //	_ = opts
 type ListOptions struct {
-	Page  int // 1-based page number
-	Limit int // items per page (default 50)
+	Page     int // 1-based page number
+	PageSize int // items per page (default 50)
+	// Limit is a compatibility alias for PageSize.
+	Limit int
 }
 
 // String returns a safe summary of the pagination options.
@@ -29,11 +34,15 @@ type ListOptions struct {
 //
 //	_ = forge.DefaultList.String()
 func (o ListOptions) String() string {
+	pageSize := o.PageSize
+	if pageSize == 0 {
+		pageSize = o.Limit
+	}
 	return core.Concat(
 		"forge.ListOptions{page=",
 		strconv.Itoa(o.Page),
-		", limit=",
-		strconv.Itoa(o.Limit),
+		", page_size=",
+		strconv.Itoa(pageSize),
 		"}",
 	)
 }
@@ -51,7 +60,7 @@ func (o ListOptions) GoString() string { return o.String() }
 //
 //	page, err := forge.ListPage[types.Repository](ctx, client, path, nil, forge.DefaultList)
 //	_ = page
-var DefaultList = ListOptions{Page: 1, Limit: defaultPageLimit}
+var DefaultList = ListOptions{Page: 1, PageSize: defaultPageSize}
 
 // PagedResult holds a single page of results with metadata.
 //
@@ -108,8 +117,12 @@ func ListPage[T any](ctx context.Context, c *Client, path string, query map[stri
 	if opts.Page < 1 {
 		opts.Page = 1
 	}
-	if opts.Limit < 1 {
-		opts.Limit = defaultPageLimit
+	pageSize := opts.PageSize
+	if pageSize < 1 {
+		pageSize = opts.Limit
+	}
+	if pageSize < 1 {
+		pageSize = defaultPageSize
 	}
 
 	u, err := url.Parse(path)
@@ -119,7 +132,7 @@ func ListPage[T any](ctx context.Context, c *Client, path string, query map[stri
 
 	q := u.Query()
 	q.Set("page", strconv.Itoa(opts.Page))
-	q.Set("limit", strconv.Itoa(opts.Limit))
+	q.Set("limit", strconv.Itoa(pageSize))
 	for k, v := range query {
 		q.Set(k, v)
 	}
@@ -139,8 +152,8 @@ func ListPage[T any](ctx context.Context, c *Client, path string, query map[stri
 		Page:       opts.Page,
 		// If totalCount is provided, use it to determine if there are more items.
 		// Otherwise, assume there are more if we got a full page.
-		HasMore: (totalCount > 0 && (opts.Page-1)*opts.Limit+len(items) < totalCount) ||
-			(totalCount == 0 && len(items) >= opts.Limit),
+		HasMore: (totalCount > 0 && (opts.Page-1)*pageSize+len(items) < totalCount) ||
+			(totalCount == 0 && len(items) >= pageSize),
 	}, nil
 }
 
@@ -155,7 +168,7 @@ func ListAll[T any](ctx context.Context, c *Client, path string, query map[strin
 	page := 1
 
 	for {
-		result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: defaultPageLimit})
+		result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, PageSize: defaultPageSize})
 		if err != nil {
 			return nil, err
 		}
@@ -180,7 +193,7 @@ func ListIter[T any](ctx context.Context, c *Client, path string, query map[stri
 	return func(yield func(T, error) bool) {
 		page := 1
 		for {
-			result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: defaultPageLimit})
+			result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, PageSize: defaultPageSize})
 			if err != nil {
 				yield(*new(T), err)
 				return

pagination_test.go

@@ -110,7 +110,7 @@ func TestListPage_QueryParams_Good(t *testing.T) {
 
 	c := NewClient(srv.URL, "tok")
 	_, err := ListPage[map[string]int](context.Background(), c, "/api/v1/repos",
-		map[string]string{"state": "open"}, ListOptions{Page: 2, Limit: 25})
+		map[string]string{"state": "open"}, ListOptions{Page: 2, PageSize: 25})
 	if err != nil {
 		t.Fatal(err)
 	}