From 77ddb20b2e0d6f786c45b09af64e4c1c8e6c1c76 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Tue, 31 Mar 2026 21:54:13 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Palette:=20Fix=20missing=20Dialo?= =?UTF-8?q?gContent=20in=20TherapeuticGoalsTracker=20modal?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 💡 What: Wrapped the `
` inside the add/edit goal `` with ``. 🎯 Why: The original implementation was missing ``, which meant the modal lacked the necessary `role="dialog"`, `aria-modal="true"`, and focus trapping logic required for screen readers and keyboard accessibility. 📸 Before/After: Before, the modal rendered bare HTML tags. After, it properly utilizes the Shadcn-style dialog wrapper with accessibility features enabled. ♿ Accessibility: Ensures the modal can be properly navigated by keyboard and announced by screen readers as a dialog. Co-authored-by: daggerstuff <261005129+daggerstuff@users.noreply.github.com> --- src/components/therapy/TherapeuticGoalsTracker.tsx | 4 +++- .../ui/__tests__/PasswordInputWithStrength.test.tsx | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/therapy/TherapeuticGoalsTracker.tsx b/src/components/therapy/TherapeuticGoalsTracker.tsx index f7c6d245e..d837f574e 100644 --- a/src/components/therapy/TherapeuticGoalsTracker.tsx +++ b/src/components/therapy/TherapeuticGoalsTracker.tsx @@ -2,7 +2,7 @@ import { useState, useEffect } from 'react' import { Button } from '@/components/ui/button' import { Card } from '@/components/ui/card' -import { Dialog, DialogTitle } from '@/components/ui/dialog' +import { Dialog, DialogContent, DialogTitle } from '@/components/ui/dialog' import { Input } from '@/components/ui/input' import { Progress } from '@/components/ui/progress' import { Textarea } from '@/components/ui/textarea' @@ -348,6 +348,7 @@ export function TherapeuticGoalsTracker({ if (!open) closeModal() }} > + {editGoal ? 'Edit Goal' : 'Add Goal'} +
)} diff --git a/src/components/ui/__tests__/PasswordInputWithStrength.test.tsx b/src/components/ui/__tests__/PasswordInputWithStrength.test.tsx index 189d1e746..ef3d96f0a 100644 --- a/src/components/ui/__tests__/PasswordInputWithStrength.test.tsx +++ b/src/components/ui/__tests__/PasswordInputWithStrength.test.tsx @@ -105,4 +105,4 @@ describe('PasswordInputWithStrength', () => { const progressbar = screen.getByRole('progressbar') expect(progressbar.getAttribute('aria-valuetext')).toBe('empty') }) -} \ No newline at end of file +}) \ No newline at end of file