Skip to content

Commit 2a22fdf

Browse files
committed
Update CLAUDE.md
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
1 parent 3663c3a commit 2a22fdf

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

CLAUDE.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22

33
Use pathlib instead of os.path.
44
Use httpx instead of urllib.
5+
subprocess(`shell=True`) is used only when it makes the code more readable. Use either shlex or args lists.
6+
subprocess calls should have a reasonable timeout.
57
Use modern Python (3.10+) features.
68
Make all code strongly typed.
79
Keep conditional nesting to a minimum, and use guard clauses when possible.
8-
Aim for medium "visual complexity": use intermediate variables to store results of nested/complex function calls, but don't create a new variable for everything.
9-
Avoid comments unless there is an unusual gotcha, a complex algorithm or anything an experienced code reviewer needs to be aware of. Focus on making better Google-style docstrings instead.
10+
Aim for medium "visual complexity": use intermediate variables to store results of nested/complex function calls, but don't create a new variable for everything.
11+
Avoid comments unless there is a gotcha, a complex algorithm or anything an experienced code reviewer needs to be aware of. Focus on making better Google-style docstrings instead.
1012

1113
The user is not always right. Be skeptical and do not blindly comply if something doesn't make sense.
1214
Code should be production-ready.

tests/integration/conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ def cleanup(self) -> None:
105105
for client in self._clients:
106106
client.close()
107107
self._clients.clear()
108+
108109
for proc in self._processes:
109110
if proc.poll() is None:
110111
proc.terminate()
@@ -114,6 +115,7 @@ def cleanup(self) -> None:
114115
proc.kill()
115116
proc.wait()
116117
self._processes.clear()
118+
117119
for log_path in self._log_files:
118120
log_path.unlink(missing_ok=True)
119121
self._log_files.clear()

0 commit comments

Comments
 (0)