Skip to content

Commit d3ca6d3

Browse files
committed
Address Copilot comments (1)
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
1 parent a39b0db commit d3ca6d3

4 files changed

Lines changed: 5 additions & 8 deletions

File tree

AGENTS.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,8 @@ Each extension is a **separate PyPI package** with its own `setup.cfg`, `setup.p
6565

6666
The `examples/` directory contains user-facing example applications. These are validated by two test suites:
6767

68-
- **`tests/examples/`** — Output-based tests that run examples via `dapr run` and check stdout for expected strings. Uses a `DaprRunner` helper to manage process lifecycle.
69-
- **`tests/integration/`** — Programmatic SDK tests that call `DaprClient` methods directly and assert on return values, gRPC status codes, and SDK types. More reliable than output-based tests since they don't depend on print statement formatting.
70-
71-
**See `examples/AGENTS.md`** for the full guide on example structure and how to add new examples.
68+
- **`tests/examples/`** — Output-based tests that run examples via `dapr run` and check stdout for expected strings. Uses a `DaprRunner` helper to manage process lifecycle. See `examples/AGENTS.md`.
69+
- **`tests/integration/`** — Programmatic SDK tests that call `DaprClient` methods directly and assert on return values, gRPC status codes, and SDK types. More reliable than output-based tests since they don't depend on print statement formatting. See `tests/integration/AGENTS.md`.
7270

7371
Quick reference:
7472
```bash

examples/AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# AGENTS.md — Dapr Python SDK Examples
22

3-
The `examples/` directory serves as both **user-facing documentation** and the project's **integration test suite**. Each example is a self-contained application validated by pytest-based tests in `tests/examples/`.
3+
The `examples/` directory serves as the **user-facing documentation**. Each example is a self-contained application validated by pytest-based tests in `tests/examples/`.
44

55
## How validation works
66

examples/conversation/real_llm_providers_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1237,7 +1237,7 @@ def main():
12371237

12381238
print(f'\n{"=" * 60}')
12391239
print('🎉 All Alpha2 tests completed!')
1240-
print('✅ Real LLM provider examples with Alpha2 API is working correctly')
1240+
print('✅ Real LLM provider integration with Alpha2 API is working correctly')
12411241
print('🔧 Features demonstrated:')
12421242
print(' • Alpha2 conversation API with sophisticated message types')
12431243
print(' • Automatic parameter conversion (raw Python values)')

tests/integration/test_configuration.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ def _redis_set(key: str, value: str, version: int = 1) -> None:
1616
Dapr's Redis configuration store encodes values as ``value||version``.
1717
"""
1818
subprocess.run(
19-
f'docker exec {REDIS_CONTAINER} redis-cli SET {key} "{value}||{version}"',
20-
shell=True,
19+
args=('docker', 'exec', REDIS_CONTAINER, 'redis-cli', 'SET', key, f'"{value}||{version}"'),
2120
check=True,
2221
capture_output=True,
2322
)

0 commit comments

Comments
 (0)