From 802d139a580ce5719a86450f3223214de98c58e9 Mon Sep 17 00:00:00 2001 From: Ali Date: Thu, 23 Apr 2026 17:44:52 +0500 Subject: [PATCH] ci: check generated proto output for drift, not just the raw protos MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `make check-diff-proto` only diffed `./proto/`, which contains the raw `.proto` source files downloaded from `dapr/dapr` via `update-protos.sh`. The rust code emitted by `proto-gen` lives in `dapr/src/dapr/` and `examples/src/invoke/protos/` — if either drifts (hand-edited or out of date with the tracked `.proto` files), the CI step currently passes. Extend the diff to cover the generated directories as well, so `make proto-gen check-diff-proto` fails the build whenever running `proto-gen` against the committed `.proto` files would modify any tracked file. Closes #208 Signed-off-by: Ali --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 81071b1b..291cdc0f 100644 --- a/Makefile +++ b/Makefile @@ -4,4 +4,4 @@ proto-gen: .PHONY: check-diff-proto check-diff-proto: - git diff --exit-code ./proto/ \ No newline at end of file + git diff --exit-code ./proto/ ./dapr/src/dapr/ ./examples/src/invoke/protos/ \ No newline at end of file