Add scatological word list, addScatologicalWords method and tests#27
Open
iabw wants to merge 2 commits into
Open
Add scatological word list, addScatologicalWords method and tests#27iabw wants to merge 2 commits into
iabw wants to merge 2 commits into
Conversation
Contributor
|
One option would be to take one of the list of "bad words" linked here and feed them into wordfilter. Perhaps a more general solution would be to add a function to wordfilter similar to |
Author
|
That sounds like a good suggestion, although I still think there should be an even more simple way of 'filter as much as possible' - which is what I was reaching for here. I'm sure the lists you link to are better than the list I threw together. If that's not a goal of wordfilter and there's a more full-featured filter lib, I wouldn't mind a reference to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the option of blacklisting a bunch of scatological words at once, but doesn't add them by default. The "addScatologicalWords" method was added to js, python, and php and "add_scatological_words" to the ruby. Unit tests were added for all languages.
I don't personally care about scatological words either, but when building a tool targeted to children this option might be wanted without having to manually build a list oneself. I couldn't find a nice list online somewhere already (which is why I think this PR is useful), so I just combed through http://www.noswearing.com/dictionary and added the words that weren't already in badwords.json