Build failure with USE_LIBRAW=OFF

[dtrtuser]

Is there an existing issue for this?

• I checked and did not find my issue in the already reported ones

Describe the bug

Every other optional image loader (OpenEXR, WebP, JPEG XL, AVIF, HEIF, GraphicsMagick, ImageMagick) falls back to _unsupported_type when its library isn't built in, but dt_imageio_open_libraw is missing that guard.

Steps to reproduce

build with USE_LIBRAW=OFF

Expected behavior

should build

Logfile | Screenshot | Screencast

fix could be as simple as adding the following lines to imageio.c:

#ifndef HAVE_LIBRAW
#define dt_imageio_open_libraw _unsupported_type
#endif

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

5.7.0

What OS are you using?

Windows

What is the version of your OS?

11

Describe your system

msys2 on windows

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[victoryforce]

@dtrtuser Thanks for reporting this bug!

I have one question, did you intentionally want to build darktable without Libraw, i.e. without CR3 support? If so, what was your goal? The thing is, I'm considering making this library mandatory instead of fixing builds with Libraw disabled. The logic is that we don't allow builds without RawSpeed, i.e. without support for most raw files. This simply makes no sense, because darktable is primarily a raw image developer (although it can work with cooked formats). I don't see any reason why we should behave differently with support for one specific format from Canon cameras (CR3).

[dtrtuser]

Hi,

The reason I created this issue is because:

1. For consistency: USE_LIBRAW=OFF is a valid flag that hasn't been implemented.
2. LibRaw is a workaround for 1 file type but including it adds a lot to build time. I was trying to do a minimalistic build that would turn off all features that I don't need.

I understand this is definitively a low priority issue. Feel free to close it.

Thanks!

[victoryforce]

• For consistency: USE_LIBRAW=OFF is a valid flag that hasn't been implemented.

A pedantic wording would be: the flag itself is implemented, but the source code contains a bug that makes building with this flag fail. But, yes, you are absolutely right. This needs to be fixed.

• LibRaw is a workaround for 1 file type but including it adds a lot to build time.

Libraw not adding much to build time for me. For my own build I always set DONT_USE_INTERNAL_LIBRAW to skip compiling in-tree Libraw and just linking with libraw package in msys2.

I was trying to do a minimalistic build that would turn off all features that I don't need.

I will try to formulate a consistent, albeit unwritten logic (well, as I see it) behind what is mandatory and what is optional in darktable. In this logic, darktable does not support the ability to exclude absolutely all features that a particular user does not need. For example, you may not need TIFF, but support for this format is mandatory.

As long as Rawspeed is not enough and Libraw is needed to fully cover all raw formats, I don't see the logic in allowing Libraw to be optional.