From c885b55b979091b808b78ffe1b4e6ade6b2a937e Mon Sep 17 00:00:00 2001 From: PastaClaw Date: Tue, 24 Mar 2026 11:35:54 -0500 Subject: [PATCH] test: fix wait_for_instantlock calls in test_instantsend_after_restart The merge of #7240 and #7241 left two call sites in test_instantsend_after_restart using the old positional signature wait_for_instantlock(txid, node). After #7241 changed the signature to *txids with keyword-only nodes=, the node object was silently consumed as a second txid, causing the wait to always time out. Use the new consolidated API which handles mempool sync and checks all nodes by default. --- test/functional/p2p_instantsend.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/test/functional/p2p_instantsend.py b/test/functional/p2p_instantsend.py index ff184c2745b7..8dd14eb35cd7 100755 --- a/test/functional/p2p_instantsend.py +++ b/test/functional/p2p_instantsend.py @@ -139,10 +139,7 @@ def test_instantsend_after_restart(self): receiver = self.nodes[self.receiver_idx] sender_addr = sender.getnewaddress() fund_id = self.nodes[0].sendtoaddress(sender_addr, 1) - self.bump_mocktime(30) - self.sync_mempools() - for node in self.nodes: - self.wait_for_instantlock(fund_id, node) + self.wait_for_instantlock(fund_id) tip = self.generate(self.nodes[0], 2)[-1] self.bump_mocktime(30) self.wait_for_chainlocked_block_all_nodes(tip) @@ -199,10 +196,7 @@ def check_mn_peers(node=mn_node, my_hash=mn_info.proTxHash): # send a TX — needs IS lock from all restarted MNs, no new blocks mined is_id = sender.sendtoaddress(receiver_addr, 0.5) - self.bump_mocktime(30) - self.sync_mempools() - for node in self.nodes: - self.wait_for_instantlock(is_id, node) + self.wait_for_instantlock(is_id) self.log.info("InstantSend lock succeeded after full restart") # clean up