diff --git a/doc/design/assumeutxo.md b/doc/design/assumeutxo.md index 667b3deda0b5..e9562f87a1a3 100644 --- a/doc/design/assumeutxo.md +++ b/doc/design/assumeutxo.md @@ -41,7 +41,7 @@ be of use. Chainstate within the system goes through a number of phases when UTXO snapshots are used, as managed by `ChainstateManager`. At various points there can be multiple -`CChainState` objects in existence to facilitate both maintaining the network tip and +`Chainstate` objects in existence to facilitate both maintaining the network tip and performing historical validation of the assumed-valid chain. It is worth noting that though there are multiple separate chainstates, those @@ -53,7 +53,7 @@ data. ### "Normal" operation via initial block download -`ChainstateManager` manages a single CChainState object, for which +`ChainstateManager` manages a single Chainstate object, for which `m_snapshot_blockhash` is null. This chainstate is (maybe obviously) considered active. This is the "traditional" mode of operation for dashd. diff --git a/doc/developer-notes.md b/doc/developer-notes.md index c343f3a7e007..61025728bef1 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -1034,7 +1034,7 @@ void CTxMemPool::UpdateTransactionsFromBlock(...) ```C++ // validation.h -class CChainState +class Chainstate { protected: ... @@ -1055,7 +1055,7 @@ public: } // validation.cpp -bool CChainState::PreciousBlock(BlockValidationState& state, CBlockIndex* pindex) +bool Chainstate::PreciousBlock(BlockValidationState& state, CBlockIndex* pindex) { AssertLockNotHeld(m_chainstate_mutex); AssertLockNotHeld(::cs_main); diff --git a/src/Makefile.am b/src/Makefile.am index a0eca537b48d..99627e98a932 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -244,7 +244,6 @@ BITCOIN_CORE_H = \ gsl/pointers.h \ flat-database.h \ flatfile.h \ - fs.h \ httprpc.h \ httpserver.h \ i2p.h \ @@ -398,6 +397,8 @@ BITCOIN_CORE_H = \ util/error.h \ util/fastrange.h \ util/fees.h \ + util/fs.h \ + util/fs_helpers.h \ util/golombrice.h \ util/hasher.h \ util/hash_type.h \ @@ -978,7 +979,6 @@ libbitcoin_util_a_SOURCES = \ support/lockedpool.cpp \ chainparamsbase.cpp \ clientversion.cpp \ - fs.cpp \ interfaces/echo.cpp \ interfaces/handler.cpp \ interfaces/init.cpp \ @@ -996,6 +996,8 @@ libbitcoin_util_a_SOURCES = \ util/edge.cpp \ util/error.cpp \ util/fees.cpp \ + util/fs.cpp \ + util/fs_helpers.cpp \ util/hasher.cpp \ util/getuniquepath.cpp \ util/sock.cpp \ diff --git a/src/addrdb.cpp b/src/addrdb.cpp index 83bc6192ff7b..823bbc7fe009 100644 --- a/src/addrdb.cpp +++ b/src/addrdb.cpp @@ -8,7 +8,8 @@ #include #include #include -#include +#include +#include #include #include #include diff --git a/src/addrdb.h b/src/addrdb.h index 911b791b7170..2d71f7456e74 100644 --- a/src/addrdb.h +++ b/src/addrdb.h @@ -6,9 +6,9 @@ #ifndef BITCOIN_ADDRDB_H #define BITCOIN_ADDRDB_H -#include #include // For banmap_t #include +#include #include #include diff --git a/src/banman.h b/src/banman.h index c968fd99a2c0..77d78966a58d 100644 --- a/src/banman.h +++ b/src/banman.h @@ -7,9 +7,9 @@ #include #include -#include #include // For banmap_t #include +#include #include #include diff --git a/src/bench/bench.cpp b/src/bench/bench.cpp index ae017833ce6b..de8eacfa9570 100644 --- a/src/bench/bench.cpp +++ b/src/bench/bench.cpp @@ -4,8 +4,8 @@ #include -#include #include +#include #include #include diff --git a/src/bench/bench.h b/src/bench/bench.h index 63e1bf67e21e..d3fba1e28c41 100644 --- a/src/bench/bench.h +++ b/src/bench/bench.h @@ -5,7 +5,7 @@ #ifndef BITCOIN_BENCH_BENCH_H #define BITCOIN_BENCH_BENCH_H -#include +#include #include #include diff --git a/src/bench/bench_bitcoin.cpp b/src/bench/bench_bitcoin.cpp index 4db5412e16d6..c34949264cc2 100644 --- a/src/bench/bench_bitcoin.cpp +++ b/src/bench/bench_bitcoin.cpp @@ -8,7 +8,7 @@ #include #include #include -#include +#include #include #include diff --git a/src/bench/load_external.cpp b/src/bench/load_external.cpp index 150654a095ca..ec97be45ff1e 100644 --- a/src/bench/load_external.cpp +++ b/src/bench/load_external.cpp @@ -48,7 +48,7 @@ static void LoadExternalBlockFile(benchmark::Bench& bench) fclose(file); } - CChainState& chainstate{testing_setup->m_node.chainman->ActiveChainstate()}; + Chainstate& chainstate{testing_setup->m_node.chainman->ActiveChainstate()}; std::multimap blocks_with_unknown_parent; FlatFilePos pos; bench.run([&] { diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp index a1dfb9e7d374..47b569f1ae19 100644 --- a/src/bitcoin-tx.cpp +++ b/src/bitcoin-tx.cpp @@ -13,7 +13,7 @@ #include #include #include -#include +#include #include #include #include