From aa4e692a2714ec325b54ce94daea38f0f4369a7e Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Fri, 13 Mar 2026 22:01:15 +0700
Subject: [PATCH 1/9] fix: add guards if CTxMempool is nullptr in chainstate

---
 src/node/chainstate.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/node/chainstate.cpp b/src/node/chainstate.cpp
index 289720d0949f..a7bfb33fd133 100644
--- a/src/node/chainstate.cpp
+++ b/src/node/chainstate.cpp
@@ -233,7 +233,9 @@ void DashChainstateSetup(ChainstateManager& chainman,
     llmq_ctx = std::make_unique<LLMQContext>(*dmnman, evodb, sporkman, chainman, mn_sync,
                                              util::DbWrapperParams{.path = data_dir, .memory = llmq_dbs_in_memory, .wipe = llmq_dbs_wipe},
                                              bls_threads, worker_count, max_recsigs_age);
-    mempool->ConnectManagers(dmnman.get(), llmq_ctx->isman.get());
+    if (mempool) {
+        mempool->ConnectManagers(dmnman.get(), llmq_ctx->isman.get());
+    }
     chain_helper.reset();
     chain_helper = std::make_unique<CChainstateHelper>(evodb, *dmnman, govman, *(llmq_ctx->isman), *(llmq_ctx->quorum_block_processor),
                                                        *(llmq_ctx->qsnapman), chainman, consensus_params, mn_sync, chainlocks,
@@ -248,7 +250,9 @@ void DashChainstateSetupClose(std::unique_ptr<CChainstateHelper>& chain_helper,
 {
     chain_helper.reset();
     llmq_ctx.reset();
-    mempool->DisconnectManagers();
+    if (mempool) {
+        mempool->DisconnectManagers();
+    }
     dmnman.reset();
 }
 

From d0414cc063bfa3bffada5a10c0f896de8e06f4cb Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Fri, 13 Mar 2026 14:16:18 +0700
Subject: [PATCH 2/9] refactor: drop dependency of governance/object on
 core_write (ScriptToAsmStr)

---
 src/governance/object.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/governance/object.cpp b/src/governance/object.cpp
index d05e5b021e99..86431439196f 100644
--- a/src/governance/object.cpp
+++ b/src/governance/object.cpp
@@ -12,11 +12,11 @@
 #include <masternode/sync.h>
 
 #include <chainparams.h>
-#include <core_io.h>
 #include <index/txindex.h>
 #include <logging.h>
 #include <node/interface_ui.h>
 #include <timedata.h>
+#include <util/strencodings.h>
 #include <util/time.h>
 #include <validation.h>
 #include <validationinterface.h>
@@ -491,12 +491,12 @@ bool CGovernanceObject::IsCollateralValid(const ChainstateManager& chainman, std
     CAmount nMinFee = GetMinCollateralFee();
 
     LogPrint(BCLog::GOBJECT, "CGovernanceObject::IsCollateralValid -- txCollateral->vout.size() = %s, findScript = %s, nMinFee = %lld\n",
-                txCollateral->vout.size(), ScriptToAsmStr(findScript, false), nMinFee);
+                txCollateral->vout.size(), HexStr(findScript), nMinFee);
 
     bool foundOpReturn = false;
     for (const auto& output : txCollateral->vout) {
         LogPrint(BCLog::GOBJECT, "CGovernanceObject::IsCollateralValid -- txout = %s, output.nValue = %lld, output.scriptPubKey = %s\n",
-                    output.ToString(), output.nValue, ScriptToAsmStr(output.scriptPubKey, false));
+                    output.ToString(), output.nValue, HexStr(output.scriptPubKey));
         if (!output.scriptPubKey.IsPayToPublicKeyHash() && !output.scriptPubKey.IsUnspendable()) {
             strError = strprintf("Invalid Script %s", txCollateral->ToString());
             LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);

From 312ca8ee5185657722bdc6d46b0869355fe33f03 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Fri, 13 Mar 2026 13:47:43 +0700
Subject: [PATCH 3/9] refactor: drop pfrom from CGovernanceManager::ProcessVote

---
 src/governance/governance.cpp     | 4 ++--
 src/governance/governance.h       | 2 +-
 src/governance/net_governance.cpp | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/governance/governance.cpp b/src/governance/governance.cpp
index 0123bba56b2b..142eb7ac80bd 100644
--- a/src/governance/governance.cpp
+++ b/src/governance/governance.cpp
@@ -752,14 +752,14 @@ bool CGovernanceManager::ProcessVoteAndRelay(const CGovernanceVote& vote, CGover
     AssertLockNotHeld(cs_store);
     AssertLockNotHeld(cs_relay);
     uint256 hashToRequest; // Ignored for local votes (no peer to request from)
-    bool fOK = ProcessVote(/*pfrom=*/nullptr, vote, exception, hashToRequest);
+    bool fOK = ProcessVote(vote, exception, hashToRequest);
     if (fOK) {
         RelayVote(vote);
     }
     return fOK;
 }
 
-bool CGovernanceManager::ProcessVote(CNode* pfrom, const CGovernanceVote& vote, CGovernanceException& exception,
+bool CGovernanceManager::ProcessVote(const CGovernanceVote& vote, CGovernanceException& exception,
                                      uint256& hashToRequest)
 {
     AssertLockNotHeld(cs_store);
diff --git a/src/governance/governance.h b/src/governance/governance.h
index cb43b3bbd452..7feae5a3a022 100644
--- a/src/governance/governance.h
+++ b/src/governance/governance.h
@@ -381,7 +381,7 @@ class CGovernanceManager : public GovernanceStore, public GovernanceSignerParent
     CDeterministicMNManager& GetMNManager();
     /** Process a governance vote. Returns true on success.
      *  If the vote is for an unknown object (orphan), hashToRequest is set to the object hash. */
-    bool ProcessVote(CNode* pfrom, const CGovernanceVote& vote, CGovernanceException& exception, uint256& hashToRequest)
+    bool ProcessVote(const CGovernanceVote& vote, CGovernanceException& exception, uint256& hashToRequest)
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store);
 
 
diff --git a/src/governance/net_governance.cpp b/src/governance/net_governance.cpp
index 7849ff91544e..c9314c9cc1d5 100644
--- a/src/governance/net_governance.cpp
+++ b/src/governance/net_governance.cpp
@@ -169,7 +169,7 @@ void NetGovernance::ProcessMessage(CNode& peer, const std::string& msg_type, CDa
 
         CGovernanceException exception;
         uint256 hashToRequest;
-        if (m_gov_manager.ProcessVote(&peer, vote, exception, hashToRequest)) {
+        if (m_gov_manager.ProcessVote(vote, exception, hashToRequest)) {
             LogPrint(BCLog::GOBJECT, "MNGOVERNANCEOBJECTVOTE -- %s new\n", strHash);
             m_node_sync.BumpAssetLastTime("MNGOVERNANCEOBJECTVOTE");
 

From 2b2d0a4bb02cc67249476726fe5a9222e1bb4629 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Fri, 13 Mar 2026 13:04:48 +0700
Subject: [PATCH 4/9] refactor: move CDeterministicMN::ToJson to core_write to
 avoid g_txindex dependency for linking

---
 src/evo/deterministicmns.cpp | 43 +++++++-----------------------------
 src/qt/masternodemodel.cpp   |  1 +
 src/rpc/evo_util.cpp         | 28 +++++++++++++++++++++++
 3 files changed, 37 insertions(+), 35 deletions(-)

diff --git a/src/evo/deterministicmns.cpp b/src/evo/deterministicmns.cpp
index 55b86c240647..9c70869382c3 100644
--- a/src/evo/deterministicmns.cpp
+++ b/src/evo/deterministicmns.cpp
@@ -4,6 +4,10 @@
 
 #include <evo/deterministicmns.h>
 
+#include <chainparams.h>
+#include <coins.h>
+#include <consensus/validation.h>
+#include <deploymentstatus.h>
 #include <evo/dmn_types.h>
 #include <evo/dmnstate.h>
 #include <evo/evodb.h>
@@ -11,25 +15,19 @@
 #include <evo/simplifiedmns.h>
 #include <evo/specialtx.h>
 #include <masternode/meta.h>
-#include <stats/client.h>
-#include <util/helpers.h>
-
-#include <chainparams.h>
-#include <coins.h>
-#include <consensus/validation.h>
-#include <deploymentstatus.h>
-#include <index/txindex.h>
 #include <node/blockstorage.h>
 #include <script/standard.h>
+#include <stats/client.h>
 #include <uint256.h>
+#include <util/helpers.h>
+
+#include <univalue.h>
 
 #include <functional>
 #include <optional>
 #include <memory>
 #include <ranges>
 
-#include <univalue.h>
-
 static const std::string DB_LIST_SNAPSHOT = "dmn_S3";
 static const std::string DB_LIST_DIFF = "dmn_D4";        // Bumped for nVersion-first format
 static const std::string DB_LIST_DIFF_LEGACY = "dmn_D3"; // Legacy format key
@@ -55,31 +53,6 @@ std::string CDeterministicMN::ToString() const
     return strprintf("CDeterministicMN(proTxHash=%s, collateralOutpoint=%s, nOperatorReward=%f, state=%s", proTxHash.ToString(), collateralOutpoint.ToStringShort(), (double)nOperatorReward / 100, pdmnState->ToString());
 }
 
-UniValue CDeterministicMN::ToJson() const
-{
-    UniValue obj(UniValue::VOBJ);
-    obj.pushKV("type", std::string(GetMnType(nType).description));
-    obj.pushKV("proTxHash", proTxHash.ToString());
-    obj.pushKV("collateralHash", collateralOutpoint.hash.ToString());
-    obj.pushKV("collateralIndex", collateralOutpoint.n);
-
-    if (g_txindex) {
-        CTransactionRef collateralTx;
-        uint256 nBlockHash;
-        g_txindex->FindTx(collateralOutpoint.hash, nBlockHash, collateralTx);
-        if (collateralTx) {
-            CTxDestination dest;
-            if (ExtractDestination(collateralTx->vout[collateralOutpoint.n].scriptPubKey, dest)) {
-                obj.pushKV("collateralAddress", EncodeDestination(dest));
-            }
-        }
-    }
-
-    obj.pushKV("operatorReward", (double)nOperatorReward / 100);
-    obj.pushKV("state", pdmnState->ToJson(nType));
-    return obj;
-}
-
 bool CDeterministicMNList::IsMNValid(const uint256& proTxHash) const
 {
     auto p = mnMap.find(proTxHash);
diff --git a/src/qt/masternodemodel.cpp b/src/qt/masternodemodel.cpp
index ccafc277c3d9..2a5353882dc0 100644
--- a/src/qt/masternodemodel.cpp
+++ b/src/qt/masternodemodel.cpp
@@ -78,6 +78,7 @@ MasternodeEntry::MasternodeEntry(const interfaces::MnEntryCPtr& dmn, const QStri
         m_operator_reward = QObject::tr("NONE");
     }
 
+    // TODO: get rid of this JSON
     const auto json{dmn->toJson()};
     m_json = QString::fromStdString(json.write(2));
     if (const auto& val = json.find_value("collateralHash"); val.isStr()) {
diff --git a/src/rpc/evo_util.cpp b/src/rpc/evo_util.cpp
index 927bd55439fb..c9c57871e72e 100644
--- a/src/rpc/evo_util.cpp
+++ b/src/rpc/evo_util.cpp
@@ -4,7 +4,9 @@
 
 #include <rpc/evo_util.h>
 
+#include <evo/deterministicmns.h>
 #include <evo/providertx.h>
+#include <index/txindex.h>
 #include <rpc/protocol.h>
 #include <rpc/request.h>
 
@@ -136,3 +138,29 @@ void ProcessNetInfoPlatform(ProTx& ptx, const UniValue& input_p2p, const UniValu
 }
 template void ProcessNetInfoPlatform(CProRegTx& ptx, const UniValue& input_p2p, const UniValue& input_http, const bool optional);
 template void ProcessNetInfoPlatform(CProUpServTx& ptx, const UniValue& input_p2p, const UniValue& input_http, const bool optional);
+
+
+UniValue CDeterministicMN::ToJson() const
+{
+    UniValue obj(UniValue::VOBJ);
+    obj.pushKV("type", std::string(GetMnType(nType).description));
+    obj.pushKV("proTxHash", proTxHash.ToString());
+    obj.pushKV("collateralHash", collateralOutpoint.hash.ToString());
+    obj.pushKV("collateralIndex", collateralOutpoint.n);
+
+    if (g_txindex) {
+        CTransactionRef collateralTx;
+        uint256 nBlockHash;
+        g_txindex->FindTx(collateralOutpoint.hash, nBlockHash, collateralTx);
+        if (collateralTx) {
+            CTxDestination dest;
+            if (ExtractDestination(collateralTx->vout[collateralOutpoint.n].scriptPubKey, dest)) {
+                obj.pushKV("collateralAddress", EncodeDestination(dest));
+            }
+        }
+    }
+
+    obj.pushKV("operatorReward", (double)nOperatorReward / 100);
+    obj.pushKV("state", pdmnState->ToJson(nType));
+    return obj;
+}

From 646c2c88e1397d63e182f2355e66f6bd10037938 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <github@knstqq.com>
Date: Thu, 30 Apr 2026 03:24:12 +0700
Subject: [PATCH 5/9] fix: circular dependency over rpc/evo_util

---
 src/evo/dmnstate.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/evo/dmnstate.cpp b/src/evo/dmnstate.cpp
index 9f04f4069ef9..8d0601b5a6bf 100644
--- a/src/evo/dmnstate.cpp
+++ b/src/evo/dmnstate.cpp
@@ -4,11 +4,8 @@
 
 #include <evo/dmnstate.h>
 
-#include <script/standard.h>
-
 #include <evo/netinfo.h>
-#include <rpc/evo_util.h>
-
+#include <script/standard.h>
 #include <univalue.h>
 
 std::string CDeterministicMNState::ToString() const

From f4ee8b4a1ce1424ea6101163f3239fe4b62abd65 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Fri, 13 Mar 2026 13:58:43 +0700
Subject: [PATCH 6/9] refactor: drop dependency of CGovernanceManager on
 net.cpp

---
 src/governance/governance.cpp     | 14 +++++++-------
 src/governance/governance.h       |  6 +++---
 src/governance/net_governance.cpp |  2 +-
 src/governance/signing.cpp        |  2 +-
 src/governance/signing.h          |  3 +--
 5 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/src/governance/governance.cpp b/src/governance/governance.cpp
index 142eb7ac80bd..94c74db4b0e0 100644
--- a/src/governance/governance.cpp
+++ b/src/governance/governance.cpp
@@ -181,7 +181,7 @@ void CGovernanceManager::AddPostponedObjectInternal(const CGovernanceObject& gov
     mapPostponedObjects.emplace(govobj.GetHash(), std::make_shared<CGovernanceObject>(govobj));
 }
 
-bool CGovernanceManager::ProcessObject(const CNode& peer, const uint256& nHash, CGovernanceObject& govobj)
+bool CGovernanceManager::ProcessObject(const std::string& peer_str, const uint256& nHash, CGovernanceObject& govobj)
 {
     std::string strHash = nHash.ToString();
 
@@ -227,7 +227,7 @@ bool CGovernanceManager::ProcessObject(const CNode& peer, const uint256& nHash,
         }
     }
 
-    AddGovernanceObjectInternal(govobj, &peer);
+    AddGovernanceObjectInternal(govobj, peer_str);
     return true;
 }
 
@@ -260,7 +260,7 @@ void CGovernanceManager::CheckOrphanVotes(CGovernanceObject& govobj)
     }
 }
 
-void CGovernanceManager::AddGovernanceObjectInternal(CGovernanceObject& insert_obj, const CNode* pfrom)
+void CGovernanceManager::AddGovernanceObjectInternal(CGovernanceObject& insert_obj, const std::string& peer_str)
 {
     AssertLockHeld(::cs_main);
     AssertLockHeld(cs_store);
@@ -308,7 +308,7 @@ void CGovernanceManager::AddGovernanceObjectInternal(CGovernanceObject& insert_o
         return;
     }
 
-    LogPrint(BCLog::GOBJECT, "CGovernanceManager::AddGovernanceObject -- %s new, received from peer %s\n", strHash, pfrom ? pfrom->GetLogString() : "nullptr");
+    LogPrint(BCLog::GOBJECT, "CGovernanceManager::AddGovernanceObject -- %s new, received from peer %s\n", strHash, peer_str);
     RelayObject(*govobj);
 
     // Update the rate buffer
@@ -325,10 +325,10 @@ void CGovernanceManager::AddGovernanceObjectInternal(CGovernanceObject& insert_o
     uiInterface.NotifyGovernanceChanged();
 }
 
-void CGovernanceManager::AddGovernanceObject(CGovernanceObject& govobj, const CNode* pfrom)
+void CGovernanceManager::AddGovernanceObject(CGovernanceObject& govobj, const std::string& peer_str)
 {
     LOCK2(::cs_main, cs_store);
-    AddGovernanceObjectInternal(govobj, pfrom);
+    AddGovernanceObjectInternal(govobj, peer_str);
 }
 
 void CGovernanceManager::CheckAndRemove()
@@ -831,7 +831,7 @@ void CGovernanceManager::CheckPostponedObjects()
         bool fMissingConfirmations;
         if (govobj.IsCollateralValid(m_chainman, strError, fMissingConfirmations)) {
             if (govobj.IsValidLocally(Assert(m_dmnman)->GetListAtChainTip(), m_chainman, strError, false)) {
-                AddGovernanceObjectInternal(govobj);
+                AddGovernanceObjectInternal(govobj, "nullptr");
             } else {
                 LogPrint(BCLog::GOBJECT, "CGovernanceManager::CheckPostponedObjects -- %s invalid\n", nHash.ToString());
             }
diff --git a/src/governance/governance.h b/src/governance/governance.h
index 7feae5a3a022..f5f5fdee3463 100644
--- a/src/governance/governance.h
+++ b/src/governance/governance.h
@@ -321,7 +321,7 @@ class CGovernanceManager : public GovernanceStore, public GovernanceSignerParent
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store);
     std::vector<std::shared_ptr<const CGovernanceObject>> GetApprovedProposals(const CDeterministicMNList& tip_mn_list) override
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store);
-    void AddGovernanceObject(CGovernanceObject& govobj, const CNode* pfrom = nullptr) override
+    void AddGovernanceObject(CGovernanceObject& govobj, const std::string& peer_str = "nullptr") override
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store, !cs_relay);
 
     // Superblocks
@@ -375,7 +375,7 @@ class CGovernanceManager : public GovernanceStore, public GovernanceSignerParent
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store);
     /// Called to indicate a requested object or vote has been received
     bool AcceptMessage(const uint256& nHash) EXCLUSIVE_LOCKS_REQUIRED(!cs_store);
-    bool ProcessObject(const CNode& peer, const uint256& hash, CGovernanceObject& govobj)
+    bool ProcessObject(const std::string& peer_str, const uint256& hash, CGovernanceObject& govobj)
         EXCLUSIVE_LOCKS_REQUIRED(::cs_main, !cs_store, !cs_relay);
 
     CDeterministicMNManager& GetMNManager();
@@ -401,7 +401,7 @@ class CGovernanceManager : public GovernanceStore, public GovernanceSignerParent
         EXCLUSIVE_LOCKS_REQUIRED(cs_store);
 
     // Internal counterpart to "Signer interface"
-    void AddGovernanceObjectInternal(CGovernanceObject& govobj, const CNode* pfrom = nullptr)
+    void AddGovernanceObjectInternal(CGovernanceObject& govobj, const std::string& peer_str)
         EXCLUSIVE_LOCKS_REQUIRED(::cs_main, cs_store, !cs_relay);
 
     // ...
diff --git a/src/governance/net_governance.cpp b/src/governance/net_governance.cpp
index c9314c9cc1d5..852175d05b36 100644
--- a/src/governance/net_governance.cpp
+++ b/src/governance/net_governance.cpp
@@ -134,7 +134,7 @@ void NetGovernance::ProcessMessage(CNode& peer, const std::string& msg_type, CDa
             return;
         }
 
-        if (!WITH_LOCK(::cs_main, return m_gov_manager.ProcessObject(peer, nHash, govobj))) {
+        if (!WITH_LOCK(::cs_main, return m_gov_manager.ProcessObject(peer.GetLogString(), nHash, govobj))) {
             // apply node's ban score
             m_peer_manager->PeerMisbehaving(peer.GetId(), 20);
         }
diff --git a/src/governance/signing.cpp b/src/governance/signing.cpp
index 1aec5e818073..ad9bc5cdc8d0 100644
--- a/src/governance/signing.cpp
+++ b/src/governance/signing.cpp
@@ -163,7 +163,7 @@ std::optional<const CGovernanceObject> GovernanceSigner::CreateGovernanceTrigger
     }
 
     // The trigger we just created looks good, submit it
-    m_govman.AddGovernanceObject(gov_sb);
+    m_govman.AddGovernanceObject(gov_sb, "nullptr");
     return std::make_optional<CGovernanceObject>(gov_sb);
 }
 
diff --git a/src/governance/signing.h b/src/governance/signing.h
index f03aec29096d..6f4d3884bd09 100644
--- a/src/governance/signing.h
+++ b/src/governance/signing.h
@@ -23,7 +23,6 @@ class CGovernanceException;
 class CGovernanceVote;
 class ChainstateManager;
 class CMasternodeSync;
-class CNode;
 enum vote_outcome_enum_t : int;
 
 class GovernanceSignerParent
@@ -42,7 +41,7 @@ class GovernanceSignerParent
     virtual std::vector<std::shared_ptr<CSuperblock>> GetActiveTriggers() const = 0;
     virtual std::vector<std::shared_ptr<const CGovernanceObject>> GetApprovedProposals(
         const CDeterministicMNList& tip_mn_list) = 0;
-    virtual void AddGovernanceObject(CGovernanceObject& govobj, const CNode* pfrom = nullptr) = 0;
+    virtual void AddGovernanceObject(CGovernanceObject& govobj, const std::string& peer_str) = 0;
 };
 
 class GovernanceSigner

From 69d4a060d8c4a278f3af1d3eebbc5534b0be1daf Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <github@knstqq.com>
Date: Wed, 6 May 2026 14:34:57 +0700
Subject: [PATCH 7/9] feat: better loging of p2p governance objects, separate
 local and pendings

---
 src/governance/governance.cpp | 2 +-
 src/governance/governance.h   | 2 +-
 src/governance/signing.cpp    | 2 +-
 src/node/interfaces.cpp       | 2 +-
 src/rpc/governance.cpp        | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/governance/governance.cpp b/src/governance/governance.cpp
index 94c74db4b0e0..b79a6b532ed2 100644
--- a/src/governance/governance.cpp
+++ b/src/governance/governance.cpp
@@ -831,7 +831,7 @@ void CGovernanceManager::CheckPostponedObjects()
         bool fMissingConfirmations;
         if (govobj.IsCollateralValid(m_chainman, strError, fMissingConfirmations)) {
             if (govobj.IsValidLocally(Assert(m_dmnman)->GetListAtChainTip(), m_chainman, strError, false)) {
-                AddGovernanceObjectInternal(govobj, "nullptr");
+                AddGovernanceObjectInternal(govobj, "<postponed>");
             } else {
                 LogPrint(BCLog::GOBJECT, "CGovernanceManager::CheckPostponedObjects -- %s invalid\n", nHash.ToString());
             }
diff --git a/src/governance/governance.h b/src/governance/governance.h
index f5f5fdee3463..bce031abede0 100644
--- a/src/governance/governance.h
+++ b/src/governance/governance.h
@@ -321,7 +321,7 @@ class CGovernanceManager : public GovernanceStore, public GovernanceSignerParent
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store);
     std::vector<std::shared_ptr<const CGovernanceObject>> GetApprovedProposals(const CDeterministicMNList& tip_mn_list) override
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store);
-    void AddGovernanceObject(CGovernanceObject& govobj, const std::string& peer_str = "nullptr") override
+    void AddGovernanceObject(CGovernanceObject& govobj, const std::string& peer_str) override
         EXCLUSIVE_LOCKS_REQUIRED(!cs_store, !cs_relay);
 
     // Superblocks
diff --git a/src/governance/signing.cpp b/src/governance/signing.cpp
index ad9bc5cdc8d0..173860b1aa19 100644
--- a/src/governance/signing.cpp
+++ b/src/governance/signing.cpp
@@ -163,7 +163,7 @@ std::optional<const CGovernanceObject> GovernanceSigner::CreateGovernanceTrigger
     }
 
     // The trigger we just created looks good, submit it
-    m_govman.AddGovernanceObject(gov_sb, "nullptr");
+    m_govman.AddGovernanceObject(gov_sb, "<local>");
     return std::make_optional<CGovernanceObject>(gov_sb);
 }
 
diff --git a/src/node/interfaces.cpp b/src/node/interfaces.cpp
index f3eac13383ad..f5172c1da9c3 100644
--- a/src/node/interfaces.cpp
+++ b/src/node/interfaces.cpp
@@ -403,7 +403,7 @@ class GOVImpl : public GOV
             context().govman->AddPostponedObject(govobj);
             context().govman->RelayObject(govobj);
         } else {
-            context().govman->AddGovernanceObject(govobj);
+            context().govman->AddGovernanceObject(govobj, "<local>");
         }
         out_object_hash = govobj.GetHash().ToString();
         return true;
diff --git a/src/rpc/governance.cpp b/src/rpc/governance.cpp
index 7770f7f1cbf3..e188d5c89a81 100644
--- a/src/rpc/governance.cpp
+++ b/src/rpc/governance.cpp
@@ -413,7 +413,7 @@ static RPCHelpMan gobject_submit()
         node.govman->AddPostponedObject(govobj);
         node.govman->RelayObject(govobj);
     } else {
-        node.govman->AddGovernanceObject(govobj);
+        node.govman->AddGovernanceObject(govobj, "<local>");
     }
 
     return govobj.GetHash().ToString();

From 3441f04b330e5e2084d429c90812ee1a8908cf67 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Fri, 13 Mar 2026 14:44:11 +0700
Subject: [PATCH 8/9] refactor: move multiple msg_result.h usages headers to
 implementation

NOTE: the circular dependency over dkgsessionhandler <-> net_processing is not new,
it's pre-existing one.

Dependency of llmq/observer is also pre-existing but has been marked by recursive including over msg_result.h
    "llmq/dkgsessionhandler -> net_processing -> llmq/dkgsessionmgr -> llmq/dkgsessionhandler",
    "llmq/dkgsessionhandler -> net_processing -> llmq/observer -> llmq/dkgsessionhandler",
---
 src/llmq/dkgsessionmgr.cpp              |  2 ++
 src/llmq/dkgsessionmgr.h                | 21 +++++++++++++--------
 src/llmq/observer.cpp                   |  1 +
 test/lint/lint-circular-dependencies.py |  1 +
 4 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/src/llmq/dkgsessionmgr.cpp b/src/llmq/dkgsessionmgr.cpp
index 76384c8e73ed..ae71e08d28ca 100644
--- a/src/llmq/dkgsessionmgr.cpp
+++ b/src/llmq/dkgsessionmgr.cpp
@@ -6,9 +6,11 @@
 
 #include <bls/bls_ies.h>
 #include <evo/deterministicmns.h>
+#include <llmq/dkgsessionhandler.h>
 #include <llmq/options.h>
 #include <llmq/params.h>
 #include <llmq/utils.h>
+#include <msg_result.h>
 #include <spork.h>
 #include <unordered_lru_cache.h>
 #include <util/helpers.h>
diff --git a/src/llmq/dkgsessionmgr.h b/src/llmq/dkgsessionmgr.h
index 23cf14491ddd..6bd35cebc550 100644
--- a/src/llmq/dkgsessionmgr.h
+++ b/src/llmq/dkgsessionmgr.h
@@ -7,11 +7,10 @@
 
 #include <bls/bls.h>
 #include <bls/bls_worker.h>
-#include <llmq/dkgsessionhandler.h>
-#include <msg_result.h>
-#include <util/helpers.h>
-
+#include <chainparams.h>
 #include <net_types.h>
+#include <util/helpers.h>
+#include <sync.h>
 
 #include <map>
 #include <memory>
@@ -31,10 +30,10 @@ class ChainstateManager;
 class CMasternodeMetaMan;
 class CSporkManager;
 class PeerManager;
-class CDKGContribution;
-class CDKGComplaint;
-class CDKGJustification;
-class CDKGPrematureCommitment;
+class CInv;
+class CNode;
+class CConnman;
+struct MessageProcessingResult;
 namespace util {
 struct DbWrapperParams;
 } // namespace util
@@ -43,6 +42,11 @@ class UniValue;
 
 namespace llmq
 {
+class CDKGComplaint;
+class CDKGContribution;
+class CDKGJustification;
+class CDKGPrematureCommitment;
+class CDKGSessionHandler;
 class CQuorumSnapshotManager;
 
 class CDKGSessionManager
@@ -102,6 +106,7 @@ class CDKGSessionManager
     template <typename HandlerFn>
     void InitializeHandlers(HandlerFn&& handler_fn)
     {
+        // TODO: move it to cpp file and drop chainparams.h and helpers.h
         const Consensus::Params& consensus_params = Params().GetConsensus();
         for (const auto& params : consensus_params.llmqs) {
             auto session_count = (params.useRotation) ? params.signingActiveQuorumCount : 1;
diff --git a/src/llmq/observer.cpp b/src/llmq/observer.cpp
index b9ce11d31bfe..bb9bc3f0bcd3 100644
--- a/src/llmq/observer.cpp
+++ b/src/llmq/observer.cpp
@@ -6,6 +6,7 @@
 
 #include <llmq/debug.h>
 #include <llmq/dkgsessionmgr.h>
+#include <llmq/dkgsessionhandler.h>
 
 #include <chain.h>
 #include <validation.h>
diff --git a/test/lint/lint-circular-dependencies.py b/test/lint/lint-circular-dependencies.py
index 96ce0c51fa02..62e1e7741cad 100755
--- a/test/lint/lint-circular-dependencies.py
+++ b/test/lint/lint-circular-dependencies.py
@@ -44,6 +44,7 @@
     "llmq/blockprocessor -> llmq/utils -> llmq/snapshot -> llmq/blockprocessor",
     "llmq/commitment -> llmq/utils -> llmq/snapshot -> llmq/commitment",
     "llmq/dkgsessionhandler -> net_processing -> llmq/dkgsessionmgr -> llmq/dkgsessionhandler",
+    "llmq/dkgsessionhandler -> net_processing -> llmq/observer -> llmq/dkgsessionhandler",
     "masternode/payments -> validation -> masternode/payments",
     "net -> netmessagemaker -> net",
     "netaddress -> netbase -> netaddress",

From 0bcb345ce7980b22e1c471528b60536421baf144 Mon Sep 17 00:00:00 2001
From: Konstantin Akimov <knstqq@gmail.com>
Date: Fri, 13 Mar 2026 13:11:41 +0700
Subject: [PATCH 9/9] refactor: move VerifyChainLock and ChainLockSig between
 modules to untangle chain-state dependencies

chain-state should be available to validate chainlocks without using
chainlock/handlers.cpp which is tightly connected to network code.

On other hand, VerifyChainLock uses quorumsman, so it can't be just moved to chainlock/clsig or something
like that because it will create new circular dependency over quorumsman.

Though, chainlock::Chainlock and chainlock::ChainLockSig are tightly connected
and there is no usages of ChainLockSig withdout Chainlock except regression tests;
moving ChainLockSig to chainlock.h is fine then.
---
 src/chainlock/chainlock.cpp       | 17 ++++++++++++-
 src/chainlock/chainlock.h         | 30 ++++++++++++++++++++--
 src/chainlock/clsig.cpp           | 25 ++++++++----------
 src/chainlock/clsig.h             | 42 +++++++++++--------------------
 src/chainlock/handler.cpp         | 21 +++++-----------
 src/chainlock/handler.h           |  9 -------
 src/chainlock/signing.h           |  1 -
 src/rpc/quorums.cpp               |  1 +
 src/test/llmq_chainlock_tests.cpp |  2 +-
 src/test/util/llmq_tests.h        |  2 +-
 src/zmq/zmqpublishnotifier.cpp    |  2 +-
 11 files changed, 80 insertions(+), 72 deletions(-)

diff --git a/src/chainlock/chainlock.cpp b/src/chainlock/chainlock.cpp
index b12b02879d99..1b376e90cea8 100644
--- a/src/chainlock/chainlock.cpp
+++ b/src/chainlock/chainlock.cpp
@@ -4,12 +4,27 @@
 
 #include <chainlock/chainlock.h>
 
-#include <chainlock/clsig.h>
+#include <chain.h>
 #include <logging.h>
 #include <spork.h>
 
 namespace chainlock {
 
+ChainLockSig::ChainLockSig() = default;
+ChainLockSig::~ChainLockSig() = default;
+
+ChainLockSig::ChainLockSig(int32_t nHeight, const uint256& blockHash, const CBLSSignature& sig) :
+    nHeight{nHeight},
+    blockHash{blockHash},
+    sig{sig}
+{
+}
+
+std::string ChainLockSig::ToString() const
+{
+    return strprintf("ChainLockSig(nHeight=%d, blockHash=%s)", nHeight, blockHash.ToString());
+}
+
 Chainlocks::Chainlocks(const CSporkManager& sporkman) :
     m_sporks(sporkman)
 {
diff --git a/src/chainlock/chainlock.h b/src/chainlock/chainlock.h
index e6d34ad9aa60..3ee131264ad2 100644
--- a/src/chainlock/chainlock.h
+++ b/src/chainlock/chainlock.h
@@ -5,19 +5,45 @@
 #ifndef BITCOIN_CHAINLOCK_CHAINLOCK_H
 #define BITCOIN_CHAINLOCK_CHAINLOCK_H
 
-#include <chain.h>
-#include <chainlock/clsig.h>
+#include <bls/bls.h>
 #include <gsl/pointers.h>
+#include <serialize.h>
 #include <sync.h>
 #include <uint256.h>
 
+class CBlockIndex;
 class CSporkManager;
+class uint256;
 
 namespace chainlock {
 
 //! Depth of block including transactions before it's considered safe
 static constexpr int32_t TX_CONFIRM_THRESHOLD{5};
 
+struct ChainLockSig {
+private:
+    int32_t nHeight{-1};
+    uint256 blockHash;
+    CBLSSignature sig;
+
+public:
+    ChainLockSig();
+    ~ChainLockSig();
+
+    ChainLockSig(int32_t nHeight, const uint256& blockHash, const CBLSSignature& sig);
+
+    [[nodiscard]] int32_t getHeight() const { return nHeight; }
+    [[nodiscard]] const uint256& getBlockHash() const { return blockHash; }
+    [[nodiscard]] const CBLSSignature& getSig() const { return sig; }
+    [[nodiscard]] bool IsNull() const { return nHeight == -1 && blockHash == uint256(); }
+    [[nodiscard]] std::string ToString() const;
+
+    SERIALIZE_METHODS(ChainLockSig, obj)
+    {
+        READWRITE(obj.nHeight, obj.blockHash, obj.sig);
+    }
+};
+
 class Chainlocks
 {
 private:
diff --git a/src/chainlock/clsig.cpp b/src/chainlock/clsig.cpp
index 573331bba610..980be33a3750 100644
--- a/src/chainlock/clsig.cpp
+++ b/src/chainlock/clsig.cpp
@@ -4,30 +4,27 @@
 
 #include <chainlock/clsig.h>
 
-#include <tinyformat.h>
+#include <chainparams.h>
+#include <chainlock/chainlock.h>
+#include <llmq/quorumsman.h>
 
 #include <string_view>
 
 namespace chainlock {
 static constexpr std::string_view CLSIG_REQUESTID_PREFIX{"clsig"};
 
-ChainLockSig::ChainLockSig() = default;
-ChainLockSig::~ChainLockSig() = default;
-
-ChainLockSig::ChainLockSig(int32_t nHeight, const uint256& blockHash, const CBLSSignature& sig) :
-    nHeight{nHeight},
-    blockHash{blockHash},
-    sig{sig}
+uint256 GenSigRequestId(const int32_t nHeight)
 {
+    return ::SerializeHash(std::make_pair(CLSIG_REQUESTID_PREFIX, nHeight));
 }
 
-std::string ChainLockSig::ToString() const
+llmq::VerifyRecSigStatus VerifyChainLock(const Consensus::Params& params, const CChain& chain,
+                                         const llmq::CQuorumManager& qman, const chainlock::ChainLockSig& clsig)
 {
-    return strprintf("ChainLockSig(nHeight=%d, blockHash=%s)", nHeight, blockHash.ToString());
-}
+    const auto llmqType = params.llmqTypeChainLocks;
+    const uint256 request_id = GenSigRequestId(clsig.getHeight());
 
-uint256 GenSigRequestId(const int32_t nHeight)
-{
-    return ::SerializeHash(std::make_pair(CLSIG_REQUESTID_PREFIX, nHeight));
+    return llmq::VerifyRecoveredSig(llmqType, chain, qman, clsig.getHeight(), request_id, clsig.getBlockHash(),
+                                    clsig.getSig());
 }
 } // namespace chainlock
diff --git a/src/chainlock/clsig.h b/src/chainlock/clsig.h
index 3800f2f813cb..7ff6c7fee67a 100644
--- a/src/chainlock/clsig.h
+++ b/src/chainlock/clsig.h
@@ -5,40 +5,28 @@
 #ifndef BITCOIN_CHAINLOCK_CLSIG_H
 #define BITCOIN_CHAINLOCK_CLSIG_H
 
-#include <serialize.h>
-#include <uint256.h>
+#include <cstdint>
 
-#include <bls/bls.h>
+class CChain;
+class uint256;
 
-#include <cstdint>
+namespace Consensus {
+struct Params;
+} // namespace Consensus
+
+namespace llmq {
+class CQuorumManager;
+enum class VerifyRecSigStatus : uint8_t;
+} // namespace llmq
 
 namespace chainlock {
-struct ChainLockSig {
-private:
-    int32_t nHeight{-1};
-    uint256 blockHash;
-    CBLSSignature sig;
-
-public:
-    ChainLockSig();
-    ~ChainLockSig();
-
-    ChainLockSig(int32_t nHeight, const uint256& blockHash, const CBLSSignature& sig);
-
-    [[nodiscard]] int32_t getHeight() const { return nHeight; }
-    [[nodiscard]] const uint256& getBlockHash() const { return blockHash; }
-    [[nodiscard]] const CBLSSignature& getSig() const { return sig; }
-    [[nodiscard]] bool IsNull() const { return nHeight == -1 && blockHash == uint256(); }
-    [[nodiscard]] std::string ToString() const;
-
-    SERIALIZE_METHODS(ChainLockSig, obj)
-    {
-        READWRITE(obj.nHeight, obj.blockHash, obj.sig);
-    }
-};
+struct ChainLockSig;
 
 //! Generate clsig request ID with block height
 uint256 GenSigRequestId(const int32_t nHeight);
+
+llmq::VerifyRecSigStatus VerifyChainLock(const Consensus::Params& params, const CChain& chain,
+                                         const llmq::CQuorumManager& qman, const ChainLockSig& clsig);
 } // namespace chainlock
 
 #endif // BITCOIN_CHAINLOCK_CLSIG_H
diff --git a/src/chainlock/handler.cpp b/src/chainlock/handler.cpp
index 4e1392406bb3..b62a92b3d39c 100644
--- a/src/chainlock/handler.cpp
+++ b/src/chainlock/handler.cpp
@@ -4,20 +4,20 @@
 
 #include <chainlock/handler.h>
 
+#include <chain.h>
 #include <chainlock/chainlock.h>
+#include <chainlock/clsig.h>
+#include <chainparams.h>
+#include <consensus/validation.h>
 #include <instantsend/instantsend.h>
 #include <llmq/quorumsman.h>
 #include <masternode/sync.h>
 #include <msg_result.h>
-#include <stats/client.h>
-#include <util/std23.h>
-
-#include <chain.h>
-#include <chainparams.h>
-#include <consensus/validation.h>
 #include <node/interface_ui.h>
 #include <scheduler.h>
+#include <stats/client.h>
 #include <txmempool.h>
+#include <util/std23.h>
 #include <util/thread.h>
 #include <util/time.h>
 #include <validation.h>
@@ -325,13 +325,4 @@ void ChainlockHandler::Cleanup()
     }
 }
 
-llmq::VerifyRecSigStatus VerifyChainLock(const Consensus::Params& params, const CChain& chain,
-                                         const llmq::CQuorumManager& qman, const chainlock::ChainLockSig& clsig)
-{
-    const auto llmqType = params.llmqTypeChainLocks;
-    const uint256 request_id = chainlock::GenSigRequestId(clsig.getHeight());
-
-    return llmq::VerifyRecoveredSig(llmqType, chain, qman, clsig.getHeight(), request_id, clsig.getBlockHash(),
-                                    clsig.getSig());
-}
 } // namespace chainlock
diff --git a/src/chainlock/handler.h b/src/chainlock/handler.h
index e024ca539876..140325c007c6 100644
--- a/src/chainlock/handler.h
+++ b/src/chainlock/handler.h
@@ -24,20 +24,14 @@
 
 class CBlock;
 class CBlockIndex;
-class CChain;
 class CMasternodeSync;
 class ChainstateManager;
 class CScheduler;
 class CTxMemPool;
 struct MessageProcessingResult;
 
-namespace Consensus {
-struct Params;
-} // namespace Consensus
-
 namespace llmq {
 class CQuorumManager;
-enum class VerifyRecSigStatus : uint8_t;
 } // namespace llmq
 
 namespace chainlock {
@@ -107,9 +101,6 @@ class ChainlockHandler final : public CValidationInterface
 private:
     void Cleanup() EXCLUSIVE_LOCKS_REQUIRED(!cs);
 };
-
-llmq::VerifyRecSigStatus VerifyChainLock(const Consensus::Params& params, const CChain& chain,
-                                         const llmq::CQuorumManager& qman, const chainlock::ChainLockSig& clsig);
 } // namespace chainlock
 
 #endif // BITCOIN_CHAINLOCK_HANDLER_H
diff --git a/src/chainlock/signing.h b/src/chainlock/signing.h
index f19659727f72..e23a8b32305f 100644
--- a/src/chainlock/signing.h
+++ b/src/chainlock/signing.h
@@ -6,7 +6,6 @@
 #define BITCOIN_CHAINLOCK_SIGNING_H
 
 #include <chainlock/chainlock.h>
-#include <chainlock/clsig.h>
 #include <llmq/signing.h>
 #include <util/time.h>
 #include <validationinterface.h>
diff --git a/src/rpc/quorums.cpp b/src/rpc/quorums.cpp
index c2033cd48dcc..931c775ed9c0 100644
--- a/src/rpc/quorums.cpp
+++ b/src/rpc/quorums.cpp
@@ -5,6 +5,7 @@
 #include <active/context.h>
 #include <active/masternode.h>
 #include <chainlock/chainlock.h>
+#include <chainlock/clsig.h>
 #include <chainlock/handler.h>
 #include <evo/deterministicmns.h>
 #include <llmq/blockprocessor.h>
diff --git a/src/test/llmq_chainlock_tests.cpp b/src/test/llmq_chainlock_tests.cpp
index 69857f193b8b..b718cba9a342 100644
--- a/src/test/llmq_chainlock_tests.cpp
+++ b/src/test/llmq_chainlock_tests.cpp
@@ -8,7 +8,7 @@
 #include <streams.h>
 #include <util/strencodings.h>
 
-#include <chainlock/clsig.h>
+#include <chainlock/chainlock.h>
 
 #include <boost/test/unit_test.hpp>
 
diff --git a/src/test/util/llmq_tests.h b/src/test/util/llmq_tests.h
index 27666f4ba3c1..6852c1cbb07b 100644
--- a/src/test/util/llmq_tests.h
+++ b/src/test/util/llmq_tests.h
@@ -16,7 +16,7 @@
 #include <streams.h>
 #include <uint256.h>
 
-#include <chainlock/clsig.h>
+#include <chainlock/chainlock.h>
 #include <llmq/commitment.h>
 #include <llmq/params.h>
 
diff --git a/src/zmq/zmqpublishnotifier.cpp b/src/zmq/zmqpublishnotifier.cpp
index d174457dcdd3..ed5fd0ce2f6c 100644
--- a/src/zmq/zmqpublishnotifier.cpp
+++ b/src/zmq/zmqpublishnotifier.cpp
@@ -23,7 +23,7 @@
 
 #include <zmq.h>
 
-#include <chainlock/clsig.h>
+#include <chainlock/chainlock.h>
 #include <governance/common.h>
 #include <governance/vote.h>
 #include <instantsend/lock.h>